<div dir="ltr"><div class="markdown-here-wrapper" style="font-family:"Lucida Sans",Cantarell,Verdana,sans-serif;color:rgb(11,83,148)"><p style="margin:0px 0px 1.2em!important">Cool, thanks David! </p>
<p style="margin:0px 0px 1.2em!important">I’ll create a new MR and ask you for review.</p>
<div title="MDH:Q29vbCwgdGhhbmtzIERhdmlkIcKgPGRpdj48YnI+PC9kaXY+PGRpdj5JJ2xsIGNyZWF0ZSBhIG5l
dyBNUiBhbmQgYXNrIHlvdSBmb3IgcmV2aWV3LjwvZGl2Pg==" style="height:0;width:0;max-height:0;max-width:0;overflow:hidden;font-size:0em;padding:0;margin:0"></div></div></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Aug 9, 2017 at 11:54 AM David Gobbi <<a href="mailto:david.gobbi@gmail.com">david.gobbi@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>In fact, it might be best to structure the CMakeLists.txt to separate the private classes into their own list:</div><div><br></div><div>set(Module_SRCS </div><div> vtkSegY2DReader.cxx </div><div> vtkSegY3DReader.cxx </div><div>) </div><div> </div><div>set(Private_SRCS </div><div> vtkSegYIOUtils.cxx </div><div> vtkSegYReader.cxx </div><div> vtkSegYTraceReader.cxx </div><div>) </div><div> </div><div>vtk_module_library(vtkIOSegY ${Module_SRCS} ${Private_SRCS}) </div><div> </div><div>set_source_files_properties(${Private_SRCS} WRAP_EXCLUDE) </div><div>set_source_files_properties(${Private_SRCS} PROPERTIES WRAP_EXCLUDE_PYTHON 1)</div></div><div dir="ltr"><div class="gmail_extra"><br></div><div class="gmail_extra"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Aug 9, 2017 at 8:56 AM, David Gobbi <span dir="ltr"><<a href="mailto:david.gobbi@gmail.com" target="_blank">david.gobbi@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div><div><div class="m_3872421955109976898h5"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Aug 9, 2017 at 7:55 AM, Sankhesh Jhaveri <span dir="ltr"><<a href="mailto:sankhesh.jhaveri@kitware.com" target="_blank">sankhesh.jhaveri@kitware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="m_3872421955109976898m_-723911176315715327gmail-m_1881527992083850857markdown-here-wrapper" style="font-family:"Lucida Sans",Verdana,sans-serif;color:rgb(11,83,148)"><p style="margin:0px 0px 1.2em">Folks,</p>
<p style="margin:0px 0px 1.2em">We ported an external project to a VTK module (<code style="font-size:0.95em;font-family:Consolas,Inconsolata,Courier,monospace;margin:0px 0.15em;padding:0px 0.3em;white-space:pre-wrap;border:1px solid rgb(218,218,218);background-color:rgb(232,232,232);border-radius:3px;display:inline">vtkIOSegY</code>) that leads to compile issues for java bindings.</p>
<p style="margin:0px 0px 1.2em">Anyone know how to fix the java wrapping errors here:</p>
<p style="margin:0px 0px 1.2em"><a href="https://open.cdash.org/viewBuildError.php?onlydeltap&buildid=5011596" target="_blank">https://open.cdash.org/viewBuildError.php?onlydeltap&buildid=5011596</a></p>
<p style="margin:0px 0px 1.2em">The classes that it complains about are meant to be private implementations and not exported.</p>
<p style="margin:0px 0px 1.2em">Thank you!<br>Sankhesh</p>
<div title="MDH:Rm9sa3MsPGRpdj48YnI+PC9kaXY+PGRpdj5XZSBwb3J0ZWQgYW4gZXh0ZXJuYWwgcHJvamVjdCB0
byBhIFZUSyBtb2R1bGUgKGB2dGtJT1NlZ1lgKSB0aGF0IHNlZW1zIHRvIGNvbXBpbGUgZmluZSBi
dXQgbGVhZHMgdG8gY29tcGlsZSBpc3N1ZXMgZm9yIGphdmEgYmluZGluZ3MuPC9kaXY+PGRpdj48
YnI+PC9kaXY+PGRpdj5BbnlvbmUga25vdyBob3cgdG8gZml4IHRoZSBqYXZhIHdyYXBwaW5nIGVy
cm9ycyBoZXJlOjwvZGl2PjxkaXY+PGJyPjwvZGl2PjxkaXY+aHR0cHM6Ly9vcGVuLmNkYXNoLm9y
Zy92aWV3QnVpbGRFcnJvci5waHA/b25seWRlbHRhcCZhbXA7YnVpbGRpZD01MDExNTk2PGJyPjwv
ZGl2PjxkaXY+PGJyPjwvZGl2PjxkaXY+VGhlIGNsYXNzZXMgdGhhdCBpdCBjb21wbGFpbnMgYWJv
dXQgYXJlIG1lYW50IHRvIGJlIHByaXZhdGUgaW1wbGVtZW50YXRpb25zIGFuZCBub3QgZXhwb3J0
ZWQuPC9kaXY+PGRpdj48YnI+PC9kaXY+PGRpdj5UaGFuayB5b3UhPC9kaXY+PGRpdj5TYW5raGVz
aDwvZGl2Pg==" style="height:0px;width:0px;max-height:0px;max-width:0px;overflow:hidden;font-size:0em;padding:0px;margin:0px"></div></div></div><span class="m_3872421955109976898m_-723911176315715327gmail-HOEnZb"><font color="#888888"><div dir="ltr">-- <br></div><div class="m_3872421955109976898m_-723911176315715327gmail-m_1881527992083850857gmail_signature"><div dir="ltr"><div class="m_3872421955109976898m_-723911176315715327gmail-m_1881527992083850857inbox-markdown-here-wrapper" style="font-family:"proza libre",sans-serif;color:rgb(0,56,107)"><h5 id="m_3872421955109976898m_-723911176315715327gmail-m_1881527992083850857inbox-sankhesh-jhaveri" style="margin:1.3em 0px 1em;padding:0px;font-size:1.1em;border-bottom:1px solid rgb(238,238,238);font-weight:bold;color:rgb(11,65,148)">Sankhesh Jhaveri</h5>
<h6 id="m_3872421955109976898m_-723911176315715327gmail-m_1881527992083850857inbox--sr-research-development-engineer-kitware-http-www-kitware-com-518-881-4417" style="margin:1.3em 0px 1em;padding:0px;font-size:1em;color:rgb(11,83,148);font-family:"open sans",sans-serif;font-weight:normal"><em>Sr. Research & Development Engineer</em> | <a href="http://www.kitware.com/" target="_blank">Kitware</a> | <a href="tel:(518)%20881-4417" value="+15188814417" target="_blank">(518) 881-4417</a></h6></div></div></div></font></span></blockquote></div></div></div></div></div></div>
</blockquote></div><br></div></div></blockquote></div><div dir="ltr">-- <br></div><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div class="inbox-markdown-here-wrapper" style="font-family:'proza libre',sans-serif;color:rgb(0,56,107)"><h5 id="inbox-sankhesh-jhaveri" style="margin:1.3em 0px 1em;padding:0px;font-size:1.1em;border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:rgb(238,238,238);font-weight:bold;color:rgb(11,65,148)">Sankhesh Jhaveri</h5>
<h6 id="inbox--sr-research-development-engineer-kitware-http-www-kitware-com-518-881-4417" style="margin:1.3em 0px 1em;padding:0px;font-size:1em;color:rgb(11,83,148);font-family:'open sans',sans-serif;font-weight:normal"><em>Sr. Research & Development Engineer</em> | <a href="http://www.kitware.com/">Kitware</a> | (518) 881-4417</h6>
<div title="MDH:PGIgc3R5bGU9ImZvbnQtZmFtaWx5OiB2ZXJkYW5hLCBzYW5zLXNlcmlmOyBjb2xvcjogcmdiKDEx
LCA4MywgMTQ4KTsiPjxmb250IHNpemU9IjIiPiMjIyMjU2Fua2hlc2ggSmhhdmVyaTwvZm9udD48
L2I+PGRpdj48Zm9udCBjb2xvcj0iIzBiNTM5NCIgZmFjZT0idmVyZGFuYSwgc2Fucy1zZXJpZiIg
c2l6ZT0iMiI+PGI+PGJyPjwvYj48L2ZvbnQ+PGRpdj48c3BhbiBzdHlsZT0iZm9udC1mYW1pbHk6
IGFyaWFsLCBzYW5zLXNlcmlmOyBjb2xvcjogcmdiKDExLCA4MywgMTQ4KTsiPjxzcGFuIHN0eWxl
PSJmb250LWZhbWlseTogdmVyZGFuYSwgc2Fucy1zZXJpZjsiPjxpPiMjIyMjIypTci4gUmVzZWFy
Y2ggJmFtcDsgRGV2ZWxvcG1lbnQgRW5naW5lZXIqPC9pPiZuYnNwO3wmbmJzcDs8L3NwYW4+PC9z
cGFuPjxzcGFuIHN0eWxlPSJmb250LWZhbWlseTogdmVyZGFuYSwgc2Fucy1zZXJpZjsgY29sb3I6
IHJnYigxMSwgODMsIDE0OCk7Ij48YSBocmVmPSJodHRwOi8vd3d3LmtpdHdhcmUuY29tLyIgdGFy
Z2V0PSJfYmxhbmsiIHN0eWxlPSJjb2xvcjogcmdiKDE3LCA4NSwgMjA0KTsiPktpdHdhcmU8L2E+
Jm5ic3A7fCZuYnNwOzwvc3Bhbj48c3BhbiBzdHlsZT0iZm9udC1mYW1pbHk6IHZlcmRhbmEsIHNh
bnMtc2VyaWY7IGNvbG9yOiByZ2IoMTEsIDgzLCAxNDgpOyI+KDUxOCkgODgxLTQ0MTc8L3NwYW4+
PGJyPjwvZGl2PjxkaXY+PGRpdj48ZGl2PjxzcGFuIHN0eWxlPSJmb250LWZhbWlseTogdmVyZGFu
YSwgc2Fucy1zZXJpZjsgY29sb3I6IHJnYigxMSwgODMsIDE0OCk7Ij48L3NwYW4+PC9kaXY+PC9k
aXY+PC9kaXY+PC9kaXY+" style="height:0px;width:0px;max-height:0px;max-width:0px;overflow:hidden;font-size:0em;padding:0px;margin:0px"></div></div></div></div>