<div dir="ltr"><div>I will give the warnings in vtkBiDimensionalRepresentation2D a try.<br><br></div>JON HAITZ<br><br><div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><table style="color:rgb(0,0,0);font-family:'Times New Roman';font-size:medium" cellspacing="0" cellpadding="0" border="0" align="center"><tbody><tr><td></td></tr></tbody></table><pre style="color:rgb(0,0,0);word-wrap:break-word;white-space:pre-wrap">--<br><br></pre><div><div dir="ltr"></div></div></div></div></div></div></div></div></div></div></div></div>
<br><div class="gmail_quote">On 3 May 2017 at 17:06, Sean McBride <span dir="ltr"><<a href="mailto:sean@rogue-research.com" target="_blank">sean@rogue-research.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">There are about 20 of these left... does anyone want to tackle them or shall I suppress them all?  (Their presence, I believe, is making people miss other new warnings that cppcheck is finding.)<br>
<br>
Cheers,<br>
<br>
Sean<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
On Thu, 19 Jan 2017 22:13:24 -0500, Sean McBride said:<br>
<br>
>Hi all,<br>
><br>
>I've deliberately un-suppressed cppcheck's duplInheritedMember warning<br>
>and now we have 24 warnings here:<br>
><br>
><<a href="https://open.cdash.org/viewBuildError.php?type=1&buildid=4730716" rel="noreferrer" target="_blank">https://open.cdash.org/<wbr>viewBuildError.php?type=1&<wbr>buildid=4730716</a>><br>
><br>
>The warning is telling us that various classes have ivars with the same<br>
>name as an ivar in their superclass. This is a pretty bad code smell IMNSHO.<br>
><br>
>But it takes someone who knows the classes well to decide on the best fix...<br>
><br>
>The warnings are:<br>
><br>
>Charts/Core/vtkPlot3D.h:152: warning: The class 'vtkPlotSurface' defines<br>
>member variable with name 'Colors' also defined in its parent class<br>
>'vtkPlot3D'.<br>
><br>
>Charts/Core/vtkChartMatrix.h:<wbr>155: warning: The class<br>
>'vtkScatterPlotMatrix' defines member variable with name 'Private' also<br>
>defined in its parent class 'vtkChartMatrix'.<br>
><br>
>Common/DataModel/vtkPlanes.h:<wbr>129: warning: The class<br>
>'vtkPlanesIntersection' defines member variable with name 'Plane' also<br>
>defined in its parent class 'vtkPlanes'.<br>
><br>
>Common/DataModel/<wbr>vtkGenericCellTessellator.h:<wbr>211: warning: The class<br>
>'vtkSimpleCellTessellator' defines member variable with name 'DataSet'<br>
>also defined in its parent class 'vtkGenericCellTessellator'.<br>
><br>
>Common/ExecutionModel/<wbr>vtkStreamingDemandDrivenPipeli<wbr>ne.h:349: warning:<br>
>The class 'vtkCompositeDataPipeline' defines member variable with name<br>
>'UpdateExtentRequest' also defined in its parent class<br>
>'<wbr>vtkStreamingDemandDrivenPipeli<wbr>ne'.<br>
><br>
>Filters/FlowPaths/<wbr>vtkAbstractInterpolatedVelocit<wbr>yField.h:211: warning:<br>
>The class '<wbr>vtkCompositeInterpolatedVeloci<wbr>tyField' defines member<br>
>variable with name 'TOLERANCE_SCALE' also defined in its parent class<br>
>'<wbr>vtkAbstractInterpolatedVelocit<wbr>yField'.<br>
><br>
>IO/SQL/<wbr>vtkTableToDatabaseWriter.h:75: warning: The class<br>
>'vtkTableToSQLiteWriter' defines member variable with name 'Input' also<br>
>defined in its parent class 'vtkTableToDatabaseWriter'.<br>
><br>
>Imaging/Core/vtkImageReslice.<wbr>h:510: warning: The class<br>
>'vtkImageResample' defines member variable with name 'OutputSpacing'<br>
>also defined in its parent class 'vtkImageReslice'.<br>
><br>
>Interaction/Widgets/<wbr>vtkBiDimensionalRepresentation<wbr>.h:213: warning: The<br>
>class '<wbr>vtkBiDimensionalRepresentation<wbr>2D' defines member variable with<br>
>name 'Modifier' also defined in its parent class<br>
>'<wbr>vtkBiDimensionalRepresentation<wbr>'.<br>
><br>
>Interaction/Widgets/<wbr>vtkBiDimensionalRepresentation<wbr>.h:233: warning: The<br>
>class '<wbr>vtkBiDimensionalRepresentation<wbr>2D' defines member variable with<br>
>name 'P1World' also defined in its parent class<br>
>'<wbr>vtkBiDimensionalRepresentation<wbr>'.<br>
><br>
>Interaction/Widgets/<wbr>vtkBiDimensionalRepresentation<wbr>.h:234: warning: The<br>
>class '<wbr>vtkBiDimensionalRepresentation<wbr>2D' defines member variable with<br>
>name 'P2World' also defined in its parent class<br>
>'<wbr>vtkBiDimensionalRepresentation<wbr>'.<br>
><br>
>Interaction/Widgets/<wbr>vtkBiDimensionalRepresentation<wbr>.h:235: warning: The<br>
>class '<wbr>vtkBiDimensionalRepresentation<wbr>2D' defines member variable with<br>
>name 'P3World' also defined in its parent class<br>
>'<wbr>vtkBiDimensionalRepresentation<wbr>'.<br>
><br>
>Interaction/Widgets/<wbr>vtkBiDimensionalRepresentation<wbr>.h:236: warning: The<br>
>class '<wbr>vtkBiDimensionalRepresentation<wbr>2D' defines member variable with<br>
>name 'P4World' also defined in its parent class<br>
>'<wbr>vtkBiDimensionalRepresentation<wbr>'.<br>
><br>
>Interaction/Widgets/<wbr>vtkBiDimensionalRepresentation<wbr>.h:237: warning: The<br>
>class '<wbr>vtkBiDimensionalRepresentation<wbr>2D' defines member variable with<br>
>name 'P21World' also defined in its parent class<br>
>'<wbr>vtkBiDimensionalRepresentation<wbr>'.<br>
><br>
>Interaction/Widgets/<wbr>vtkBiDimensionalRepresentation<wbr>.h:238: warning: The<br>
>class '<wbr>vtkBiDimensionalRepresentation<wbr>2D' defines member variable with<br>
>name 'P43World' also defined in its parent class<br>
>'<wbr>vtkBiDimensionalRepresentation<wbr>'.<br>
><br>
>Interaction/Widgets/<wbr>vtkBiDimensionalRepresentation<wbr>.h:239: warning: The<br>
>class '<wbr>vtkBiDimensionalRepresentation<wbr>2D' defines member variable with<br>
>name 'T21' also defined in its parent class '<wbr>vtkBiDimensionalRepresentation<wbr>'.<br>
><br>
>Interaction/Widgets/<wbr>vtkBiDimensionalRepresentation<wbr>.h:240: warning: The<br>
>class '<wbr>vtkBiDimensionalRepresentation<wbr>2D' defines member variable with<br>
>name 'T43' also defined in its parent class '<wbr>vtkBiDimensionalRepresentation<wbr>'.<br>
><br>
>Interaction/Widgets/<wbr>vtkBiDimensionalRepresentation<wbr>.h:241: warning: The<br>
>class '<wbr>vtkBiDimensionalRepresentation<wbr>2D' defines member variable with<br>
>name 'CenterWorld' also defined in its parent class<br>
>'<wbr>vtkBiDimensionalRepresentation<wbr>'.<br>
><br>
>Interaction/Widgets/<wbr>vtkBiDimensionalRepresentation<wbr>.h:242: warning: The<br>
>class '<wbr>vtkBiDimensionalRepresentation<wbr>2D' defines member variable with<br>
>name 'StartEventPositionWorld' also defined in its parent class<br>
>'<wbr>vtkBiDimensionalRepresentation<wbr>'.<br>
><br>
>Rendering/Core/<wbr>vtkColorTransferFunction.h:<wbr>398: warning: The class<br>
>'<wbr>vtkDiscretizableColorTransferF<wbr>unction' defines member variable with<br>
>name 'BuildTime' also defined in its parent class 'vtkColorTransferFunction'.<br>
><br>
>Rendering/OpenGL/<wbr>vtkStandardPolyDataPainter.h:<wbr>86: warning: The class<br>
>'<wbr>vtkHardwareSelectionPolyDataPa<wbr>inter' defines member variable with name<br>
>'TotalCells' also defined in its parent class 'vtkStandardPolyDataPainter'.<br>
><br>
>Rendering/OpenGL/<wbr>vtkXRenderWindowInteractor.h:<wbr>198: warning: The class<br>
>'<wbr>vtkXRenderWindowTclInteractor' defines member variable with name<br>
>'Internal' also defined in its parent class 'vtkXRenderWindowInteractor'.<br>
><br>
>Views/Infovis/vtkRenderView.<wbr>h:289: warning: The class<br>
>'vtkGraphLayoutView' defines member variable with name 'Interacting'<br>
>also defined in its parent class 'vtkRenderView'.<br>
><br>
>Views/Infovis/<wbr>vtkRenderedRepresentation.h:<wbr>96: warning: The class<br>
>'<wbr>vtkRenderedTreeAreaRepresentat<wbr>ion' defines member variable with name<br>
>'Implementation' also defined in its parent class 'vtkRenderedRepresentation'.<br>
<br>
<br>
______________________________<wbr>_________________<br>
Powered by <a href="http://www.kitware.com" rel="noreferrer" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer" target="_blank">http://www.kitware.com/<wbr>opensource/opensource.html</a><br>
<br>
Search the list archives at: <a href="http://markmail.org/search/?q=vtk-developers" rel="noreferrer" target="_blank">http://markmail.org/search/?q=<wbr>vtk-developers</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://public.kitware.com/mailman/listinfo/vtk-developers" rel="noreferrer" target="_blank">http://public.kitware.com/<wbr>mailman/listinfo/vtk-<wbr>developers</a><br>
<br>
</div></div></blockquote></div><br></div></div></div>