<p dir="ltr">Den 4 nov. 2016 5:09 em skrev "Alvaro Sanchez" <<a href="mailto:alvaro.sanchez@kitware.com">alvaro.sanchez@kitware.com</a>>:<br>
><br>
> The patch was merged so the fix will be included in 7.1 final (not RC2 though). Jittering will now be turned off by default since it depends on the specific case whether it makes things better or not, so make sure you enable it manually (just like you were already). It is also possible to customize the noise function, check out the JitteringCustom test case.</p>
<p dir="ltr">Yes, was following the MR closely :) Didn't know it was on by default before.</p>
<p dir="ltr">Many thanks for handling this so quickly, and thanks also to the reviewers.</p>
<p dir="ltr">Have a nice weekend! </p>
<p dir="ltr">Elvis</p>
<p dir="ltr">><br>
> On Thu, Nov 3, 2016 at 8:26 AM, Elvis Stansvik <<a href="mailto:elvis.stansvik@orexplore.com">elvis.stansvik@orexplore.com</a>> wrote:<br>
>><br>
>> 2016-11-03 13:20 GMT+01:00 Alvaro Sanchez <<a href="mailto:alvaro.sanchez@kitware.com">alvaro.sanchez@kitware.com</a>>:<br>
>>><br>
>>> If I can get it reviewed today I could get it into 7.1 still, I will do my best.<br>
>><br>
>><br>
>> Thanks a lot, and if you can't make it, then I guess we can always backport it ourselves and keep it as a patch in the Debian package we're building.<br>
>><br>
>> Elvis<br>
>> <br>
>>><br>
>>><br>
>>> On Thu, Nov 3, 2016 at 8:09 AM, Elvis Stansvik <<a href="mailto:elvis.stansvik@orexplore.com">elvis.stansvik@orexplore.com</a>> wrote:<br>
>>>><br>
>>>> 2016-11-02 23:17 GMT+01:00 Elvis Stansvik <<a href="mailto:elvis.stansvik@orexplore.com">elvis.stansvik@orexplore.com</a>>:<br>
>>>>><br>
>>>>> Den 2 nov. 2016 12:17 fm skrev "Alvaro Sanchez" <<a href="mailto:alvaro.sanchez@kitware.com">alvaro.sanchez@kitware.com</a>>:<br>
>>>>> ><br>
>>>>> > Hi Elvis,<br>
>>>>> ><br>
>>>>> > the patch for this in <a href="https://gitlab.kitware.com/vtk/vtk/merge_requests/2130">https://gitlab.kitware.com/vtk/vtk/merge_requests/2130</a><br>
>>>>> ><br>
>>>>> > please give it a try and let me know if it helps.<br>
>>>>><br>
>>>>> Great, thanks a lot. I'll give it a go when I'm back at work tomorrow.<br>
>>>><br>
>>>> Got held up with some other things, but going to try it out now.<br>
>>>><br>
>>>> I saw that in the comments you said that this fix could wait until 8.0. No chance of backporting it to 7.1? We're basing our product on 7.1.0.rc1 at the moment, expecting to use 7.1 for our first release, so would love to have the fix in there.<br>
>>>><br>
>>>> Elvis<br>
>>>>><br>
>>>>> Elvis<br>
>>>>><br>
>>>>> ><br>
>>>>> > Cheers,<br>
>>>>> > Alvaro<br>
>>>>> ><br>
>>>>> ><br>
>>>>> > On Wed, Oct 26, 2016 at 11:59 AM, Elvis Stansvik <<a href="mailto:elvis.stansvik@orexplore.com">elvis.stansvik@orexplore.com</a>> wrote:<br>
>>>>> >><br>
>>>>> >> 2016-10-26 16:27 GMT+02:00 Alvaro Sanchez <<a href="mailto:alvaro.sanchez@kitware.com">alvaro.sanchez@kitware.com</a>>:<br>
>>>>> >> > Hi Elvis,<br>
>>>>> >> ><br>
>>>>> >> > I found the root cause of this, the noise texture is not being correctly<br>
>>>>> >> > sampled in the shader. I will tag you on the MR once the patch is ready so<br>
>>>>> >> > that you can try it out.<br>
>>>>> >><br>
>>>>> >> That's great news \o/ Thanks a lot Alvaro.<br>
>>>>> >><br>
>>>>> >> Elvis<br>
>>>>> >><br>
>>>>> >> ><br>
>>>>> >> > Cheers,<br>
>>>>> >> ><br>
>>>>> >> > On Thu, Oct 20, 2016 at 1:30 AM, Elvis Stansvik<br>
>>>>> >> > <<a href="mailto:elvis.stansvik@orexplore.com">elvis.stansvik@orexplore.com</a>> wrote:<br>
>>>>> >> >><br>
>>>>> >> >> 2016-10-20 5:46 GMT+02:00 Alvaro Sanchez <<a href="mailto:alvaro.sanchez@kitware.com">alvaro.sanchez@kitware.com</a>>:<br>
>>>>> >> >> > I ran your test program and I could reproduce the wood-grain artifacts<br>
>>>>> >> >> > you<br>
>>>>> >> >> > see. It seems to me that the jitter noise might need some tweaking. I<br>
>>>>> >> >> > will<br>
>>>>> >> >> > try a few things and investigate further, will let you know my findings.<br>
>>>>> >> >><br>
>>>>> >> >> Thanks Alvaro.<br>
>>>>> >> >><br>
>>>>> >> >> Elvis<br>
>>>>> >> >><br>
>>>>> >> >> ><br>
>>>>> >> >> ><br>
>>>>> >> >> > On Wed, Oct 19, 2016 at 8:07 AM, Elvis Stansvik<br>
>>>>> >> >> > <<a href="mailto:elvis.stansvik@orexplore.com">elvis.stansvik@orexplore.com</a>> wrote:<br>
>>>>> >> >> >><br>
>>>>> >> >> >> 2016-10-19 14:03 GMT+02:00 Alvaro Sanchez <<a href="mailto:alvaro.sanchez@kitware.com">alvaro.sanchez@kitware.com</a>>:<br>
>>>>> >> >> >> > Hi Elvis,<br>
>>>>> >> >> >> ><br>
>>>>> >> >> >> > thanks for the test case. Sorry, I did not have time to run it yet<br>
>>>>> >> >> >> > but<br>
>>>>> >> >> >> > I<br>
>>>>> >> >> >> > will have a look at it today.<br>
>>>>> >> >> >> ><br>
>>>>> >> >> >> > It seems unlikely to me that the small data spacing is affecting<br>
>>>>> >> >> >> > jittering.<br>
>>>>> >> >> >> > I will come back to you after debugging a bit with your test case.<br>
>>>>> >> >> >><br>
>>>>> >> >> >> Alright, no hurry. Thanks a lot for having a look.<br>
>>>>> >> >> >><br>
>>>>> >> >> >> Elvis<br>
>>>>> >> >> >><br>
>>>>> >> >> >> ><br>
>>>>> >> >> >> > Cheers,<br>
>>>>> >> >> >> > Alvaro<br>
>>>>> >> >> >> ><br>
>>>>> >> >> >> > On Wed, Oct 19, 2016 at 1:54 AM, Elvis Stansvik<br>
>>>>> >> >> >> > <<a href="mailto:elvis.stansvik@orexplore.com">elvis.stansvik@orexplore.com</a>> wrote:<br>
>>>>> >> >> >> >><br>
>>>>> >> >> >> >> 2016-10-15 11:16 GMT+02:00 Elvis Stansvik<br>
>>>>> >> >> >> >> <<a href="mailto:elvis.stansvik@orexplore.com">elvis.stansvik@orexplore.com</a>>:<br>
>>>>> >> >> >> >> > 2016-10-14 15:54 GMT+02:00 Alvaro Sanchez<br>
>>>>> >> >> >> >> > <<a href="mailto:alvaro.sanchez@kitware.com">alvaro.sanchez@kitware.com</a>>:<br>
>>>>> >> >> >> >> >> Hi Elvis,<br>
>>>>> >> >> >> >> >><br>
>>>>> >> >> >> >> >> the mapper uses a vtkPerlinNoise instance to generate the jitter<br>
>>>>> >> >> >> >> >> noise<br>
>>>>> >> >> >> >> >> and<br>
>>>>> >> >> >> >> >> as far as I know there are currently no knobs exposed to tweak<br>
>>>>> >> >> >> >> >> the<br>
>>>>> >> >> >> >> >> amount of<br>
>>>>> >> >> >> >> >> ray perturbation. Are you using the GL2 backend? It would also<br>
>>>>> >> >> >> >> >> be<br>
>>>>> >> >> >> >> >> good to<br>
>>>>> >> >> >> >> >> know what features are active along with ray jittering (multiple<br>
>>>>> >> >> >> >> >> components,<br>
>>>>> >> >> >> >> >> etc.), so if you could provide some sample data or code would be<br>
>>>>> >> >> >> >> >> very<br>
>>>>> >> >> >> >> >> helpful.<br>
>>>>> >> >> >> >> ><br>
>>>>> >> >> >> >> > Hi again Alvaro,<br>
>>>>> >> >> >> >> ><br>
>>>>> >> >> >> >> > Here's a minimal test case including sample data (129 MB):<br>
>>>>> >> >> >> >> ><br>
>>>>> >> >> >> >> > <a href="https://dl.dropboxusercontent.com/u/22350696/test_grain.tar.gz">https://dl.dropboxusercontent.com/u/22350696/test_grain.tar.gz</a><br>
>>>>> >> >> >> >> ><br>
>>>>> >> >> >> >> > Build with:<br>
>>>>> >> >> >> >> ><br>
>>>>> >> >> >> >> > cmake .<br>
>>>>> >> >> >> >> > make<br>
>>>>> >> >> >> >> ><br>
>>>>> >> >> >> >> > and run with:<br>
>>>>> >> >> >> >> ><br>
>>>>> >> >> >> >> > ./test_grain rec-0300mm-0400mm.xml<br>
>>>>> >> >> >> >> ><br>
>>>>> >> >> >> >> > The result should be as in the attached screenshot.<br>
>>>>> >> >> >> >><br>
>>>>> >> >> >> >> Anyone had time to run my test case? Are you seeing the same thing?<br>
>>>>> >> >> >> >><br>
>>>>> >> >> >> >> Elvis<br>
>>>>> >> >> >> >><br>
>>>>> >> >> >> >> ><br>
>>>>> >> >> >> >> > Elvis<br>
>>>>> >> >> >> >> ><br>
>>>>> >> >> >> >> >><br>
>>>>> >> >> >> >> >> Thanks!<br>
>>>>> >> >> >> >> >> Alvaro<br>
>>>>> >> >> >> >> >><br>
>>>>> >> >> >> >> >> On Fri, Oct 14, 2016 at 3:47 AM, Elvis Stansvik<br>
>>>>> >> >> >> >> >> <<a href="mailto:elvis.stansvik@orexplore.com">elvis.stansvik@orexplore.com</a>> wrote:<br>
>>>>> >> >> >> >> >>><br>
>>>>> >> >> >> >> >>> Hi all,<br>
>>>>> >> >> >> >> >>><br>
>>>>> >> >> >> >> >>> I updated our product to use VTK 7.1.0.rc1, as I was interested<br>
>>>>> >> >> >> >> >>> in<br>
>>>>> >> >> >> >> >>> trying out vtkGPUVolumeRayCastMapper::UseJitteringOn() to get<br>
>>>>> >> >> >> >> >>> rid<br>
>>>>> >> >> >> >> >>> of<br>
>>>>> >> >> >> >> >>> some woodgrain effects we're suffering from in our volume<br>
>>>>> >> >> >> >> >>> rendering<br>
>>>>> >> >> >> >> >>> (mostly when the volumes are rendered very opaque).<br>
>>>>> >> >> >> >> >>><br>
>>>>> >> >> >> >> >>> But turning the option on seems to have little to no effect.<br>
>>>>> >> >> >> >> >>> This<br>
>>>>> >> >> >> >> >>> is<br>
>>>>> >> >> >> >> >>> the result with the option on:<br>
>>>>> >> >> >> >> >>><br>
>>>>> >> >> >> >> >>> <a href="https://dl.dropboxusercontent.com/u/22350696/out.ogv">https://dl.dropboxusercontent.com/u/22350696/out.ogv</a><br>
>>>>> >> >> >> >> >>><br>
>>>>> >> >> >> >> >>> It looks about the same to me as it does with the option off.<br>
>>>>> >> >> >> >> >>><br>
>>>>> >> >> >> >> >>> Are there any knobs for this option? How does it determine how<br>
>>>>> >> >> >> >> >>> much<br>
>>>>> >> >> >> >> >>> to<br>
>>>>> >> >> >> >> >>> perturbate the rays?<br>
>>>>> >> >> >> >> >>><br>
>>>>> >> >> >> >> >>> Thanks for any advise.<br>
>>>>> >> >> >> >> >>><br>
>>>>> >> >> >> >> >>> Elvis<br>
>>>>> >> >> >> >> >>> _______________________________________________<br>
>>>>> >> >> >> >> >>> Powered by <a href="http://www.kitware.com">www.kitware.com</a><br>
>>>>> >> >> >> >> >>><br>
>>>>> >> >> >> >> >>> Visit other Kitware open-source projects at<br>
>>>>> >> >> >> >> >>> <a href="http://www.kitware.com/opensource/opensource.html">http://www.kitware.com/opensource/opensource.html</a><br>
>>>>> >> >> >> >> >>><br>
>>>>> >> >> >> >> >>> Search the list archives at:<br>
>>>>> >> >> >> >> >>> <a href="http://markmail.org/search/?q=vtk-developers">http://markmail.org/search/?q=vtk-developers</a><br>
>>>>> >> >> >> >> >>><br>
>>>>> >> >> >> >> >>> Follow this link to subscribe/unsubscribe:<br>
>>>>> >> >> >> >> >>> <a href="http://public.kitware.com/mailman/listinfo/vtk-developers">http://public.kitware.com/mailman/listinfo/vtk-developers</a><br>
>>>>> >> >> >> >> >>><br>
>>>>> >> >> >> >> >><br>
>>>>> >> >> >> >> >><br>
>>>>> >> >> >> >> >><br>
>>>>> >> >> >> >> >> --<br>
>>>>> >> >> >> >> >> Alvaro Sanchez<br>
>>>>> >> >> >> >> >> Kitware, Inc.<br>
>>>>> >> >> >> >> >> Senior R&D Engineer<br>
>>>>> >> >> >> >> >> 21 Corporate Drive<br>
>>>>> >> >> >> >> >> Clifton Park, NY 12065-8662<br>
>>>>> >> >> >> >> >> Phone: 518-881-4901<br>
>>>>> >> >> >> ><br>
>>>>> >> >> >> ><br>
>>>>> >> >> >> ><br>
>>>>> >> >> >> ><br>
>>>>> >> >> >> > --<br>
>>>>> >> >> >> > Alvaro Sanchez<br>
>>>>> >> >> >> > Kitware, Inc.<br>
>>>>> >> >> >> > Senior R&D Engineer<br>
>>>>> >> >> >> > 21 Corporate Drive<br>
>>>>> >> >> >> > Clifton Park, NY 12065-8662<br>
>>>>> >> >> >> > Phone: 518-881-4901<br>
>>>>> >> >> ><br>
>>>>> >> >> ><br>
>>>>> >> >> ><br>
>>>>> >> >> ><br>
>>>>> >> >> > --<br>
>>>>> >> >> > Alvaro Sanchez<br>
>>>>> >> >> > Kitware, Inc.<br>
>>>>> >> >> > Senior R&D Engineer<br>
>>>>> >> >> > 21 Corporate Drive<br>
>>>>> >> >> > Clifton Park, NY 12065-8662<br>
>>>>> >> >> > Phone: 518-881-4901<br>
>>>>> >> ><br>
>>>>> >> ><br>
>>>>> >> ><br>
>>>>> >> ><br>
>>>>> >> > --<br>
>>>>> >> > Alvaro Sanchez<br>
>>>>> >> > Kitware, Inc.<br>
>>>>> >> > Senior R&D Engineer<br>
>>>>> >> > 21 Corporate Drive<br>
>>>>> >> > Clifton Park, NY 12065-8662<br>
>>>>> >> > Phone: 518-881-4901<br>
>>>>> ><br>
>>>>> ><br>
>>>>> ><br>
>>>>> ><br>
>>>>> > -- <br>
>>>>> > Alvaro Sanchez<br>
>>>>> > Kitware, Inc.<br>
>>>>> > Senior R&D Engineer<br>
>>>>> > 21 Corporate Drive<br>
>>>>> > Clifton Park, NY 12065-8662<br>
>>>>> > Phone: 518-881-4901<br>
>>>><br>
>>>><br>
>>><br>
>>><br>
>>><br>
>>> -- <br>
>>> Alvaro Sanchez<br>
>>> Kitware, Inc.<br>
>>> Senior R&D Engineer<br>
>>> 21 Corporate Drive<br>
>>> Clifton Park, NY 12065-8662<br>
>>> Phone: 518-881-4901<br>
>><br>
>><br>
><br>
><br>
><br>
> -- <br>
> Alvaro Sanchez<br>
> Kitware, Inc.<br>
> Senior R&D Engineer<br>
> 21 Corporate Drive<br>
> Clifton Park, NY 12065-8662<br>
> Phone: 518-881-4901<br></p>