<div dir="ltr"><div>Hi Elvis,</div><div><br></div><div>the patch for this in <a href="https://gitlab.kitware.com/vtk/vtk/merge_requests/2130">https://gitlab.kitware.com/vtk/vtk/merge_requests/2130</a></div><div><br></div><div>please give it a try and let me know if it helps.</div><div><br></div><div>Cheers,</div><div>Alvaro</div><div><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 26, 2016 at 11:59 AM, Elvis Stansvik <span dir="ltr"><<a href="mailto:elvis.stansvik@orexplore.com" target="_blank">elvis.stansvik@orexplore.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">2016-10-26 16:27 GMT+02:00 Alvaro Sanchez <<a href="mailto:alvaro.sanchez@kitware.com">alvaro.sanchez@kitware.com</a>>:<br>
> Hi Elvis,<br>
><br>
</span><span class="">> I found the root cause of this, the noise texture is not being correctly<br>
> sampled in the shader. I will tag you on the MR once the patch is ready so<br>
> that you can try it out.<br>
<br>
</span>That's great news \o/ Thanks a lot Alvaro.<br>
<span class="HOEnZb"><font color="#888888"><br>
Elvis<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
><br>
> Cheers,<br>
><br>
> On Thu, Oct 20, 2016 at 1:30 AM, Elvis Stansvik<br>
> <<a href="mailto:elvis.stansvik@orexplore.com">elvis.stansvik@orexplore.com</a>> wrote:<br>
>><br>
>> 2016-10-20 5:46 GMT+02:00 Alvaro Sanchez <<a href="mailto:alvaro.sanchez@kitware.com">alvaro.sanchez@kitware.com</a>>:<br>
>> > I ran your test program and I could reproduce the wood-grain artifacts<br>
>> > you<br>
>> > see. It seems to me that the jitter noise might need some tweaking. I<br>
>> > will<br>
>> > try a few things and investigate further, will let you know my findings.<br>
>><br>
>> Thanks Alvaro.<br>
>><br>
>> Elvis<br>
>><br>
>> ><br>
>> ><br>
>> > On Wed, Oct 19, 2016 at 8:07 AM, Elvis Stansvik<br>
>> > <<a href="mailto:elvis.stansvik@orexplore.com">elvis.stansvik@orexplore.com</a>> wrote:<br>
>> >><br>
>> >> 2016-10-19 14:03 GMT+02:00 Alvaro Sanchez <<a href="mailto:alvaro.sanchez@kitware.com">alvaro.sanchez@kitware.com</a>>:<br>
>> >> > Hi Elvis,<br>
>> >> ><br>
>> >> > thanks for the test case. Sorry, I did not have time to run it yet<br>
>> >> > but<br>
>> >> > I<br>
>> >> > will have a look at it today.<br>
>> >> ><br>
>> >> > It seems unlikely to me that the small data spacing is affecting<br>
>> >> > jittering.<br>
>> >> > I will come back to you after debugging a bit with your test case.<br>
>> >><br>
>> >> Alright, no hurry. Thanks a lot for having a look.<br>
>> >><br>
>> >> Elvis<br>
>> >><br>
>> >> ><br>
>> >> > Cheers,<br>
>> >> > Alvaro<br>
>> >> ><br>
>> >> > On Wed, Oct 19, 2016 at 1:54 AM, Elvis Stansvik<br>
>> >> > <<a href="mailto:elvis.stansvik@orexplore.com">elvis.stansvik@orexplore.com</a>> wrote:<br>
>> >> >><br>
>> >> >> 2016-10-15 11:16 GMT+02:00 Elvis Stansvik<br>
>> >> >> <<a href="mailto:elvis.stansvik@orexplore.com">elvis.stansvik@orexplore.com</a>><wbr>:<br>
>> >> >> > 2016-10-14 15:54 GMT+02:00 Alvaro Sanchez<br>
>> >> >> > <<a href="mailto:alvaro.sanchez@kitware.com">alvaro.sanchez@kitware.com</a>>:<br>
>> >> >> >> Hi Elvis,<br>
>> >> >> >><br>
>> >> >> >> the mapper uses a vtkPerlinNoise instance to generate the jitter<br>
>> >> >> >> noise<br>
>> >> >> >> and<br>
>> >> >> >> as far as I know there are currently no knobs exposed to tweak<br>
>> >> >> >> the<br>
>> >> >> >> amount of<br>
>> >> >> >> ray perturbation. Are you using the GL2 backend? It would also<br>
>> >> >> >> be<br>
>> >> >> >> good to<br>
>> >> >> >> know what features are active along with ray jittering (multiple<br>
>> >> >> >> components,<br>
>> >> >> >> etc.), so if you could provide some sample data or code would be<br>
>> >> >> >> very<br>
>> >> >> >> helpful.<br>
>> >> >> ><br>
>> >> >> > Hi again Alvaro,<br>
>> >> >> ><br>
>> >> >> > Here's a minimal test case including sample data (129 MB):<br>
>> >> >> ><br>
>> >> >> > <a href="https://dl.dropboxusercontent.com/u/22350696/test_grain.tar.gz" rel="noreferrer" target="_blank">https://dl.dropboxusercontent.<wbr>com/u/22350696/test_grain.tar.<wbr>gz</a><br>
>> >> >> ><br>
>> >> >> > Build with:<br>
>> >> >> ><br>
>> >> >> > cmake .<br>
>> >> >> > make<br>
>> >> >> ><br>
>> >> >> > and run with:<br>
>> >> >> ><br>
>> >> >> > ./test_grain rec-0300mm-0400mm.xml<br>
>> >> >> ><br>
>> >> >> > The result should be as in the attached screenshot.<br>
>> >> >><br>
>> >> >> Anyone had time to run my test case? Are you seeing the same thing?<br>
>> >> >><br>
>> >> >> Elvis<br>
>> >> >><br>
>> >> >> ><br>
>> >> >> > Elvis<br>
>> >> >> ><br>
>> >> >> >><br>
>> >> >> >> Thanks!<br>
>> >> >> >> Alvaro<br>
>> >> >> >><br>
>> >> >> >> On Fri, Oct 14, 2016 at 3:47 AM, Elvis Stansvik<br>
>> >> >> >> <<a href="mailto:elvis.stansvik@orexplore.com">elvis.stansvik@orexplore.com</a>> wrote:<br>
>> >> >> >>><br>
>> >> >> >>> Hi all,<br>
>> >> >> >>><br>
>> >> >> >>> I updated our product to use VTK 7.1.0.rc1, as I was interested<br>
>> >> >> >>> in<br>
>> >> >> >>> trying out vtkGPUVolumeRayCastMapper::<wbr>UseJitteringOn() to get<br>
>> >> >> >>> rid<br>
>> >> >> >>> of<br>
>> >> >> >>> some woodgrain effects we're suffering from in our volume<br>
>> >> >> >>> rendering<br>
>> >> >> >>> (mostly when the volumes are rendered very opaque).<br>
>> >> >> >>><br>
>> >> >> >>> But turning the option on seems to have little to no effect.<br>
>> >> >> >>> This<br>
>> >> >> >>> is<br>
>> >> >> >>> the result with the option on:<br>
>> >> >> >>><br>
>> >> >> >>> <a href="https://dl.dropboxusercontent.com/u/22350696/out.ogv" rel="noreferrer" target="_blank">https://dl.dropboxusercontent.<wbr>com/u/22350696/out.ogv</a><br>
>> >> >> >>><br>
>> >> >> >>> It looks about the same to me as it does with the option off.<br>
>> >> >> >>><br>
>> >> >> >>> Are there any knobs for this option? How does it determine how<br>
>> >> >> >>> much<br>
>> >> >> >>> to<br>
>> >> >> >>> perturbate the rays?<br>
>> >> >> >>><br>
>> >> >> >>> Thanks for any advise.<br>
>> >> >> >>><br>
>> >> >> >>> Elvis<br>
>> >> >> >>> ______________________________<wbr>_________________<br>
>> >> >> >>> Powered by <a href="http://www.kitware.com" rel="noreferrer" target="_blank">www.kitware.com</a><br>
>> >> >> >>><br>
>> >> >> >>> Visit other Kitware open-source projects at<br>
>> >> >> >>> <a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer" target="_blank">http://www.kitware.com/<wbr>opensource/opensource.html</a><br>
>> >> >> >>><br>
>> >> >> >>> Search the list archives at:<br>
>> >> >> >>> <a href="http://markmail.org/search/?q=vtk-developers" rel="noreferrer" target="_blank">http://markmail.org/search/?q=<wbr>vtk-developers</a><br>
>> >> >> >>><br>
>> >> >> >>> Follow this link to subscribe/unsubscribe:<br>
>> >> >> >>> <a href="http://public.kitware.com/mailman/listinfo/vtk-developers" rel="noreferrer" target="_blank">http://public.kitware.com/<wbr>mailman/listinfo/vtk-<wbr>developers</a><br>
>> >> >> >>><br>
>> >> >> >><br>
>> >> >> >><br>
>> >> >> >><br>
>> >> >> >> --<br>
>> >> >> >> Alvaro Sanchez<br>
>> >> >> >> Kitware, Inc.<br>
>> >> >> >> Senior R&D Engineer<br>
>> >> >> >> 21 Corporate Drive<br>
>> >> >> >> Clifton Park, NY 12065-8662<br>
>> >> >> >> Phone: <a href="tel:518-881-4901" value="+15188814901">518-881-4901</a><br>
>> >> ><br>
>> >> ><br>
>> >> ><br>
>> >> ><br>
>> >> > --<br>
>> >> > Alvaro Sanchez<br>
>> >> > Kitware, Inc.<br>
>> >> > Senior R&D Engineer<br>
>> >> > 21 Corporate Drive<br>
>> >> > Clifton Park, NY 12065-8662<br>
>> >> > Phone: <a href="tel:518-881-4901" value="+15188814901">518-881-4901</a><br>
>> ><br>
>> ><br>
>> ><br>
>> ><br>
>> > --<br>
>> > Alvaro Sanchez<br>
>> > Kitware, Inc.<br>
>> > Senior R&D Engineer<br>
>> > 21 Corporate Drive<br>
>> > Clifton Park, NY 12065-8662<br>
>> > Phone: <a href="tel:518-881-4901" value="+15188814901">518-881-4901</a><br>
><br>
><br>
><br>
><br>
> --<br>
> Alvaro Sanchez<br>
> Kitware, Inc.<br>
> Senior R&D Engineer<br>
> 21 Corporate Drive<br>
> Clifton Park, NY 12065-8662<br>
> Phone: <a href="tel:518-881-4901" value="+15188814901">518-881-4901</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Alvaro Sanchez</div><div>Kitware, Inc.</div><div><span style="color:rgb(0,0,0);font-family:Arial;font-size:14.6667px;line-height:20.24px;white-space:pre-wrap">Senior </span>R&D Engineer</div><div>21 Corporate Drive</div><div>Clifton Park, NY 12065-8662</div><div>Phone: 518-881-4901</div></div></div></div></div>
</div></div>