<div dir="ltr">On Fri, Aug 12, 2016 at 4:03 PM, Bill Lorensen <span dir="ltr"><<a href="mailto:bill.lorensen@gmail.com" target="_blank">bill.lorensen@gmail.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">+2 Dave<br>
<br>
I wonder if we will need to change in the future...<br></blockquote><div><br></div><div>When we drop support for pre-C++11 compilers, we should probably change to use the new uint64_t everywhere regardless of the size of long. <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br>
<br>
On Fri, Aug 12, 2016 at 3:50 PM, David Cole <<a href="mailto:DLRdave@aol.com">DLRdave@aol.com</a>> wrote:<br>
> Think of how easy this fix would have been if vtkTypeMTime had already<br>
> existed .....<br>
><br>
><br>
><br>
> On Fri, Aug 12, 2016 at 3:43 PM, Bill Lorensen <<a href="mailto:bill.lorensen@gmail.com">bill.lorensen@gmail.com</a>> wrote:<br>
>> One advantage of naming a type is for backward compatibility:<br>
>> // Select an unsigned 64-bit integer type for use in MTime values.<br>
>> // If possible, use 'unsigned long' as we have historically.<br>
>> #if VTK_SIZEOF_LONG == 8<br>
>> typedef unsigned long vtkTypeMTime;<br>
>> #else<br>
>> typedef vtkTypeUInt64 vtkTypeMTime;<br>
>> #endif<br>
>><br>
>> also for apps that need to support old and new versions of VTK:<br>
>> // Provide this define to facilitate apps that need to support older<br>
>> // versions that do not have vtkTypeMTime<br>
>> #ifndef VTK_HAS_TYPE_MTIME<br>
>> #if VTK_SIZEOF_LONG == 8<br>
>> typedef unsigned long vtkTypeMTime;<br>
>> #else<br>
>> typedef vtkTypeUInt64 vtkTypeMTime;<br>
>> #endif<br>
>> #endif<br>
>><br>
>><br>
>> On Fri, Aug 12, 2016 at 3:22 PM, Berk Geveci <<a href="mailto:berk.geveci@kitware.com">berk.geveci@kitware.com</a>> wrote:<br>
>>> I also prefer vtkTypeUInt64 but not a strong preference. Both look good to<br>
>>> me.<br>
>>><br>
>>> On Fri, Aug 12, 2016 at 3:20 PM, Ken Martin <<a href="mailto:ken.martin@kitware.com">ken.martin@kitware.com</a>> wrote:<br>
>>>><br>
>>>> Oh, I am fine with the approach you took Bill and so haven't pushed the<br>
>>>> other changes I have locally. I just want the 32bit issue fixed as I think<br>
>>>> that is really important. I am flexible on how it gets fixed.<br>
>>>><br>
>>>> I am not a fan of introducing another typedef as I feel it makes the code<br>
>>>> harder to understand, but that is a really small issue and I can definitely<br>
>>>> live with the typedef. vtkTypeUInt64 is a typedef as well so, meh. So once<br>
>>>> your topic is baked let's get it committed.<br>
>>>><br>
>>>> Ken<br>
>>>><br>
>>>><br>
>>>><br>
>>>><br>
>>>> On Fri, Aug 12, 2016 at 3:12 PM, Bill Lorensen <<a href="mailto:bill.lorensen@gmail.com">bill.lorensen@gmail.com</a>><br>
>>>> wrote:<br>
>>>>><br>
>>>>> Folks,<br>
>>>>><br>
>>>>> We have two topics that fix the Windows mtime overflow issue for<br>
>>>>> Windows. This seems like a critical issue for Windows apps that run<br>
>>>>> for a long time (e.g. surgical applications).<br>
>>>>><br>
>>>>> Topic 1:<br>
>>>>> <a href="https://gitlab.kitware.com/vtk/vtk/merge_requests/1724" rel="noreferrer" target="_blank">https://gitlab.kitware.com/<wbr>vtk/vtk/merge_requests/1724</a><br>
>>>>> Files changed: 376<br>
>>>>><br>
>>>>> Topic 2:<br>
>>>>> <a href="https://gitlab.kitware.com/vtk/vtk/merge_requests/1790" rel="noreferrer" target="_blank">https://gitlab.kitware.com/<wbr>vtk/vtk/merge_requests/1790</a><br>
>>>>> Files changed: 471<br>
>>>>><br>
>>>>> The major difference is that topic 1 defines MTime as an unsigned long<br>
>>>>> and topic 2 introduces a new type vtkTypeMTime.<br>
>>>>><br>
>>>>> Topic 2 could be easily changed to use unsigned long for the mtime.<br>
>>>>><br>
>>>>> Please take some time to review these topics. I suspect that some<br>
>>>>> combination of the two will help solve the problem.<br>
>>>>><br>
>>>>> Bill<br>
>>>>> ______________________________<wbr>_________________<br>
>>>>> Powered by <a href="http://www.kitware.com" rel="noreferrer" target="_blank">www.kitware.com</a><br>
>>>>><br>
>>>>> Visit other Kitware open-source projects at<br>
>>>>> <a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer" target="_blank">http://www.kitware.com/<wbr>opensource/opensource.html</a><br>
>>>>><br>
>>>>> Search the list archives at: <a href="http://markmail.org/search/?q=vtk-developers" rel="noreferrer" target="_blank">http://markmail.org/search/?q=<wbr>vtk-developers</a><br>
>>>>><br>
>>>>> Follow this link to subscribe/unsubscribe:<br>
>>>>> <a href="http://public.kitware.com/mailman/listinfo/vtk-developers" rel="noreferrer" target="_blank">http://public.kitware.com/<wbr>mailman/listinfo/vtk-<wbr>developers</a><br>
>>>>><br>
>>>><br>
>>>><br>
>>>><br>
>>>> --<br>
>>>> Ken Martin PhD<br>
>>>> Chairman & CFO<br>
>>>> Kitware Inc.<br>
>>>> 28 Corporate Drive<br>
>>>> Clifton Park NY 12065<br>
>>>> <a href="tel:518%20371%203971" value="+15183713971">518 371 3971</a><br>
>>>><br>
>>>> This communication, including all attachments, contains confidential and<br>
>>>> legally privileged information, and it is intended only for the use of the<br>
>>>> addressee. Access to this email by anyone else is unauthorized. If you are<br>
>>>> not the intended recipient, any disclosure, copying, distribution or any<br>
>>>> action taken in reliance on it is prohibited and may be unlawful. If you<br>
>>>> received this communication in error please notify us immediately and<br>
>>>> destroy the original message. Thank you.<br>
>>>><br>
>>>> ______________________________<wbr>_________________<br>
>>>> Powered by <a href="http://www.kitware.com" rel="noreferrer" target="_blank">www.kitware.com</a><br>
>>>><br>
>>>> Visit other Kitware open-source projects at<br>
>>>> <a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer" target="_blank">http://www.kitware.com/<wbr>opensource/opensource.html</a><br>
>>>><br>
>>>> Search the list archives at: <a href="http://markmail.org/search/?q=vtk-developers" rel="noreferrer" target="_blank">http://markmail.org/search/?q=<wbr>vtk-developers</a><br>
>>>><br>
>>>> Follow this link to subscribe/unsubscribe:<br>
>>>> <a href="http://public.kitware.com/mailman/listinfo/vtk-developers" rel="noreferrer" target="_blank">http://public.kitware.com/<wbr>mailman/listinfo/vtk-<wbr>developers</a><br>
>>>><br>
>>>><br>
>>><br>
>><br>
>><br>
>><br>
>> --<br>
>> Unpaid intern in BillsBasement at noware dot com<br>
>> ______________________________<wbr>_________________<br>
>> Powered by <a href="http://www.kitware.com" rel="noreferrer" target="_blank">www.kitware.com</a><br>
>><br>
>> Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer" target="_blank">http://www.kitware.com/<wbr>opensource/opensource.html</a><br>
>><br>
>> Search the list archives at: <a href="http://markmail.org/search/?q=vtk-developers" rel="noreferrer" target="_blank">http://markmail.org/search/?q=<wbr>vtk-developers</a><br>
>><br>
>> Follow this link to subscribe/unsubscribe:<br>
>> <a href="http://public.kitware.com/mailman/listinfo/vtk-developers" rel="noreferrer" target="_blank">http://public.kitware.com/<wbr>mailman/listinfo/vtk-<wbr>developers</a><br>
>><br>
<br>
<br>
<br>
--<br>
Unpaid intern in BillsBasement at noware dot com<br>
______________________________<wbr>_________________<br>
Powered by <a href="http://www.kitware.com" rel="noreferrer" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer" target="_blank">http://www.kitware.com/<wbr>opensource/opensource.html</a><br>
<br>
Search the list archives at: <a href="http://markmail.org/search/?q=vtk-developers" rel="noreferrer" target="_blank">http://markmail.org/search/?q=<wbr>vtk-developers</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://public.kitware.com/mailman/listinfo/vtk-developers" rel="noreferrer" target="_blank">http://public.kitware.com/<wbr>mailman/listinfo/vtk-<wbr>developers</a><br>
<br>
</div></div></blockquote></div><br></div></div>