<div dir="ltr">I feel the additional typedef makes it more confusing as you do not know what the type is. vtkTypeUInt64 I can understand from its name. If everyone wants a new typedef I can certainly live with it though but I would still rather it be consistent on unix and windows, so that people can fix the issue on Unix and have some confidence it will work/compile on Windows. <div><br></div><div>I have an updated topic here</div><div><br></div><div><a href="https://gitlab.kitware.com/vtk/vtk/merge_requests/1724">https://gitlab.kitware.com/vtk/vtk/merge_requests/1724</a><br></div><div><br></div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Aug 5, 2016 at 3:45 PM, Bill Lorensen <span dir="ltr"><<a href="mailto:bill.lorensen@gmail.com" target="_blank">bill.lorensen@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Why not in vtkType.h<br>
#if defined(WIN32)<br>
typedef vtkTypeUInt64 vtkTypeMTime;<br>
#else<br>
typedef unsigned long vtkTypeMTime;<br>
#endif<br>
<br>
In vtkObject.h and other GetMTimes'<br>
virtual vtkTypeMTime GetMTime();<br>
<br>
Windows apps will have to change their GetMTimes' in their VTK derived<br>
subclasses.<br>
<br>
<br>
<br>
On Thu, Aug 4, 2016 at 1:28 PM, Robert Maynard<br>
<<a href="mailto:robert.maynard@kitware.com">robert.maynard@kitware.com</a>> wrote:<br>
> I agree with David. I prefer correctness to full backwards<br>
> compatibility, especially so with something like consistently having<br>
> 64bit MTimes on all platforms.<br>
><br>
> Personally I don't see the value in having the return type as a<br>
> typedef compared to having the caller do a static cast ( which is what<br>
> MTime would have to do internally ).<br>
><br>
> On Thu, Aug 4, 2016 at 12:53 PM, David Cole via vtk-developers<br>
> <<a href="mailto:vtk-developers@vtk.org">vtk-developers@vtk.org</a>> wrote:<br>
>> Except.... I think fixing the overflow bug on Windows is more<br>
>> important than full source compatibility. A default build (no need to<br>
>> set anything in CMake) of the new version of VTK on Windows with this<br>
>> capability should result in 64-bit MTime values and avoid the overflow<br>
>> condition.<br>
>><br>
>> I prefer correctness to full/100% backwards compatibility.<br>
>><br>
>><br>
>><br>
>><br>
>> On Thu, Aug 4, 2016 at 11:27 AM, Sean McBride <<a href="mailto:sean@rogue-research.com">sean@rogue-research.com</a>> wrote:<br>
>>> On Thu, 4 Aug 2016 10:32:23 -0400, David Cole via vtk-developers said:<br>
>>><br>
>>>>A nice-to-the-user-who-needs-<wbr>that capability would be to typedef a<br>
>>>>type for the return value of GetMTime, and then allow for user<br>
>>>>definition of that type. Default to uint64_t, but allow for user<br>
>>>>definition.<br>
>>><br>
>>> Was just going to suggest that. It could be typedefed to exactly what it is today, giving full source compatibility; and then if you build with VTK_LEGACY_REMOVE (or similar) it could be typedefed to the new 64 bit type.<br>
>>><br>
>>> Cheers,<br>
>>><br>
>>> --<br>
>>> ______________________________<wbr>______________________________<br>
>>> Sean McBride, B. Eng <a href="mailto:sean@rogue-research.com">sean@rogue-research.com</a><br>
>>> Rogue Research <a href="http://www.rogue-research.com" rel="noreferrer" target="_blank">www.rogue-research.com</a><br>
>>> Mac Software Developer Montréal, Québec, Canada<br>
>>><br>
>>><br>
>> ______________________________<wbr>_________________<br>
>> Powered by <a href="http://www.kitware.com" rel="noreferrer" target="_blank">www.kitware.com</a><br>
>><br>
>> Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer" target="_blank">http://www.kitware.com/<wbr>opensource/opensource.html</a><br>
>><br>
>> Search the list archives at: <a href="http://markmail.org/search/?q=vtk-developers" rel="noreferrer" target="_blank">http://markmail.org/search/?q=<wbr>vtk-developers</a><br>
>><br>
>> Follow this link to subscribe/unsubscribe:<br>
>> <a href="http://public.kitware.com/mailman/listinfo/vtk-developers" rel="noreferrer" target="_blank">http://public.kitware.com/<wbr>mailman/listinfo/vtk-<wbr>developers</a><br>
>><br>
> ______________________________<wbr>_________________<br>
> Powered by <a href="http://www.kitware.com" rel="noreferrer" target="_blank">www.kitware.com</a><br>
><br>
> Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer" target="_blank">http://www.kitware.com/<wbr>opensource/opensource.html</a><br>
><br>
> Search the list archives at: <a href="http://markmail.org/search/?q=vtk-developers" rel="noreferrer" target="_blank">http://markmail.org/search/?q=<wbr>vtk-developers</a><br>
><br>
> Follow this link to subscribe/unsubscribe:<br>
> <a href="http://public.kitware.com/mailman/listinfo/vtk-developers" rel="noreferrer" target="_blank">http://public.kitware.com/<wbr>mailman/listinfo/vtk-<wbr>developers</a><br>
><br>
<span class="HOEnZb"><font color="#888888"><br>
<br>
<br>
--<br>
Unpaid intern in BillsBasement at noware dot com<br>
______________________________<wbr>_________________<br>
Powered by <a href="http://www.kitware.com" rel="noreferrer" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer" target="_blank">http://www.kitware.com/<wbr>opensource/opensource.html</a><br>
<br>
Search the list archives at: <a href="http://markmail.org/search/?q=vtk-developers" rel="noreferrer" target="_blank">http://markmail.org/search/?q=<wbr>vtk-developers</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://public.kitware.com/mailman/listinfo/vtk-developers" rel="noreferrer" target="_blank">http://public.kitware.com/<wbr>mailman/listinfo/vtk-<wbr>developers</a><br>
<br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">Ken Martin PhD<div>Chairman & CFO<br>Kitware Inc.<br>28 Corporate Drive<br>Clifton Park NY 12065<br>518 371 3971<div><br></div><div><span style="font-size:10pt;font-family:Tahoma,sans-serif">This communication,
including all attachments, contains confidential and legally privileged
information, and it is intended only for the use of the addressee. Access to this email by anyone else is
unauthorized. If you are not the intended recipient, any disclosure, copying,
distribution or any action taken in reliance on it is prohibited and may be
unlawful. If you received this communication in error please notify us
immediately and destroy the original message.
Thank you.</span></div></div></div>
</div>