<div dir="ltr">> 1) Did you mean to commit that commented code in Accelerators/Piston/vtkPistonMapper.cxx ?<br><div class="gmail_extra"><br></div><div class="gmail_extra">Kind of :-) Piston is not moving forward because it was replaced by VTK-m. So before VTK 8, we will yank the Piston module out. That was quick (and dirty) way of making it compile with my changes. It is not worth the effort to make it work at this point.</div><div class="gmail_extra"><br></div><div class="gmail_extra">> do I understand correctly that I can now just do:<br>><br>> slicer->UpdateWholeExtent();<br></div><div class="gmail_extra"><br></div><div class="gmail_extra">Yes. I didn't add this API btw. It was already there.</div><div class="gmail_extra"><br></div><div class="gmail_extra"><span style="color:rgb(80,0,80);font-size:12.8px">>>Here is the branch that passes all of the tests:</span><br style="color:rgb(80,0,80);font-size:12.8px"><span style="color:rgb(80,0,80);font-size:12.8px">>></span><br style="color:rgb(80,0,80);font-size:12.8px"><span style="color:rgb(80,0,80);font-size:12.8px">>></span><a href="https://gitlab.kitware.com/berkgeveci/vtk/commits/setupdateextent-change" rel="noreferrer" target="_blank" style="font-size:12.8px">https://gitlab.kitware.com/berkgeveci/vtk/commits/setupdateextent-change</a><br style="color:rgb(80,0,80);font-size:12.8px"></div><div class="gmail_extra">></div><div class="gmail_extra">> <span style="font-size:12.8px">Shame that link is dead just </span><span class="" tabindex="0" style="font-size:12.8px"><span class="">6 weeks later</span></span><span style="font-size:12.8px">. Makes it harder to research what/when changes broke things... :(</span></div><div class="gmail_extra"><span style="font-size:12.8px"><br></span></div><div class="gmail_extra"><span style="font-size:12.8px">That's totally my bad. I pointed to the branch on my fork and then deleted the branch after the merge. Here is the permanent link:</span></div><div class="gmail_extra"><span style="font-size:12.8px"><br></span></div><div class="gmail_extra"><span style="font-size:12.8px"><a href="https://gitlab.kitware.com/vtk/vtk/merge_requests/1090">https://gitlab.kitware.com/vtk/vtk/merge_requests/1090</a></span><br></div><div class="gmail_extra"><span style="font-size:12.8px"><br></span></div><div class="gmail_extra"><span style="font-size:12.8px">Best,</span></div><div class="gmail_extra"><span style="font-size:12.8px">-berk</span></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Mar 1, 2016 at 12:39 PM, Sean McBride <span dir="ltr"><<a href="mailto:sean@rogue-research.com" target="_blank">sean@rogue-research.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span class="">On Fri, 15 Jan 2016 10:57:36 -0500, Berk Geveci said:<br>
<br>
>In an effort to address a bug reported on the mailing list, I ended up<br>
>making a change to the way the pipeline is updated. I made a minor change<br>
>to the way update behaves but more importantly, I'd like to make an API<br>
>change that is biggish.<br>
<br>
</span>Berk,<br>
<br>
After rebuilding my app with VTK master I've run into this.<br>
<br>
I just went through the change with git show f020ebb6 and had 2 comments on the code change:<br>
<br>
1) Did you mean to commit that commented code in Accelerators/Piston/vtkPistonMapper.cxx ?<br>
<br>
2)<br>
<br>
+The following new methods were added:<br>
+<br>
+### vtkAlgorithm:<br>
+<br>
+ int Update(int port, vtkInformationVector* requests);<br>
+ int Update(vtkInformation* requests);<br>
+ int UpdatePiece(int piece, int numPieces, int ghostLevels, int* extents=0);<br>
+ int UpdateExtent(int piece, int numPieces, int ghostLevels, int* extents=0);<br>
+ int UpdateTimeStep(double time,<br>
+ int piece=-1, int numPieces=1, int ghostLevels=0, int* extents=0);<br>
<br>
Couldn't those 'extents' params be const? I know many VTK API are not very const friendly, but seems a shame to perpetuate that with new API.<br>
<span class=""><br>
>Here is how an algorithm is updated currently.<br>
><br>
>anAlgorithm->Update();<br>
><br>
>If you want the algorithm to produce a particular subset in space or time,<br>
>you need to do this:<br>
><br>
>anAlgorithm->UpdateInformation();<br>
>anAlgorithm->SetUpdateExtent(0, 2, 0);<br>
>anAlgorithm->SetUpdateExtent(0, 10, 0, 10, 1, 1);<br>
>anAlgorithm->SetUpdateTimeStep(0.5);<br>
>anAlgorithm->Update();<br>
<br>
</span>My app has a few of this pattern:<br>
<br>
slicer->UpdateInformation();<br>
slicer->SetUpdateExtentToWholeExtent();<br>
slicer->Update();<br>
<br>
do I understand correctly that I can now just do:<br>
<br>
slicer->UpdateWholeExtent();<br>
<span class=""><br>
>Here is the branch that passes all of the tests:<br>
><br>
><a href="https://gitlab.kitware.com/berkgeveci/vtk/commits/setupdateextent-change" rel="noreferrer" target="_blank">https://gitlab.kitware.com/berkgeveci/vtk/commits/setupdateextent-change</a><br>
<br>
</span>Shame that link is dead just 6 weeks later. Makes it harder to research what/when changes broke things... :(<br>
<br>
Thanks,<br>
<span class=""><font color="#888888"><br>
--<br>
____________________________________________________________<br>
Sean McBride, B. Eng <a href="mailto:sean@rogue-research.com">sean@rogue-research.com</a><br>
Rogue Research <a href="http://www.rogue-research.com" rel="noreferrer" target="_blank">www.rogue-research.com</a><br>
Mac Software Developer Montréal, Québec, Canada<br>
<br>
<br>
</font></span></blockquote></div><br></div></div>