<div dir="ltr">Thank you Ken,<div><br></div><div>I confirm that fixes the two issues.</div></div><div class="gmail_extra"><br><div class="gmail_quote">2015-10-08 21:16 GMT+02:00 Ken Martin <span dir="ltr"><<a href="mailto:ken.martin@kitware.com" target="_blank">ken.martin@kitware.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div lang="EN-US" link="blue" vlink="purple"><div><p class="MsoNormal"><a name="15048e2739cdb566__MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">OK I updated the earlier topic with a fix for this and I threw in the fix for the Mapper2D, hopefully I will merge tomorrow.</span></a></p><span class=""><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Thanks</span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Ken</span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Ken Martin PhD</span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Chairman & CFO</span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Kitware Inc.</span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">28 Corporate Drive</span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Clifton Park NY 12065</span></p><p class="MsoNormal"><a href="mailto:ken.martin@kitware.com" target="_blank"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">ken.martin@kitware.com</span></a><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><a href="tel:919%20869-8871" value="+19198698871" target="_blank">919 869-8871</a> (w)</span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">This communication, including all attachments, contains confidential and legally privileged information, and it is intended only for the use of the addressee.  Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken in reliance on it is prohibited and may be unlawful. If you received this communication in error please notify us immediately and destroy the original message.  Thank you.</span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span></p></span><p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Xabi Riobe [mailto:<a href="mailto:xabivtk@gmail.com" target="_blank">xabivtk@gmail.com</a>] <br><b>Sent:</b> Wednesday, October 7, 2015 5:33 AM</span></p><div><div class="h5"><br><b>To:</b> Ken Martin<br><b>Subject:</b> Re: [vtk-developers] Fwd: Picking problem with OpenGL2 and DepthPeeling</div></div><p></p><div><div class="h5"><p class="MsoNormal"> </p><div><p class="MsoNormal">Ok, keep me updated and of course if you want me to test things i will take time to do it !</p><div><p class="MsoNormal"> </p></div><div><p class="MsoNormal">I found an other issue related to VBO update but i will create another thread with example.</p></div></div><div><p class="MsoNormal"> </p><div><p class="MsoNormal">2015-10-06 15:54 GMT+02:00 Ken Martin <<a href="mailto:ken.martin@kitware.com" target="_blank">ken.martin@kitware.com</a>>:</p><div><div><p class="MsoNormal"><a name="15048e2739cdb566_1503d6e99f564316__MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Yes, I can reproduce that issue thanks to your great example. It is a bug and I have added it to the list.</span></a></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Thanks</span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Ken</span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Ken Martin PhD</span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Chairman & CFO</span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Kitware Inc.</span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">28 Corporate Drive</span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Clifton Park NY 12065</span></p><p class="MsoNormal"><a href="mailto:ken.martin@kitware.com" target="_blank"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">ken.martin@kitware.com</span></a></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><a href="tel:919%20869-8871" target="_blank">919 869-8871</a> (w)</span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">This communication, including all attachments, contains confidential and legally privileged information, and it is intended only for the use of the addressee.  Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken in reliance on it is prohibited and may be unlawful. If you received this communication in error please notify us immediately and destroy the original message.  Thank you.</span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span></p><p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Xabi Riobe [mailto:<a href="mailto:xabivtk@gmail.com" target="_blank">xabivtk@gmail.com</a>] <br><b>Sent:</b> Wednesday, September 30, 2015 10:49 AM<br><b>To:</b> Ken Martin<br><b>Subject:</b> Re: [vtk-developers] Fwd: Picking problem with OpenGL2 and DepthPeeling</span></p><div><div><p class="MsoNormal"> </p><div><p class="MsoNormal">Thanks Ken,</p><div><p class="MsoNormal">I tried it and it fixes the depth peeling issue, but i still have another one (not introduced with your changes as it was already there) related to picker.</p><div><p class="MsoNormal"> </p></div><div><p class="MsoNormal">Here is a sample to reproduce it: click on the spheres and the color must change green/red. the first click is good, but then it is almost always the plane that is picked unless you select the very edge of the external spheres.</p></div></div><div><p class="MsoNormal"> </p></div><div><p class="MsoNormal">I tested without opengl2 and it works as expected.</p></div></div><div><p class="MsoNormal"> </p><div><p class="MsoNormal">2015-09-29 17:57 GMT+02:00 Ken Martin <<a href="mailto:ken.martin@kitware.com" target="_blank">ken.martin@kitware.com</a>>:</p><div><div><p class="MsoNormal"><a name="15048e2739cdb566_1503d6e99f564316_15019d30514d036b__MailE"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">OK I think the following topic should fix the issue. </span></a></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span></p><p class="MsoNormal"><a href="https://gitlab.kitware.com/vtk/vtk/merge_requests/706" target="_blank"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">https://gitlab.kitware.com/vtk/vtk/merge_requests/706</span></a></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Ken Martin PhD</span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Chairman & CFO</span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Kitware Inc.</span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">28 Corporate Drive</span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Clifton Park NY 12065</span></p><p class="MsoNormal"><a href="mailto:ken.martin@kitware.com" target="_blank"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">ken.martin@kitware.com</span></a></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><a href="tel:919%20869-8871" target="_blank">919 869-8871</a> (w)</span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">This communication, including all attachments, contains confidential and legally privileged information, and it is intended only for the use of the addressee.  Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken in reliance on it is prohibited and may be unlawful. If you received this communication in error please notify us immediately and destroy the original message.  Thank you.</span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span></p><p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> vtk-developers [mailto:<a href="mailto:vtk-developers-bounces@vtk.org" target="_blank">vtk-developers-bounces@vtk.org</a>] <b>On Behalf Of </b>Xabi Riobe<br><b>Sent:</b> Friday, September 25, 2015 7:50 AM<br><b>To:</b> VTK Developers<br><b>Subject:</b> [vtk-developers] Fwd: Picking problem with OpenGL2 and DepthPeeling</span></p><div><div><p class="MsoNormal"> </p><div><div><div><p class="MsoNormal">Hi Ken,</p><div><p class="MsoNormal"> </p></div><div><p class="MsoNormal">with the patch we can pick the transparent surfaces but not the opaque ones anymore. for example in the sample you can pick on the plane but not on the spheres that are created.</p></div></div><div><div><div><p class="MsoNormal"> </p><div><p class="MsoNormal">2015-09-24 16:37 GMT+02:00 Ken Martin <<a href="mailto:ken.martin@kitware.com" target="_blank">ken.martin@kitware.com</a>>:</p><div><div><p class="MsoNormal"><a name="15048e2739cdb566_1503d6e99f564316_15019d30514d036b_150045"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Thanks! I believe the new depth peeling code is probably leaving the zbuffer in a different state than the opaque z buffer. If you get a second could you try the attached patch and see if it works for you. It is based on a more recent VTK but it is a tiny patch.</span></a></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Thanks</span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Ken</span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Ken Martin PhD</span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Chairman & CFO</span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Kitware Inc.</span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">28 Corporate Drive</span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Clifton Park NY 12065</span></p><p class="MsoNormal"><a href="mailto:ken.martin@kitware.com" target="_blank"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">ken.martin@kitware.com</span></a></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><a href="tel:919%20869-8871" target="_blank">919 869-8871</a> (w)</span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">This communication, including all attachments, contains confidential and legally privileged information, and it is intended only for the use of the addressee.  Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken in reliance on it is prohibited and may be unlawful. If you received this communication in error please notify us immediately and destroy the original message.  Thank you.</span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span></p><p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> vtk-developers [mailto:<a href="mailto:vtk-developers-bounces@vtk.org" target="_blank">vtk-developers-bounces@vtk.org</a>] <b>On Behalf Of </b>Xabi Riobe<br><b>Sent:</b> Thursday, September 24, 2015 5:29 AM<br><b>To:</b> VTK Developers<br><b>Subject:</b> [vtk-developers] Picking problem with OpenGL2 and DepthPeeling</span></p><div><div><p class="MsoNormal"> </p><div><p class="MsoNormal">Hi,</p><div><p class="MsoNormal"> </p></div><div><p class="MsoNormal">I try to pick in a scene that contains a translucent object and the pick fails if I use the OpenGL2 backend (v6.3.0), tested on VS2013 32 bits with nVidia Quadro 4000 (driver 353.30)</p></div><div><p class="MsoNormal"> </p></div><div><p class="MsoNormal">The same code works with OpenGL backend.</p></div><div><p class="MsoNormal"> </p></div><div><p class="MsoNormal">I can reproduce it with the sample code attached, based on the example at <a href="http://www.vtk.org/Wiki/VTK/Examples/Cxx/Interaction/Picking" target="_blank">http://www.vtk.org/Wiki/VTK/Examples/Cxx/Interaction/Picking</a>  with these lines added:</p></div><div><p class="MsoNormal"> </p></div><div><div><p class="MsoNormal">   renderer->SetUseDepthPeeling(1);</p></div><div><p class="MsoNormal">   renderer->SetMaximumNumberOfPeels(8);</p></div><div><p class="MsoNormal">   renderWindow->SetAlphaBitPlanes(1);</p></div><div><p class="MsoNormal">   renderWindow->SetMultiSamples(0);</p></div></div><div><p class="MsoNormal"> </p></div><div><p class="MsoNormal">and the opacity set to 0.5 for the plane.</p></div><div><p class="MsoNormal"> </p></div><div><p class="MsoNormal">If i don't use depth peeling, or if the plane is opaque, the picker works as expected.</p></div><div><p class="MsoNormal"> </p></div><div><p class="MsoNormal">It seems that the pick fails when in vtkOpenGLRenderer::DonePick the float value returned by GetZbufferData is 1.0</p></div><div><p class="MsoNormal"> </p></div><div><p class="MsoNormal"> </p></div><div><p class="MsoNormal"> </p></div></div></div></div></div></div></div><p class="MsoNormal"> </p></div></div></div></div><p class="MsoNormal"> </p></div></div></div></div></div></div><p class="MsoNormal"> </p></div></div></div></div></div></div><p class="MsoNormal"> </p></div></div></div></div></div>
</blockquote></div><br></div>