<div dir="ltr">Well, if we're changing it anyway...<div><br></div><div>I'd prefer<div><br></div><div>void func()</div><div>{</div><div> if (...) {</div><div> ...</div><div> }</div><div> else {</div><div> ...</div><div> }</div><div>}</div><div><br></div><div>Less wasted vertical space = more code on the screen, and it's a common style with great editor support. I've always been a fan of the Qt coding style.</div></div><div><br></div><div><a href="https://wiki.qt.io/Qt_Coding_Style">https://wiki.qt.io/Qt_Coding_Style</a><br></div><div><br></div><div>That said, either would be fine with me.</div><div><br></div><div>Dave</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Sep 9, 2015 at 9:14 AM, David E DeMarle <span dir="ltr"><<a href="mailto:dave.demarle@kitware.com" target="_blank">dave.demarle@kitware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">+1<div><br><div><br></div></div></div><div class="gmail_extra"><br clear="all"><div><div>David E DeMarle<br>Kitware, Inc.<br>R&D Engineer<br>21 Corporate Drive<br>Clifton Park, NY 12065-8662<br>Phone: <a href="tel:518-881-4909" value="+15188814909" target="_blank">518-881-4909</a></div></div>
<br><div class="gmail_quote"><div><div class="h5">On Wed, Sep 9, 2015 at 9:08 AM, Berk Geveci <span dir="ltr"><<a href="mailto:berk.geveci@kitware.com" target="_blank">berk.geveci@kitware.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5"><div dir="ltr">Hi folks,<div><br></div><div><div style="font-size:12.8000001907349px">What would you think of changing VTK's indentation style from:</div><div style="font-size:12.8000001907349px"><br></div><div style="font-size:12.8000001907349px"><div style="font-size:12.8000001907349px">if ()</div><div style="font-size:12.8000001907349px"> {</div><div style="font-size:12.8000001907349px"> // ..</div><div style="font-size:12.8000001907349px"> }</div><div style="font-size:12.8000001907349px"><br></div><div style="font-size:12.8000001907349px">to</div><div style="font-size:12.8000001907349px"><br></div><div style="font-size:12.8000001907349px">if ()</div><div style="font-size:12.8000001907349px">{</div><div style="font-size:12.8000001907349px"> // ...</div><div style="font-size:12.8000001907349px">}</div><div style="font-size:12.8000001907349px"><br></div><div style="font-size:12.8000001907349px">?</div><div style="font-size:12.8000001907349px"><br></div><div style="font-size:12.8000001907349px">Our current style (modified Whitesmiths I am told) is used only by very few projects,</div><div style="font-size:12.8000001907349px">mostly related to VTK ones (ITK, CMake). It is poorly supported by some of the newer editors</div><div style="font-size:12.8000001907349px">that are widely popular (Sublime, TextMate etc.) and IMO foreign to the new generation</div><div style="font-size:12.8000001907349px">C++ developers.</div><div style="font-size:12.8000001907349px"><br></div><div style="font-size:12.8000001907349px">The style I propose is modified Allman style - with indentation changed from 4 to 2 spaces.</div><div style="font-size:12.8000001907349px">It is much more common.</div><div style="font-size:12.8000001907349px"><br></div><div style="font-size:12.8000001907349px">If approved by the community, we would change VTK wholesale. This should not be</div><div style="font-size:12.8000001907349px">an issue for history as git blame/annotate can be told to skip white spaces.</div><div style="font-size:12.8000001907349px"><br></div><div style="font-size:12.8000001907349px">Best,</div><div style="font-size:12.8000001907349px">-berk</div></div></div></div>
<br></div></div>_______________________________________________<br>
Powered by <a href="http://www.kitware.com" rel="noreferrer" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Search the list archives at: <a href="http://markmail.org/search/?q=vtk-developers" rel="noreferrer" target="_blank">http://markmail.org/search/?q=vtk-developers</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://public.kitware.com/mailman/listinfo/vtk-developers" rel="noreferrer" target="_blank">http://public.kitware.com/mailman/listinfo/vtk-developers</a><br>
<br>
<br></blockquote></div><br></div>
<br>_______________________________________________<br>
Powered by <a href="http://www.kitware.com" rel="noreferrer" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Search the list archives at: <a href="http://markmail.org/search/?q=vtk-developers" rel="noreferrer" target="_blank">http://markmail.org/search/?q=vtk-developers</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://public.kitware.com/mailman/listinfo/vtk-developers" rel="noreferrer" target="_blank">http://public.kitware.com/mailman/listinfo/vtk-developers</a><br>
<br>
<br></blockquote></div><br></div>