<div dir="ltr">David,<div> That would be really good if you do a cherry pick. I don't mind at all. While I was doing was thinking that it would be nice to have everything in the one place!</div><div><br></div><div>Wrt the Tk stuff it seems to be an import error: ImportError: No module named 'vtkLoadPythonTkWidgets'</div><div><br></div><div>Regards</div><div> Andrew</div><div><br></div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Aug 11, 2015 at 11:40 PM, David Gobbi <span dir="ltr"><<a href="mailto:david.gobbi@gmail.com" target="_blank">david.gobbi@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Andrew,<div><br></div><div>I've looked at TestTemplates.py, and it is going to require that I give it some special attention in order for it to provide the same coverage under Python 3 as it provides with Python 2.</div><div><br></div><div>For proper coverage, that test needs a string that cannot be expressed in ASCII, so I'll just build such a string at the top of the program:</div><div><br></div><div><div> # create a unicode string for python 2 and python 3</div><div> if sys.hexversion >= 0x03000000:</div><div> francois = 'Fran\xe7ois'</div><div> else:</div><div> francois = unicode('Fran\xe7ois', 'latin1')</div></div><div><br></div><div>On Python 3.2, only TestTemplates and the Tk tests failed. I'll fix the former and take a look at the latter.</div><div><br></div><div>Also, if you don't mind, I'd like to cherry-pick your commit onto my python-py3k branch and submit as a new merge request. That will allow us to keep all the Python 3 commits as a contiguous set.</div><span class="HOEnZb"><font color="#888888"><div><br></div><div> - David</div></font></span><div><div class="h5"><div> </div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Aug 11, 2015 at 6:19 AM, Andrew Maclean <span dir="ltr"><<a href="mailto:andrew.amaclean@gmail.com" target="_blank">andrew.amaclean@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi All,<div> Git and I had an argument about rebasing ... I lost the argument. [git +1, Andrew -1] </div><div><br></div><div>Consequently I have had to create a new merge request:</div><div><a href="https://gitlab.kitware.com/vtk/vtk/merge_requests/518" target="_blank">https://gitlab.kitware.com/vtk/vtk/merge_requests/518</a><br></div><div><br></div><div>I have picked up all of David's comments from the old merge request and the results (on my machine) are:</div><div><div>99% tests passed, 4 tests failed out of 489</div><div><br></div><div>Total Test time (real) = 990.25 sec</div><div><br></div><div>The following tests FAILED:</div><span><div> 1935 - vtkRenderingTkPython-cursor3D (Failed)</div><div> 1936 - vtkRenderingTkPython-TestTextActor3D (Failed)</div></span><div> 1937 - vtkRenderingTkPython-TestTkRenderWidget (Failed)</div><div> 1938 - vtkRenderingTkPython-TestTkRenderWindowInteractor (Failed)</div><div>Errors while running CTest</div></div><div><br></div><div>If no one objects, would like to defer these fails to a later merge request.</div><div><br></div><div>David, I have a question about Python 3.2:</div><div>In reading the documentation, this version of python accepted strings like unicode('The Zen of VTK') but not u'The Zen of VTK' which is accepted in Python 2.7/3.3+.</div><div><br></div><div>Is it safe to use:</div><div>from __future__ import unicode_literals<br></div><div><br></div><div>and will Python 3.2 then accept statements like:</div><div>zen = u'The Zen of VTK'</div><div><br></div><div>Can someone test this on Python 3.2, it works on Python 3.4 and Python 2.7.</div><div><br></div><div>If it doesn't work, are there any alternatives?</div><div><br></div><div><br></div><div>Regards</div><span><font color="#888888"><div> Andrew</div><div><br></div><div><br></div><div><br></div><div><br></div><div><br></div></font></span></div><div class="gmail_extra"><div><div><br><div class="gmail_quote">On Tue, Aug 11, 2015 at 5:53 AM, David Gobbi <span dir="ltr"><<a href="mailto:david.gobbi@gmail.com" target="_blank">david.gobbi@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span>On Mon, Aug 10, 2015 at 3:00 AM, Andrew Maclean <span dir="ltr"><<a href="mailto:andrew.amaclean@gmail.com" target="_blank">andrew.amaclean@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div><div><div> 655 - vtkFiltersGeneralPython-TestMultiBlockStreamer (Failed)</div><div> 676 - vtkFiltersGeneralPython-splitVectors (Failed)</div><div> 677 - vtkFiltersGeneralPython-streamTracer (Failed)</div><div> 1263 - vtkIONetCDFPython-NetCDFCF2DBounds (Failed)</div><div> 1264 - vtkIONetCDFPython-NetCDFCFSetOutputType (Failed)</div><div> 1265 - vtkIONetCDFPython-NetCDFCFSphericalCoords (Failed)</div><div> 1266 - vtkIONetCDFPython-NetCDFCFUnstructured (Failed)</div><div> 1267 - vtkIONetCDFPython-NetCDFReader (Failed)</div></div></div></div></blockquote><div><br></div></span><div>For the above tests, it looks like the failure was due to a typo in my wrapper code.</div><div>I mistyped PY_VERSION_HEX in two locations. After I've merged this fix, you can</div><div>rebase.</div><span><font color="#888888"><div><br></div><div> - David</div><div> </div></font></span></div></div></div>
</blockquote></div><br><br clear="all"><div><br></div></div></div><span>-- <br><div>___________________________________________<br>Andrew J. P. Maclean<br><br>___________________________________________</div>
</span></div>
</blockquote></div><br></div></div></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">___________________________________________<br>Andrew J. P. Maclean<br><br>___________________________________________</div>
</div>