<div dir="ltr">So far so good,(2to3 has been very helpful).<div>---------------------------------------------------------------<br><div><div>98% tests passed, 12 tests failed out of 489</div><div><br></div><div>Total Test time (real) = 1046.22 sec</div><div><br></div><div>The following tests FAILED:</div><div> 655 - vtkFiltersGeneralPython-TestMultiBlockStreamer (Failed)</div><div> 676 - vtkFiltersGeneralPython-splitVectors (Failed)</div><div> 677 - vtkFiltersGeneralPython-streamTracer (Failed)</div><div> 1263 - vtkIONetCDFPython-NetCDFCF2DBounds (Failed)</div><div> 1264 - vtkIONetCDFPython-NetCDFCFSetOutputType (Failed)</div><div> 1265 - vtkIONetCDFPython-NetCDFCFSphericalCoords (Failed)</div><div> 1266 - vtkIONetCDFPython-NetCDFCFUnstructured (Failed)</div><div> 1267 - vtkIONetCDFPython-NetCDFReader (Failed)</div><div> 1935 - vtkRenderingTkPython-cursor3D (Failed)</div><div> 1936 - vtkRenderingTkPython-TestTextActor3D (Failed)</div><div> 1937 - vtkRenderingTkPythvtkIONetCDFPythonon-TestTkRenderWidget (Failed)</div><div> 1938 - vtkRenderingTkPython-TestTkRenderWindowInteractor (Failed)</div><div><br></div><div>See: <a href="https://gitlab.kitware.com/vtk/vtk/merge_requests/514#note_26500">https://gitlab.kitware.com/vtk/vtk/merge_requests/514#note_26500</a> currently marked as WIP.</div><div>---------------------------------------------------------------<br><div></div></div><div><br></div><div>David, one interesting thing that I am seeing is that the above vtkFiltersGeneralPython and vtkIONetCDFPython tests that fail actually pass in Python 2 but the image generated is different in Python 3. Could there some slight difference in the wrapping e.g the treatment of floats or ints?</div><div><br></div><div>I may be able to get the vtkIONetCDFPython working. I suspect cursor3D.py may now be Ok.</div><div><br></div><div>Once I fix errors in vtkRenderingTkPython I will remove the WIP: appellation.</div><div><br></div><div><br></div><div>Regards</div><div> Andrew</div><div><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Aug 9, 2015 at 11:50 AM, Andrew Maclean <span dir="ltr"><<a href="mailto:andrew.amaclean@gmail.com" target="_blank">andrew.amaclean@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Thanks for that.<div>I rebased against the master and picked up those changes.</div><span class="HOEnZb"><font color="#888888"><div><br></div><div>Andrew</div></font></span></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Aug 8, 2015 at 10:48 PM, David Gobbi <span dir="ltr"><<a href="mailto:david.gobbi@gmail.com" target="_blank">david.gobbi@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">Wow, I didn't expect so many of the tests to be passing so soon. Thanks for looking into these so quickly!</div><div class="gmail_quote"><br></div><div class="gmail_quote">I just merged some fixes to my own 2 to 3 changes for Common/Core/Testing/Python and Wrapping/Python/vtk. These are mainly fixes to "print" calls that I'd been lazy with the first time.</div><div class="gmail_quote"><br></div><div class="gmail_quote">So please rebase either onto the current master or onto this commit:</div><div class="gmail_quote"><a href="https://gitlab.kitware.com/dgobbi/vtk/commit/26ad0555" target="_blank">https://gitlab.kitware.com/dgobbi/vtk/commit/26ad0555</a><br></div><div class="gmail_quote"><br></div><div class="gmail_quote">Cheers,</div><div class="gmail_quote"><br></div><div class="gmail_quote"> - David</div><div><div><div class="gmail_quote"><br></div><div class="gmail_quote">On Fri, Aug 7, 2015 at 10:51 PM, Andrew Maclean <span dir="ltr"><<a href="mailto:andrew.amaclean@gmail.com" target="_blank">andrew.amaclean@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div>David you have done a fantastic job!</div></div><div><br></div><div><br></div>Just letting you know that by making python 3 changes to rtImageTest.py, info.py, catch.py and expr.py, <div><br></div><div>I am now getting 89% tests passed, 54 tests failed out of 481!<br></div><div><br></div><div>In rtImageTest.py, Tkinter is now tkinter in Python 3.</div><div>For handling renamed libraries is code like this acceptable (it works in Python 2 and 3):<div>##################<br><div><div><div>try:</div><div> # for Python2</div><div> print('Trying Python2')</div><div> import Tkinter as tk</div><div> print('Python2 Ok')</div><div>except ImportError:</div><div> # for Python3</div><div> print('Trying Python3')</div><div> import tkinter as tk</div><div> print('Python3 Ok')</div><div>pythonTk = tk.Tk()</div></div><div>##################<div><div><br></div><div>The remaining failing tests are mainly related to the print statement, failures relating to string.find [in vtkMethodParser.py], no module named exceptions etc.<br><div><br></div><div>I need to do some thorough testing on rtImageTest.py, info.py, catch.py, expr.py, vtkMethodParser.py for both Python 2.7 and Python 3.4</div><div><br></div><div>I am so impressed that these few changes have worked.</div><div><br></div><div>I'll try and get all the tests passing for Python 2 and Python 3 in the next week or so and create a merge request for review.</div><div><br></div><div>Regards</div><span><font color="#888888"><div> Andrew</div><div><br clear="all"><div><br></div>-- <br><div>___________________________________________<br>Andrew J. P. Maclean<br><br>___________________________________________</div>
</div></font></span></div></div></div></div></div></div></div>
</blockquote></div><br></div></div></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div>___________________________________________<br>Andrew J. P. Maclean<br><br>___________________________________________</div>
</div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">___________________________________________<br>Andrew J. P. Maclean<br><br>___________________________________________</div>
</div></div></div></div>