<div dir="ltr">Indeed, sorry David, I should have blame, I mean greet your for this fix! :)<br><br><br></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature"><div dir="ltr"><b>Joachim Pouderoux</b><br><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><font size="1"><i>PhD, Technical Expert</i></font><br><b><font size="1"><a href="http://www.kitware.fr" target="_blank">Kitware SAS</a></font></b><br></blockquote>
</div></div></div>
<br><div class="gmail_quote">2015-07-02 17:07 GMT+02:00 David Cole <span dir="ltr"><<a href="mailto:DLRdave@aol.com" target="_blank">DLRdave@aol.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">You may notice from git blame, those comments were added only<br>
recently, in October 2014 in commit e136e01e...<br>
<br>
I didn't even know when I did that commit that there was a python<br>
equivalent to vtkTesting.cxx. I wonder why vtkTesting.cxx isn't simply<br>
wrapped and used directly from python...?<br>
<br>
<br>
David C.<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
<br>
On Thu, Jul 2, 2015 at 10:45 AM, Joachim Pouderoux<br>
<<a href="mailto:joachim.pouderoux@kitware.com">joachim.pouderoux@kitware.com</a>> wrote:<br>
> David,<br>
><br>
> We discovered that interesting comment in vtkTesting.cxx (line 775):<br>
><br>
> // Typically, the image testing is done using the back buffer<br>
> // to avoid accidentally capturing overlapping window artifacts<br>
> // in the image when using the front buffer. However, some graphics<br>
> // drivers do not have up to date contents in the back buffer,<br>
> // causing "failed" tests even though, upon visual inspection, the<br>
> // front buffer looks perfectly valid... So:<br>
> //<br>
> // If the test failed using the back buffer, re-test using the<br>
> // front buffer. This way, more tests pass on dashboards run with<br>
> // the Intel HD built-in graphics drivers.<br>
><br>
> We gonna change Testing.py to do the same - question: why this has never<br>
> been done? :)<br>
><br>
> J.<br>
><br>
> Joachim Pouderoux<br>
><br>
> PhD, Technical Expert<br>
> Kitware SAS<br>
><br>
><br>
> 2015-07-02 15:37 GMT+02:00 David Thompson <<a href="mailto:david.thompson@kitware.com">david.thompson@kitware.com</a>>:<br>
>><br>
>> Hi Mathieu,<br>
>><br>
>> Thanks for looking into this. I've been noticing failures like that in VTK<br>
>> and in some projects that use it. However, given the number of image tests<br>
>> that VTK runs, adding 2s of delay to each one would slow the dashboards down<br>
>> too much to be usable. However, it is a great start on figuring out how to<br>
>> fix the issue. I don't see anywhere that<br>
>> vtkRenderWindow::WaitForCompletion() (which calls glFinish) gets called when<br>
>> grabbing the framebuffer. Perhaps adding this would be faster than a timer.<br>
>> Can you verify that it works? If so, maybe we can figure out where to add it<br>
>> to avoid slowing production code down for testing.<br>
>><br>
>> Thanks,<br>
>> David<br>
>><br>
>> > I have some problem with tests wich render and compare to an image.<br>
>> ><br>
>> > Lots of test do the rendering which can be seen on screen, but the<br>
>> > generated image is completelly black ( or white ) and the test fail.<br>
>> ><br>
>> > Most of these failing tests are python test but not only.<br>
>> > The list of failing tests is attached.<br>
>> ><br>
>> > I've tried to understood what was going on, so i've tried to fix<br>
>> > sync3dAll.py<br>
>> ><br>
>> > Adding :<br>
>> > import time<br>
>> > time.sleep(1)<br>
>> > renWin.Render()<br>
>> > time.sleep(1)<br>
>> ><br>
>> > after the first render() did the trick. It look like the renderring is<br>
>> > not done fast enough ans the produced image is empty as it has not yet been<br>
>> > rendered.<br>
>> ><br>
>> > Any help appreciated.<br>
>> ><br>
>> > Mathieu Westphal<br>
>> > <tests>_______________________________________________<br>
>> > Powered by <a href="http://www.kitware.com" rel="noreferrer" target="_blank">www.kitware.com</a><br>
>> ><br>
>> > Visit other Kitware open-source projects at<br>
>> > <a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
>> ><br>
>> > Search the list archives at:<br>
>> > <a href="http://markmail.org/search/?q=vtk-developers" rel="noreferrer" target="_blank">http://markmail.org/search/?q=vtk-developers</a><br>
>> ><br>
>> > Follow this link to subscribe/unsubscribe:<br>
>> > <a href="http://public.kitware.com/mailman/listinfo/vtk-developers" rel="noreferrer" target="_blank">http://public.kitware.com/mailman/listinfo/vtk-developers</a><br>
>> ><br>
>><br>
>> _______________________________________________<br>
>> Powered by <a href="http://www.kitware.com" rel="noreferrer" target="_blank">www.kitware.com</a><br>
>><br>
>> Visit other Kitware open-source projects at<br>
>> <a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
>><br>
>> Search the list archives at: <a href="http://markmail.org/search/?q=vtk-developers" rel="noreferrer" target="_blank">http://markmail.org/search/?q=vtk-developers</a><br>
>><br>
>> Follow this link to subscribe/unsubscribe:<br>
>> <a href="http://public.kitware.com/mailman/listinfo/vtk-developers" rel="noreferrer" target="_blank">http://public.kitware.com/mailman/listinfo/vtk-developers</a><br>
>><br>
><br>
><br>
> _______________________________________________<br>
> Powered by <a href="http://www.kitware.com" rel="noreferrer" target="_blank">www.kitware.com</a><br>
><br>
> Visit other Kitware open-source projects at<br>
> <a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
><br>
> Search the list archives at: <a href="http://markmail.org/search/?q=vtk-developers" rel="noreferrer" target="_blank">http://markmail.org/search/?q=vtk-developers</a><br>
><br>
> Follow this link to subscribe/unsubscribe:<br>
> <a href="http://public.kitware.com/mailman/listinfo/vtk-developers" rel="noreferrer" target="_blank">http://public.kitware.com/mailman/listinfo/vtk-developers</a><br>
><br>
><br>
</div></div></blockquote></div><br></div>