<div dir="ltr">I would say to Dave Cole's point that I have personally seen several problems in the very modest development efforts I have been doing on Windows (e.g., vtkSMPTools related) mostly in the CMake files, etc. Every compiler/platform has something good to say and we need to listen. This ensures that our software remains world class, despite our personal religious beliefs :-) Actually I actually think more of us need to build on Windows/MSVC because stuff is falling through the cracks.<div><div><br></div><div>W</div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Apr 29, 2015 at 2:12 PM, David Lonie <span dir="ltr"><<a href="mailto:david.lonie@kitware.com" target="_blank">david.lonie@kitware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class="">On Wed, Apr 29, 2015 at 1:50 PM, David Cole <span dir="ltr"><<a href="mailto:DLRdave@aol.com" target="_blank">DLRdave@aol.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The commit message here:<br>
<br><a href="https://gitlab.kitware.com/vtk/vtk/commit/7247da0ecf23c2c52e90acc86dda2e2bbf33461a" target="_blank">https://gitlab.kitware.com/vtk/vtk/commit/7247da0ecf23c2c52e90acc86dda2e2bbf33461a</a><br>
<br>
claims there was some sort of problem with make_pair and double. What<br>
exactly was the problem? With what exact version of MSVC? (I don't buy<br>
that there's a general problem with make_pair and double...)<br>
<br>
And then the follow on commit message:<br>
<br><a href="https://gitlab.kitware.com/vtk/vtk/commit/e3d0653de443435533ebfb2db3fa6513e3b5c86b" target="_blank">https://gitlab.kitware.com/vtk/vtk/commit/e3d0653de443435533ebfb2db3fa6513e3b5c86b</a><br>
<br>
seems a bit accusatory towards poor old closed-source MSVC.</blockquote><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
This code compiles just fine for me with Visual Studio 2013:<br>
<br>
bool TestMakePair()<br>
{<br>
const double value = 0.0;<br>
vtkTextProperty *prop = NULL;<br>
<br>
std::pair<double, vtkTextProperty*> pairOne =<br>
std::make_pair(value, prop);<br>
<br>
return true;<br>
}<br></blockquote><div><br></div></span><div>Now try std::make_pair<double, vtkTextProperty*>(value, NULL).</div><span class=""><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Of course, make_pair deduces its types from the supplied arguments, so<br>
passing "NULL" as the second arg is not exactly well defined across<br>
all OSes and compilers. Not sure why you would expect that.<br></blockquote><div><br></div></span><div>Telling it the first argument is explicitly a double and the second is a pointer, and then having it complain about the double with one syntax and the pointer in the other (both while being explicitly declared in the template arguements) is a tad ridiculous, IMO.</div><span class=""><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Anyhow.... This email is simply a request to remove the disparaging<br>
remarks about "Windows" and MSVC from the comments, and to be kinder<br>
and gentler in future commit messages. Writing thoughtful explanatory<br>
commit messages is nearly as important as writing the code for a<br>
widely used public open source project.<br></blockquote><div><br></div></span><div>Not sure they can be removed. I don't think this warrants rewriting the commit history.</div><span class=""><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Nobody likes dealing with "the other platforms" that they don't work<br>
on daily, but we all love how VTK works awesomely on so many<br>
platforms. It's worth the extra effort to get code just right so it<br>
compiles cleanly everywhere, and </blockquote><div><br></div></span><div>I don't mind, actually, But if something ridiculous happens, I'm going to find it ridiculous. Besides, "putting in the extra effort to get code right" is exactly what those commits are doing...?</div><span class=""><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">commentary like this just turns me<br>
off.<br></blockquote><div><br></div></span><div>Sorry to turn you off, Dave. I meant no offense, but apologize for any that was taken. Writing code that works on every platform but one, and then fails in two distinct ways on different version of the primary compiler for that platform is surely frustrating, no? If GCC was behaving similarly, I'd have similar frustrations.</div><div><br></div><div>I'm not trying to play favorites and disparage anyone's favorite platform. There are annoyances with every compiler (admittedly, some more than others!), and I view my commit messages as harmless venting. I still don't see them as expressing anything offensive, just frustration at a couple of idiosyncrasies. Less than absolutely professional? Sure. Restrained expression of legitimate frustration? I'd say "sure" to that as well. Offensive? Well, that's a bit of a stretch IMO. Different strokes.</div><div><br></div><div>Regardless, I'll make an effort to adopt a more neutral tone in my commit messages.</div><div><br></div><div>Have a great day,</div><div>Dave</div></div></div></div>
<br>_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Search the list archives at: <a href="http://markmail.org/search/?q=vtk-developers" target="_blank">http://markmail.org/search/?q=vtk-developers</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://public.kitware.com/mailman/listinfo/vtk-developers" target="_blank">http://public.kitware.com/mailman/listinfo/vtk-developers</a><br>
<br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">William J. Schroeder, PhD<br>Kitware, Inc.<br>28 Corporate Drive<br>Clifton Park, NY 12065<br><a href="mailto:will.schroeder@kitware.com" target="_blank">will.schroeder@kitware.com</a><br><a href="http://www.kitware.com" target="_blank">http://www.kitware.com</a><br>(518) 881-4902</div>
</div>