<div dir="ltr">I disagree. Gerrit does not support any of the "nice to have"s in a straightforward way. Neither does vanilla Gerrit properly support "b<span style="font-family:arial,sans-serif;font-size:13px">ranch / topic based workflow" in a straightforward way. It supports a changeset based workflow and "branch / topic" based workflows have to be shoehorned into it if a "branch / topic" has more than 1 changeset. Also to support automated testing of branch tips, we would have to create custom scaffolding since vanilla Gerrit has no such concept.</span><div>
<span style="font-family:arial,sans-serif;font-size:13px"><br></span></div><div><span style="font-family:arial,sans-serif;font-size:13px">Gerrit, with a little help from cdash @ home does a decent job of the following:</span><div>
<span style="font-family:arial,sans-serif;font-size:13px"><br></span></div><div><div class="gmail_extra" style="font-family:arial,sans-serif;font-size:13px">- Automated testing before merge (required to pass)</div><div class="gmail_extra" style="font-family:arial,sans-serif;font-size:13px">
- Assign reviewers to topic</div><div class="gmail_extra" style="font-family:arial,sans-serif;font-size:13px">- Review / approval before merge (required to pass)</div><div class="gmail_extra" style="font-family:arial,sans-serif;font-size:13px">
- Ability to go back to discussion leading to merge (audit trail)</div><div class="gmail_extra" style="font-family:arial,sans-serif;font-size:13px">- Automatic notification on change</div><div class="gmail_extra" style="font-family:arial,sans-serif;font-size:13px">
- Ability to comment on the code (Web GUI preferred)</div><div><br></div><div>It clearly doesn't do any of this:</div><div><br></div><div><div class="gmail_extra" style="font-family:arial,sans-serif;font-size:13px">- Tight integration with issue (bug) tracking and release process</div>
</div><div><span style="font-family:arial,sans-serif;font-size:13px">- Integration with Wiki</span><br></div><div><div class="gmail_extra" style="font-family:arial,sans-serif;font-size:13px">- Easy documentation / Markdown /rST support</div>
<div class="gmail_extra" style="font-family:arial,sans-serif;font-size:13px">- Easy way to generate single view of all changes in the Web GUI</div><div class="gmail_extra" style="font-family:arial,sans-serif;font-size:13px">
<br></div><div class="gmail_extra" style="font-family:arial,sans-serif;font-size:13px">In my opinion, it does a very poor job of these:</div><div class="gmail_extra" style="font-family:arial,sans-serif;font-size:13px"><br>
</div><div class="gmail_extra"><div class="gmail_extra" style="font-family:arial,sans-serif;font-size:13px">- Branch / topic based workflow</div><div style="font-family:arial,sans-serif;font-size:13px"><div class="gmail_extra">
- Ease of use</div></div><div style="font-family:arial,sans-serif;font-size:13px"><br></div><div style="font-family:arial,sans-serif;font-size:13px">The other requirements and nice-to-haves are independent of tools and can be achieved using whatever tool. However, Mantis is also not the easiest tool so replacing it is also a good idea.</div>
<div style="font-family:arial,sans-serif;font-size:13px"><br></div><div style="font-family:arial,sans-serif;font-size:13px">In my opinion, the biggest weaknesses of Github and Gitlab are:</div><div style="font-family:arial,sans-serif;font-size:13px">
<br></div><div style="font-family:arial,sans-serif;font-size:13px"><div class="gmail_extra">- Assign reviewers to topic</div></div><div style="font-family:arial,sans-serif;font-size:13px"><div class="gmail_extra">- Review / approval before merge (required to pass)</div>
<div class="gmail_extra">- Ability to go back to discussion leading to merge (audit trail)</div></div><div style="font-family:arial,sans-serif;font-size:13px"><br></div><div style="font-family:arial,sans-serif;font-size:13px">
They don't have a clear voting system and are based on more a general discussion workflow. We would have to create some guidelines on how to achieve these in those tools. For example, someone doing a pull request would have to add a comment mentioning potential reviewers with the @name syntax to "assign reviewers". The reviewers would have to use some previously agreed upon language to approve a topic in the discussion. Something like "Approved for merge".</div>
<div style="font-family:arial,sans-serif;font-size:13px"><br></div><div style="font-family:arial,sans-serif;font-size:13px">Github is far superior to Gerrit in these:</div><div style="font-family:arial,sans-serif;font-size:13px">
<br></div><div style="font-family:arial,sans-serif;font-size:13px"><div class="gmail_extra">- Branch / topic based workflow</div><div class="gmail_extra">- Automated testing before merge (required to pass) - tight integration with Travis and demonstrated integration with cdash @ home through custom hooks</div>
</div><div class="gmail_extra"><div class="gmail_extra" style="font-family:arial,sans-serif;font-size:13px">- Automatic notification on change - much finer notification control</div><div class="gmail_extra" style="font-family:arial,sans-serif;font-size:13px">
- Ability to comment on the code (Web GUI preferred) - go check it out if you don't believe me</div><div><div class="gmail_extra" style="font-family:arial,sans-serif;font-size:13px">- Tight integration with issue (bug) tracking and release process</div>
<div class="gmail_extra" style="font-family:arial,sans-serif;font-size:13px">- Ease of use<br></div><div class="gmail_extra" style="font-family:arial,sans-serif;font-size:13px">- Integration with Wiki<br></div><div class="gmail_extra" style="font-family:arial,sans-serif;font-size:13px">
- Easy documentation / Markdown /rST support</div><div class="gmail_extra" style="font-family:arial,sans-serif;font-size:13px">- Easy way to generate single view of all changes in the Web GUI - this is impossible in Gerrit even for a single changeset</div>
<div class="im"><div class="gmail_extra"><br></div><div class="gmail_extra"><font color="#000000">Best,</font></div><div class="gmail_extra"><font color="#000000">-berk</font></div><div class="gmail_extra"><br></div></div>
</div></div><div style="font-family:arial,sans-serif;font-size:13px"><br></div></div><div class="im" style="font-family:arial,sans-serif;font-size:13px"></div></div><div><br></div><div class="im" style="font-family:arial,sans-serif;font-size:13px">
</div></div></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Aug 26, 2014 at 3:43 PM, Bill Lorensen <span dir="ltr"><<a href="mailto:bill.lorensen@gmail.com" target="_blank">bill.lorensen@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">+1 and Gerrit seems to support them all.<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
On Tue, Aug 26, 2014 at 3:32 PM, Berk Geveci <<a href="mailto:berk.geveci@kitware.com">berk.geveci@kitware.com</a>> wrote:<br>
> Here is a summary that I came up with from the discussion so far. Does this<br>
> look good?<br>
><br>
> Requirements:<br>
><br>
> - Branch / topic based workflow<br>
> - Automated testing before merge (required to pass)<br>
> - Assign reviewers to topic<br>
> - Review / approval before merge (required to pass)<br>
> - Ability to go back to discussion leading to merge (audit trail)<br>
> - Automatic notification on change<br>
> - Ability to comment on the code (Web GUI preferred)<br>
> - All reported bugs should be assessed and assigned<br>
><br>
> Nice to have:<br>
><br>
> - Tight integration with issue (bug) tracking and release process<br>
> - Stakeholders for particular pieces identified / in the loop / easy or<br>
> automatic assignment of<br>
> reviewers<br>
> - Ease of use<br>
> - Incentive for reviewers (goal being encouraging more reviews)<br>
> - Integration with Wiki<br>
> - Easy documentation / Markdown /rST support<br>
> - Easy way to generate single view of all changes in the Web GUI<br>
> - Lightweight proposal process for large changes<br>
> - Way to track performance regression<br>
><br>
<br>
<br>
<br>
</div></div><div class="HOEnZb"><div class="h5">--<br>
Unpaid intern in BillsBasement at noware dot com<br>
</div></div></blockquote></div><br></div>