<div dir="ltr">My vote would be to do what Ken mentioned. I'm in favor of having the semicolon required at the end of the macro statement but this will cause compilation problems though for other projects that use the vtkTypeMacro and did it the "proper" way before.<br>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, May 6, 2014 at 3:08 PM, Ben Boeckel <span dir="ltr"><<a href="mailto:ben.boeckel@kitware.com" target="_blank">ben.boeckel@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="">On Tue, May 06, 2014 at 14:38:26 -0400, Utkarsh Ayachit wrote:<br>
> > Do we want<br>
> > vtkStandardNewMacro(vtkChartLegend);<br>
> > or<br>
> > vtkStandardNewMacro(vtkChartLegend)<br>
> > To me, the latter makes more sense...<br>
<br>
</div>I prefer the former in general (so the macro looks like a regular call;<br>
but I also use all-upper for my macros when they're public so that<br>
there's some indication funky things are going on), but for<br>
block-generating code, leaving it out is sensible since blocks don't<br>
always end with semicolons.<br>
<div class=""><br>
> I have always heard people prefer the latter, not entirely sure I know<br>
> why. The only problem I have with the latter is that it messes up with<br>
> my VIM indentation :). Does anyone know how to overcome that? I doubt<br>
> VIM can ever know that it's a macro and hence the missing ";" is not<br>
> really missing.<br>
<br>
</div>If you're willing to live with constantly updating ctags and having them<br>
loaded all the time (I've found it's usually quite a problem for large<br>
projects :( ), it can know it's a macro. Personally, I have backspace<br>
dedent for me when Vim gets it wrong (which is often enough since the<br>
CMake indentation rules in Vim are far from ideal).<br>
<span class="HOEnZb"><font color="#888888"><br>
--Ben<br>
</font></span><div class="HOEnZb"><div class="h5">_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
<br>
</div></div></blockquote></div><br></div>