<div dir="ltr"><div>Gerrit didn't know that the old topic should be merged onto the release-5.10 branch, and it complained when I tried to do it within gerrit.</div><div style><br></div><div style>So I cherry picked the old topic (<a href="http://review.source.kitware.com/#/t/2360/">http://review.source.kitware.com/#/t/2360/</a>) onto a new topic (<a href="http://review.source.kitware.com/#/t/3623/">http://review.source.kitware.com/#/t/3623/</a>) and then merged that one though gerrit instead.</div>
<div style><br></div><div style>In hindsight that was a mistake on my part. Sorry. If you like (because other work depends on those original commits for example), I'll see about rewriting the last few minutes of history.</div>
<div style><br></div><div style><br></div><div style><br></div></div><div class="gmail_extra"><br clear="all"><div>David E DeMarle<br>Kitware, Inc.<br>R&D Engineer<br>21 Corporate Drive<br>Clifton Park, NY 12065-8662<br>
Phone: 518-881-4909</div>
<br><br><div class="gmail_quote">On Tue, Nov 19, 2013 at 11:15 AM, David Gobbi <span dir="ltr"><<a href="mailto:david.gobbi@gmail.com" target="_blank">david.gobbi@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I don't understand what you mean by "wanted to be sure"... parentage<br>
in git is explicit and is laid down in stone.<br>
<br>
The reason that I am concerned is that it was a lot of work to make<br>
sure that the old release-tcl86_update branch could be merged cleanly<br>
into both release (which was VTK 5.10.1 at the time, this was in March<br>
2013) and master (which had been modularized).<br>
<br>
Now, it seems that my efforts from last March were for nothing,<br>
because you have re-backported a patch that was already clearly based<br>
off of the exactly the tip of the current release-5.10 branch.<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
On Tue, Nov 19, 2013 at 11:02 AM, David E DeMarle<br>
<<a href="mailto:dave.demarle@kitware.com">dave.demarle@kitware.com</a>> wrote:<br>
> You are right I probably could have just merged it directly.<br>
><br>
> Since the gerrit topic was started before there was a release-5.10 branch, I<br>
> did it this way because I wanted to be sure that gerrit and origin pointed<br>
> to the same thing.<br>
><br>
> David E DeMarle<br>
> Kitware, Inc.<br>
> R&D Engineer<br>
> 21 Corporate Drive<br>
> Clifton Park, NY 12065-8662<br>
> Phone: <a href="tel:518-881-4909" value="+15188814909">518-881-4909</a><br>
><br>
><br>
> On Tue, Nov 19, 2013 at 10:29 AM, David Gobbi <<a href="mailto:david.gobbi@gmail.com">david.gobbi@gmail.com</a>> wrote:<br>
>><br>
>> I'm confused... why is there a new patch on gerrit for the Tcl 8.6<br>
>> patches?<br>
>><br>
>> The existing Tcl 8.6 patch (see link below) is already based on VTK<br>
>> 5.10.1. It just has to be merged into the VTK 5.10 release branch:<br>
>> <a href="http://review.source.kitware.com/#/t/2360/" target="_blank">http://review.source.kitware.com/#/t/2360/</a><br>
>><br>
>> There must be something that I'm not understanding here...<br>
>><br>
>> David<br>
><br>
><br>
</div></div></blockquote></div><br></div>