<div dir="ltr">Makes sense. I'll add the wrap exclusion ifdef until your changes go in. Thanks.<div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Oct 9, 2013 at 1:48 PM, David Gobbi <span dir="ltr"><<a href="mailto:david.gobbi@gmail.com" target="_blank">david.gobbi@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Berk,<br>
<br>
The wrappers parse all of the header files, even the WRAP_EXCLUDE ones.<br>
Wrapping consists of two parts: parsing the headers, and generating glue code.<br>
Marking something as "WRAP_EXCLUDE" only stops the wrappers from<br>
generating glue code, it doesn't stop the wrappers from parsing the code.<br>
<br>
To stop the wrappers from parsing the code, you have to mark off blocks<br>
of code with #ifndef __WRAP__.<br>
<span class="HOEnZb"><font color="#888888"><br>
David<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
On Wed, Oct 9, 2013 at 11:38 AM, Berk Geveci <<a href="mailto:berk.geveci@kitware.com">berk.geveci@kitware.com</a>> wrote:<br>
> Thanks for the fix. I'll still have to wrap exclude it because of Tcl and<br>
> Java. I thought that I did it already but it looks like I need to exclude<br>
> both the .h and the .cxx because of the way this is being done. I'll push a<br>
> fix shortly.<br>
><br>
> -berk<br>
><br>
><br>
> On Wed, Oct 9, 2013 at 12:24 PM, David Gobbi <<a href="mailto:david.gobbi@gmail.com">david.gobbi@gmail.com</a>> wrote:<br>
>><br>
>> These two lines in vtkAtomicInt.h are tripping up the wrapper-parser:<br>
>><br>
>> virtual ~vtkAtomicIntImpl<vtkTypeInt32>();<br>
>><br>
>> virtual ~vtkAtomicIntImpl<vtkTypeInt64>();<br>
>><br>
>> They can be blocked off by #ifdef __WRAP__ for now, while I<br>
>> investigate the underlying cause.<br>
>><br>
>> David<br>
>><br>
>><br>
>> On Wed, Oct 9, 2013 at 10:08 AM, David Gobbi <<a href="mailto:david.gobbi@gmail.com">david.gobbi@gmail.com</a>><br>
>> wrote:<br>
>> > The Java and Tcl continuous dashboard errors can be cleared by marking<br>
>> > vtkAtomicInt.h as "WRAP_EXCLUDE". As for the Win32-specific wrapping<br>
>> > error, I'm still looking into it.<br>
>> ><br>
>> > On Wed, Oct 9, 2013 at 9:57 AM, David Gobbi <<a href="mailto:david.gobbi@gmail.com">david.gobbi@gmail.com</a>><br>
>> > wrote:<br>
>> >> I see that the wrapper-parser is reporting a syntax error in<br>
>> >> vtkAtomicInt.h. I'm trying to find out why this is happening<br>
>> >> (especially why it only happens on Win32).<br>
>> >><br>
>> >> On Wed, Oct 9, 2013 at 8:17 AM, Berk Geveci <<a href="mailto:berk.geveci@kitware.com">berk.geveci@kitware.com</a>><br>
>> >> wrote:<br>
>> >>> Yup my bad. I am working on a fix. I can infer that your machine is 32<br>
>> >>> bit<br>
>> >>> btw :-)<br>
>> >>><br>
>> >>> -berk<br>
>> >>><br>
>> >>><br>
>> >>> On Tue, Oct 8, 2013 at 8:13 PM, Bill Lorensen<br>
>> >>> <<a href="mailto:bill.lorensen@gmail.com">bill.lorensen@gmail.com</a>><br>
>> >>> wrote:<br>
>> >>>><br>
>> >>>> It has been a few days since I updated VTK. Today I get these erros<br>
>> >>>> on<br>
>> >>>> my 32 bit linux build:<br>
>> >>>> Linking CXX executable ../../../../bin/vtkCommonCoreCxxTests<br>
>> >>>> CMakeFiles/vtkCommonCoreCxxTests.dir/TestAtomic.cxx.o: In function<br>
>> >>>> `MyFunction3(void*)':<br>
>> >>>><br>
>> >>>><br>
>> >>>> /home/lorensen/ProjectsGIT/VTKGerrit/Common/Core/Testing/Cxx/TestAtomic.cxx:57:<br>
>> >>>> undefined reference to `detail::vtkAtomicIntImpl<long<br>
>> >>>> long>::operator+=(long long)'<br>
>> >>>> CMakeFiles/vtkCommonCoreCxxTests.dir/TestAtomic.cxx.o: In function<br>
>> >>>> `MyFunction4(void*)':<br>
>> >>>><br>
>> >>>><br>
>> >>>> /home/lorensen/ProjectsGIT/VTKGerrit/Common/Core/Testing/Cxx/TestAtomic.cxx:74:<br>
>> >>>> undefined reference to `detail::vtkAtomicIntImpl<long<br>
>> >>>> long>::operator+=(long long)'<br>
>> >>>> CMakeFiles/vtkCommonCoreCxxTests.dir/TestAtomic.cxx.o: In function<br>
>> >>>> `TestAtomic(int, char**)':<br>
>> >>>><br>
>> >>>><br>
>> >>>> /home/lorensen/ProjectsGIT/VTKGerrit/Common/Core/Testing/Cxx/TestAtomic.cxx:147:<br>
>> >>>> undefined reference to `detail::vtkAtomicIntImpl<long long>::load()<br>
>> >>>> const'<br>
>> >>>><br>
>> >>>><br>
>> >>>> /home/lorensen/ProjectsGIT/VTKGerrit/Common/Core/Testing/Cxx/TestAtomic.cxx:158:<br>
>> >>>> undefined reference to `detail::vtkAtomicIntImpl<long long>::load()<br>
>> >>>> const'<br>
>> >>>> CMakeFiles/vtkCommonCoreCxxTests.dir/TestAtomic.cxx.o: In function<br>
>> >>>> `vtkAtomicInt':<br>
>> >>>><br>
>> >>>><br>
>> >>>> /home/lorensen/ProjectsGIT/VTKGerritNew-linux/Common/Core/vtkAtomicInt.h:363:<br>
>> >>>> undefined reference to `detail::vtkAtomicIntImpl<long<br>
>> >>>> long>::vtkAtomicIntImpl()'<br>
>> >>>> CMakeFiles/vtkCommonCoreCxxTests.dir/TestAtomic.cxx.o: In function<br>
>> >>>> `vtkAtomicInt<long long>::operator++()':<br>
>> >>>><br>
>> >>>><br>
>> >>>> /home/lorensen/ProjectsGIT/VTKGerritNew-linux/Common/Core/vtkAtomicInt.h:371:<br>
>> >>>> undefined reference to `detail::vtkAtomicIntImpl<long<br>
>> >>>> long>::operator++()'<br>
>> >>>> CMakeFiles/vtkCommonCoreCxxTests.dir/TestAtomic.cxx.o: In function<br>
>> >>>> `vtkAtomicInt<long long>::operator--()':<br>
>> >>>><br>
>> >>>><br>
>> >>>> /home/lorensen/ProjectsGIT/VTKGerritNew-linux/Common/Core/vtkAtomicInt.h:385:<br>
>> >>>> undefined reference to `detail::vtkAtomicIntImpl<long<br>
>> >>>> long>::operator--()'<br>
>> >>>> CMakeFiles/vtkCommonCoreCxxTests.dir/TestAtomic.cxx.o: In function<br>
>> >>>> `vtkAtomicInt<long long>::operator-=(long long)':<br>
>> >>>><br>
>> >>>><br>
>> >>>> /home/lorensen/ProjectsGIT/VTKGerritNew-linux/Common/Core/vtkAtomicInt.h:399:<br>
>> >>>> undefined reference to `detail::vtkAtomicIntImpl<long<br>
>> >>>> long>::operator+=(long long)'<br>
>> >>>> CMakeFiles/vtkCommonCoreCxxTests.dir/TestAtomic.cxx.o: In function<br>
>> >>>> `vtkAtomicInt<long long>::operator=(long long)':<br>
>> >>>><br>
>> >>>><br>
>> >>>> /home/lorensen/ProjectsGIT/VTKGerritNew-linux/Common/Core/vtkAtomicInt.h:413:<br>
>> >>>> undefined reference to `detail::vtkAtomicIntImpl<long<br>
>> >>>> long>::store(long long)'<br>
>> >>>><br>
>> >>>><br>
>> >>>> CMakeFiles/vtkCommonCoreCxxTests.dir/TestAtomic.cxx.o:(.rodata._ZTI12vtkAtomicIntIxE[typeinfo<br>
>> >>>> for vtkAtomicInt<long long>]+0x8): undefined reference to `typeinfo<br>
>> >>>> for detail::vtkAtomicIntImpl<long long>'<br>
>> >>>> CMakeFiles/vtkCommonCoreCxxTests.dir/TestAtomic.cxx.o: In function<br>
>> >>>> `~vtkAtomicInt':<br>
>> >>>><br>
>> >>>><br>
>> >>>> /home/lorensen/ProjectsGIT/VTKGerritNew-linux/Common/Core/vtkAtomicInt.h:349:<br>
>> >>>> undefined reference to `detail::vtkAtomicIntImpl<long<br>
>> >>>> long>::~vtkAtomicIntImpl()'<br>
>> >>>> collect2: ld returned 1 exit status<br>
>> >>>> make[2]: *** [bin/vtkCommonCoreCxxTests] Error 1<br>
>> >>>> make[1]: ***<br>
>> >>>> [Common/Core/Testing/Cxx/CMakeFiles/vtkCommonCoreCxxTests.dir/all]<br>
>> >>>> Error 2<br>
>> >>>> make: *** [all] Error 2<br>
>> >>>> [VTKGerritNew-linux]<br>
>> >>>> _______________________________________________<br>
>> >>>> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
>> >>>><br>
>> >>>> Visit other Kitware open-source projects at<br>
>> >>>> <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
>> >>>><br>
>> >>>> Follow this link to subscribe/unsubscribe:<br>
>> >>>> <a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
>> >>>><br>
>> >>><br>
>> >>><br>
>> >>> _______________________________________________<br>
>> >>> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
>> >>><br>
>> >>> Visit other Kitware open-source projects at<br>
>> >>> <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
>> >>><br>
>> >>> Follow this link to subscribe/unsubscribe:<br>
>> >>> <a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
>> >>><br>
>> >>><br>
><br>
><br>
</div></div></blockquote></div><br></div>