<div dir="ltr"><div><div><div><div><div>Hi Kevin, <br><br></div><div>Great :)<br></div><div><br></div>The patch should be both sent:<br><br></div> - to VTK dev list for integration to 5.10 release branch (gerrit is not yet ready to work with 5.10 release branch [1])<br>
<br></div> - as pull request based on commit 0e0674a3 [2] associated with branch "slicer-v5.10.1" [3] within SlicerVTK fork.<br><br><br></div>Let me know if you have any questions, <br></div>Jc<br><br>[1] <a href="http://vtk.1045678.n5.nabble.com/5-10-1-question-td5723589.html#a5723591">http://vtk.1045678.n5.nabble.com/5-10-1-question-td5723589.html#a5723591</a><br>
<br>[2] <a href="https://github.com/Slicer/VTK/commit/0e0674a3695fdeaf01ce87dfc04e32111b7402e0" target="_blank">https://github.com/Slicer/VTK/commit/0e0674a3695fdeaf01ce87dfc04e32111b7402e0</a><br><br>[3] <a href="https://github.com/Slicer/VTK/tree/slicer-v5.10.1" target="_blank">https://github.com/Slicer/VTK/tree/slicer-v5.10.1</a><br>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Sep 27, 2013 at 11:55 AM, Wang, Kevin <span dir="ltr"><<a href="mailto:kevin.wang@rmp.uhn.on.ca" target="_blank">kevin.wang@rmp.uhn.on.ca</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div link="blue" vlink="purple" lang="EN-US">
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Hi Jc,<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">I am almost done with the backporting and other changes to VTK5.10 and slicer. You mentioned that the changes in vtk can be integrated into the SlicerVTK clone
[1]. however, I am not clear on how to proceed. Do I follow the common practice to fork the slicerVTK repository and create a pull request or something else?<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Thanks,<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Kevin<u></u><u></u></span></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">[1] <a href="https://github.com/Slicer/VTK" target="_blank">https://github.com/Slicer/VTK</a><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Jean-Christophe Fillion-Robin [mailto:<a href="mailto:jchris.fillionr@kitware.com" target="_blank">jchris.fillionr@kitware.com</a>]
<br>
<b>Sent:</b> Thursday, September 19, 2013 11:19 AM<br>
<b>To:</b> Wang, Kevin<br>
<b>Cc:</b> David Thompson; <a href="mailto:vtk-developers@vtk.org" target="_blank">vtk-developers@vtk.org</a></span></p><div><div class="h5"><br>
<b>Subject:</b> Re: [vtk-developers] Possible vtkScalarBarActor improvement<u></u><u></u></div></div><p></p><div><div class="h5">
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt">Make sense. Let us know when you have your topic updated.
<u></u><u></u></p>
</div>
<p class="MsoNormal">Thanks for your hard work :)<u></u><u></u></p>
</div>
<p class="MsoNormal">Jc<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><u></u> <u></u></p>
<div>
<p class="MsoNormal">On Tue, Sep 17, 2013 at 11:27 AM, Wang, Kevin <<a href="mailto:kevin.wang@rmp.uhn.on.ca" target="_blank">kevin.wang@rmp.uhn.on.ca</a>> wrote:<u></u><u></u></p>
<p class="MsoNormal">Hi Jc and David,<br>
<br>
I think one reasonable solution would be to backport vtkScalarsToColors, but not backport vtkScalarBarActor. Instead we modify vtkScalarBarActor slightly to handle the new annotation functionality in vtkScalarsToColors. Then in slicer, we keep several sets
of vtkStringArrays around and switch them in vtkScalarsToColors when needed. This way when we transition to vtk6.0, there will be minimal changes.<br>
<br>
Thanks,<u></u><u></u></p>
<div>
<p class="MsoNormal"><br>
Kevin<br>
<br>
-----Original Message-----<br>
From: David Thompson [mailto:<a href="mailto:david.thompson@kitware.com" target="_blank">david.thompson@kitware.com</a>]<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt">Sent: Tuesday, September 17, 2013 11:16 AM<br>
To: Jean-Christophe Fillion-Robin<br>
Cc: Wang, Kevin; <a href="mailto:vtk-developers@vtk.org" target="_blank">vtk-developers@vtk.org</a><br>
Subject: Re: [vtk-developers] Possible vtkScalarBarActor improvement<u></u><u></u></p>
</div>
<div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt">Hi JC,<br>
<br>
> ...<br>
> @David: Do you see anything in the API proposed by Kevin that could be changed to be closer to what is possible in VTK 6 ?
<a href="https://github.com/kevinwangcanada/Slicer/commit/551c8b7f435b518664eef2917818addf78c853e6" target="_blank">
https://github.com/kevinwangcanada/Slicer/commit/551c8b7f435b518664eef2917818addf78c853e6</a><br>
<br>
I would not backport vtkScalarBarActor, but you could backport vtkScalarsToColors pretty easily and use it to store color names... that's where they are stored in VTK6.<br>
<br>
David<u></u><u></u></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt">This e-mail may contain confidential and/or privileged information for the sole use of the intended recipient.<br>
Any review or distribution by anyone other than the person for whom it was originally intended is strictly prohibited.<br>
If you have received this e-mail in error, please contact the sender and delete all copies.<br>
Opinions, conclusions or other information contained in this e-mail may not be that of the organization.<u></u><u></u></p>
</div>
</div>
</div>
<p class="MsoNormal"><br>
<br clear="all">
<br>
-- <br>
<a href="tel:%2B1%20919%20869%208849" value="+19198698849" target="_blank">+1 919 869 8849</a><u></u><u></u></p>
</div>
</div></div></div><div><div class="h5">
<font face="monospace"><br>
This e-mail may contain confidential and/or privileged information for the sole use of the intended recipient. <br>
Any review or distribution by anyone other than the person for whom it was originally intended is strictly prohibited. <br>
If you have received this e-mail in error, please contact the sender and delete all copies. <br>
Opinions, conclusions or other information contained in this e-mail may not be that of the organization.</font></div></div></div>
</blockquote></div><br><br clear="all"><br>-- <br>+1 919 869 8849<br>
</div>