<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Hi Jc,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Thanks for your comments.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Before I contribute a patch, I would like to ask something. What I did for slicer is to create a subclass of vtkScalarBarActor to accommodate the color name
changes, but I think it might not be good to create a subclass of vtkScalarBarActor just to add one method and one variable. Do you think maybe directly modify the vtkScalarBarActor would make more sense?
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Kevin<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Jean-Christophe Fillion-Robin [mailto:jchris.fillionr@kitware.com]
<br>
<b>Sent:</b> Friday, September 13, 2013 1:02 PM<br>
<b>To:</b> Wang, Kevin<br>
<b>Cc:</b> vtk-developers@vtk.org<br>
<b>Subject:</b> Re: [vtk-developers] Possible vtkScalarBarActor improvement<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">Hi Kevin, <o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">I think it makes sense to contribute this back to VTK. I would suggest to first contribute your improvement as a VTK-6 topic. <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">See <a href="http://www.vtk.org/Wiki/VTK/Git/Develop">http://www.vtk.org/Wiki/VTK/Git/Develop</a><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">In the mean, waiting it his fully reviewed, integrated and then eventually backported to VTK 5.10 release branch, we could integrate it to the SlicerVTK clone. See <a href="https://github.com/Slicer/VTK">https://github.com/Slicer/VTK</a><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Thanks for contributing to VTK, <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Jc<o:p></o:p></p>
</div>
</div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><o:p> </o:p></p>
<div>
<p class="MsoNormal">On Fri, Sep 13, 2013 at 10:46 AM, Wang, Kevin <<a href="mailto:kevin.wang@rmp.uhn.on.ca" target="_blank">kevin.wang@rmp.uhn.on.ca</a>> wrote:<o:p></o:p></p>
<div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Hi vtk-developers,<o:p></o:p></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">I am developing modules in Slicer and found one limitation in vtkScalarBarActor.
<o:p></o:p></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Currently vtk scalarbar widget only shows scalar value as labels. It would be useful in some applications to show the color names as labels. For example: when using the Slicer3_2010_label_Colors
color table in slicer, instead of showing the scalar values, it would be nice to show the color names as labels in scalarbar widget. Please find more info about this at
<a href="http://na-mic.org/Mantis/view.php?id=2919" target="_blank">http://na-mic.org/Mantis/view.php?id=2919</a><o:p></o:p></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">To enable this feature, I have created a new sub class of vtkScalarBarActor which allows adding color names with a method:
<span style="font-size:9.0pt;font-family:Consolas;color:#333333;background:white">
</span><o:p></o:p></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size:9.0pt;font-family:Consolas;color:#333333;background:white"> </span><o:p></o:p></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><b><span style="font-size:9.0pt;font-family:Consolas;color:#445588;background:white">int</span></b><span style="font-size:9.0pt;font-family:Consolas;color:#333333;background:white">
</span><b><span style="font-size:9.0pt;font-family:Consolas;color:#990000;background:white">SetColorName</span></b><span style="font-size:9.0pt;font-family:Consolas;color:#333333;background:white">(</span><b><span style="font-size:9.0pt;font-family:Consolas;color:#445588;background:white">int</span></b><span style="font-size:9.0pt;font-family:Consolas;color:#333333;background:white">
ind, <b>const</b> </span><b><span style="font-size:9.0pt;font-family:Consolas;color:#445588;background:white">char</span></b><span style="font-size:9.0pt;font-family:Consolas;color:#333333;background:white">
<b>*</b>name);</span><o:p></o:p></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size:9.0pt;font-family:Consolas;color:#333333;background:white"> </span><o:p></o:p></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">It also has a variable to enable/disable using the color as label. Please see the code as
<a href="https://github.com/kevinwangcanada/Slicer/blob/2919-Add-UseColorNameAsLabel-for-scalarbar-widget/Modules/Loadable/Colors/VTKRendering/vtkSlicerScalarBarActor.h" target="_blank">
https://github.com/kevinwangcanada/Slicer/blob/2919-Add-UseColorNameAsLabel-for-scalarbar-widget/Modules/Loadable/Colors/VTKRendering/vtkSlicerScalarBarActor.h</a><o:p></o:p></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Before we merge this into the slicer trunk, we would like to know if you think it is relevant and something like this can be merged into VTK. I have also created a ticket for this:
<a href="http://www.vtk.org/Bug/view.php?id=14272" target="_blank">http://www.vtk.org/Bug/view.php?id=14272</a><o:p></o:p></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Thanks for your consideration.<o:p></o:p></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Kevin
<o:p></o:p></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p>
</div>
<p class="MsoNormal"><span style="font-family:"Courier New""><br>
This e-mail may contain confidential and/or privileged information for the sole use of the intended recipient.
<br>
Any review or distribution by anyone other than the person for whom it was originally intended is strictly prohibited.
<br>
If you have received this e-mail in error, please contact the sender and delete all copies.
<br>
Opinions, conclusions or other information contained in this e-mail may not be that of the organization.</span><o:p></o:p></p>
</div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><br>
_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">
http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
<br>
<o:p></o:p></p>
</div>
<p class="MsoNormal"><br>
<br clear="all">
<o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<p class="MsoNormal">-- <br>
+1 919 869 8849<o:p></o:p></p>
</div>
</div>
<font face="monospace"><br>
This e-mail may contain confidential and/or privileged information for the sole use of the intended recipient. <br>
Any review or distribution by anyone other than the person for whom it was originally intended is strictly prohibited. <br>
If you have received this e-mail in error, please contact the sender and delete all copies. <br>
Opinions, conclusions or other information contained in this e-mail may not be that of the organization.</font></body>
</html>