<div dir="ltr">Hi Sean,<div><br></div><div>Can you apply the attached patch and run TestNamedColors with -V? I'd like to see what PrintSelf is producing that is different that previously.</div><div><br></div><div>Thanks,</div>
<div style>-berk</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Aug 29, 2013 at 7:03 PM, Andrew Maclean <span dir="ltr"><<a href="mailto:andrew.amaclean@gmail.com" target="_blank">andrew.amaclean@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Berk, Sean,<div> Since I was the author of this test, let me know if there is anything I can do to help.</div>
<div><br></div><div>The intent of this test was to test as much as possible of the vtkNamedColors class - I think I achieved around 100%.</div>
<div><br></div><div>Lines 890-901 specifically test PrintSelf(). PrintSelf() seems to be rarely tested so initially I expected some problems, however this is the first time I have seen anything. </div><div><br></div><div>
Like Berk, I don't understand why this would fail on one machine but not others.</div><div><br></div><div>Regards</div><div> Andrew<br><div class="gmail_extra"><br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
---------- Forwarded message ----------<br>From: Berk Geveci <<a href="mailto:berk.geveci@kitware.com" target="_blank">berk.geveci@kitware.com</a>><br>To: Sean McBride <<a href="mailto:sean@rogue-research.com" target="_blank">sean@rogue-research.com</a>><br>
Cc: VTK Developers <<a href="mailto:vtk-developers@vtk.org" target="_blank">vtk-developers@vtk.org</a>><br>Date: Wed, 28 Aug 2013 13:31:19 -0400<br>Subject: Re: [vtk-developers] vtkCommonColorCxx-TestNamedColors test failure, git bisected to atomic int changes<br>
<div dir="ltr">I am going to track it down. Ultimately, it is a crappy test that depends on the output of PrintSelf() which fails when things like MTime changes. Nevertheless, I need to figure out why the MTime changed on some platforms and not others.<div>
<br></div><div>-berk</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Aug 28, 2013 at 12:52 PM, Sean McBride <span dir="ltr"><<a href="mailto:sean@rogue-research.com" target="_blank">sean@rogue-research.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Berk,<br>
<br>
The vtkCommonColorCxx-TestNamedColors test passed here:<br>
<br>
<<a href="http://open.cdash.org/testDetails.php?test=193771179&build=3005399" target="_blank">http://open.cdash.org/testDetails.php?test=193771179&build=3005399</a>><br>
<br>
and started failing here:<br>
<br>
<<a href="http://open.cdash.org/testDetails.php?test=204990005&build=3006482" target="_blank">http://open.cdash.org/testDetails.php?test=204990005&build=3006482</a>><br>
<br>
I used git bisect, and it points to this:<br>
<br>
---------------------<br>
8d3f2756c9025012320c1e65288f6006d9acd7a8 is the first bad commit<br>
commit 8d3f2756c9025012320c1e65288f6006d9acd7a8<br>
Author: Berk Geveci <<a href="mailto:berk.geveci@kitware.com" target="_blank">berk.geveci@kitware.com</a>><br>
Date: Wed Aug 21 12:08:17 2013 -0400<br>
<br>
Implements a few improvements for the atomic integers.<br>
<br>
The main concern on the mailing list was that some of the<br>
implementation was not using memory barriers/fences, which<br>
may be dangerous in some cases. I made the first attempt to<br>
make much of the atomic functionality use a sequentially-<br>
consistent ordering by using memory barriers. The performance<br>
impact seems to be relatively small but we will have to keep<br>
an eye on it.<br>
<br>
I also made some changes to the implementation that will<br>
hopefully avoid falling back to critical sections on Windows<br>
XP.<br>
<br>
Change-Id: Ib05f411f905cfe9a89bb8bc82ca103d3c1eb8002<br>
---------------------<br>
<br>
The verbose test output is:<br>
<br>
---------------------<br>
176: Test command: /Users/builder/external/VTK-clang-rel-x86_64/bin/vtkCommonColorCxxTests.app/Contents/MacOS/vtkCommonColorCxxTests "TestNamedColors" "-D" "/Users/builder/external/VTK-clang-rel-x86_64/ExternalData/Testing" "-T" "/Users/builder/external/VTK-clang-rel-x86_64/Testing/Temporary"<br>
176: Test timeout computed to be: 1500<br>
176: Generic Warning: In /Users/builder/external/VTK/Common/Color/Testing/Cxx/TestNamedColors.cxx, line 899<br>
176: Fail: PrintSelf() - a string of size 9243 was expected, got 9261 instead.<br>
176:<br>
1/1 Test #176: vtkCommonColorCxx-TestNamedColors ...***Failed 0.15 sec<br>
---------------------<br>
<br>
Cheers,<span class="HOEnZb"><font color="#888888"><br>
<span><font color="#888888"><br>
--<br>
____________________________________________________________<br>
Sean McBride, B. Eng <a href="mailto:sean@rogue-research.com" target="_blank">sean@rogue-research.com</a><br>
Rogue Research <a href="http://www.rogue-research.com" target="_blank">www.rogue-research.com</a><br>
Mac Software Developer Montréal, Québec, Canada<br>
<br>
<br>
</font></span></font></span></blockquote></div><span class="HOEnZb"><font color="#888888"><br></font></span></div><span class="HOEnZb"><font color="#888888">
</font></span></blockquote></div><span class="HOEnZb"><font color="#888888"><div><br></div>-- <br>___________________________________________<br>Andrew J. P. Maclean<br><br>___________________________________________
</font></span></div></div></div>
</blockquote></div><br></div>