<div dir="ltr"><span style="font-family:arial,sans-serif;font-size:12.800000190734863px">+1 for AddViewProp all others in legacy. Would have been nice to have it called AddProp (why add View?) . We have vtkProp and not vtkViewProp as the class name. May be we can add that as the new method? thoughts? </span><div>
<div><span style="font-family:arial,sans-serif;font-size:12.800000190734863px"><br></span></div><div style><span style="font-family:arial,sans-serif;font-size:12.800000190734863px">- Aashish</span></div><div style><span style="font-family:arial,sans-serif;font-size:12.800000190734863px"><br>
</span></div></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Aug 29, 2013 at 11:08 AM, David E DeMarle <span dir="ltr"><<a href="mailto:dave.demarle@kitware.com" target="_blank">dave.demarle@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I'm in Sean's camp. One class to rule them all is easier to get your head around.<span class="HOEnZb"><font color="#888888"><div>
<br></div></font></span></div><div class="gmail_extra"><span class="HOEnZb"><font color="#888888"><br clear="all"><div>David E DeMarle<br>Kitware, Inc.<br>R&D Engineer<br>
21 Corporate Drive<br>Clifton Park, NY 12065-8662<br>Phone: <a href="tel:518-881-4909" value="+15188814909" target="_blank">518-881-4909</a></div>
<br><br></font></span><div class="gmail_quote"><div><div class="h5">On Wed, Aug 28, 2013 at 7:25 PM, Bill Lorensen <span dir="ltr"><<a href="mailto:bill.lorensen@gmail.com" target="_blank">bill.lorensen@gmail.com</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5">
<div dir="ltr">I think from a user point of view, not being concerned about inheritance, the old names make sense.<div><br></div></div><div class="gmail_extra"><div><br><br><div class="gmail_quote">On Wed, Aug 28, 2013 at 4:59 PM, Sean McBride <span dir="ltr"><<a href="mailto:sean@rogue-research.com" target="_blank">sean@rogue-research.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>On Wed, 28 Aug 2013 16:37:05 -0400, Bill Lorensen said:<br>
<br>
>I think AddActor(), AddActor2D(), and AddVolume() are more descriptive than<br>
>AddViewProp even though they are just wrappers.<br>
<br>
</div>Be that as it may, I think it's pretty weird for someone starting with VTK 6.<br>
<br>
Class hierarchy reminder:<br>
<br>
vtkObject -> vtkProp -> vtkProp3D -> vtkActor<br>
vtkObject -> vtkProp -> vtkProp3D -> vtkVolume<br>
vtkObject -> vtkProp -> vtkActor2D<br>
<br>
The newer AddViewProp() takes a vtkProp*, which makes sense, as it works with all 3 types.<br>
<br>
The older methods AddActor(), AddActor2D(), and AddVolume() strangely all also take a vtkProp*, that's pretty weird given their name. ex: you'd think AddVolume() would take a vtkVolume*, no? Why should it accept any vtkProp subclass?<br>
<br>
It's also weird that AddActor() and AddVolume() come from vtkRenderer, while AddActor2D() comes from the superclass vtkViewPort.<br>
<br>
How to explain all this to someone new to VTK 6?<br>
<br>
It seems like cruft to me. IMNSHO, using only AddViewProp() seems preferable, which is why I'd like to do the cleanup and eventually wrap the old three in VTK_LEGACY.<br>
<div><div><br>
Cheers,<br>
<br>
--<br>
____________________________________________________________<br>
Sean McBride, B. Eng <a href="mailto:sean@rogue-research.com" target="_blank">sean@rogue-research.com</a><br>
Rogue Research <a href="http://www.rogue-research.com" target="_blank">www.rogue-research.com</a><br>
Mac Software Developer Montréal, Québec, Canada<br>
<br>
<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div></div><div>-- <br>Unpaid intern in BillsBasement at noware dot com<br>
</div></div>
<br></div></div><div class="im">_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
<br>
<br></div></blockquote></div><br></div>
<br>_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
<br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br>| Aashish Chaudhary <br>| R&D Engineer <br>| Kitware Inc. <br>| <a href="http://www.kitware.com">www.kitware.com</a>
</div>