<div dir="ltr">About the UI - agreed. No one likes it or finds it intuitive.<div><br><div>Try the search field in the top right: (and no I don't know what the entire set of keys is either)<div>for example:<br><div>entity:topic status:open project:VTK</div>
<div>entity:change reviewer:"John Biddiscombe" status:open<br></div><div>entity:topic owner:"John Biddiscombe" status:merged<br></div><div><div><br></div><div>About long topics/patchsets - also agreed. The list decided that best practice is to limit topics to a handful of commits in length. It makes it easier for others to understand what you did and review it, and makes it easier to rebase or merge the topic into an ever changing master. What a handful means exactly is up for interpretation.</div>
<div><br></div><div style>Another point - everyone should understand the distinction between topics and patchsets.</div><div style><br></div><div style>A topic is a just of series of git commits. Kitware's gerrit is unique in that we've modified it to know about topics. Upstream gerrit only knows about commits. Topics are a good thing, but they introduce even more wrinkles. We only allow merges at the topic level and regression tests are kicked off from the commit level for example.</div>
<div style><br></div><div style>A change set is a series of attempts at the same thing. This can be at the commit or topic level. Take the commit level for simplicity. If I submit something, and Bill rejects it in review. I will fix whatever dumb thing I did and resubmit. I'll keep the same Change Id my commit message (git --amend) to tell gerrit that I am working on the same thing. Gerrit will show this as a new patchset on the same topic. Bill will review that and eventually I'll either merge it, or abandon it. When I merge it, git master only sees the more recent patch set and the wrong paths I took are forgotten.</div>
<div style><br></div><div style>In any case, to make it easier to test someone's elses long set of changes, use the download button to copy the "git fetch..." string from the most recent patchset on the topic level so that you get the most recent patchset of the entire topic all at once.</div>
<div><div><div><div class="gmail_extra"><br clear="all"><div>David E DeMarle<br>Kitware, Inc.<br>R&D Engineer<br>21 Corporate Drive<br>Clifton Park, NY 12065-8662<br>Phone: 518-881-4909</div>
<br><br><div class="gmail_quote">On Fri, Jul 19, 2013 at 3:48 AM, Biddiscombe, John A. <span dir="ltr"><<a href="mailto:biddisco@cscs.ch" target="_blank">biddisco@cscs.ch</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div lang="EN-GB" link="blue" vlink="purple">
<div>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">Dave<u></u><u></u></span></p>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">Thanks for the explanation. Since I’m not a member of the “core” group, I guess this doesn’t apply to me and I have to wait in line like everyone else.<u></u><u></u></span></p>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u> <u></u></span></p>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">I’ve been playing with gerrit a bit and reviewing people’s patches (I’m warming to the system). It’s hard to navigate and find ones that are ‘doable’ - many
have huge patch sets and a proper review would require a full checkout of the branch with some local testing. I would like to get up to speed with working with the system as my intern this summer will hopefully tart up the paraview volume render interface
and I want this to go into the official distribution with testing etc.<u></u><u></u></span></p>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u> <u></u></span></p>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">I’ve added VTK/ParaView to my watched projects but there doesn’t seem to be a simple way of saying “show me open topics in these two”,
<u></u><u></u></span></p>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">If I use “My/Changes/Watched” I see VTK/ParaView, but they nearly all date back to 2012, if I try “All/topics/open”, then I get more recent ones, but I also
see all the other projects that I’m not involved with.<u></u><u></u></span></p>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u> <u></u></span></p>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">If there’s a simple way of seeing all VTK/ParaView topics that are in need of review, please tell.<u></u><u></u></span></p>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u> <u></u></span></p>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">Ta<u></u><u></u></span></p>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u> <u></u></span></p>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">JB<u></u><u></u></span></p>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u> <u></u></span></p>
<div style="border-style:none none none solid;border-left-width:1.5pt;border-left-color:blue;padding:0cm 0cm 0cm 4pt">
<div>
<div style="border-style:solid none none;border-top-width:1pt;border-top-color:rgb(181,196,223);padding:3pt 0cm 0cm">
<p class=""><b><span lang="EN-US" style="font-size:10pt;font-family:Tahoma,sans-serif">From:</span></b><span lang="EN-US" style="font-size:10pt;font-family:Tahoma,sans-serif"> David E DeMarle [mailto:<a href="mailto:dave.demarle@kitware.com" target="_blank">dave.demarle@kitware.com</a>]
<br>
<b>Sent:</b> 18 July 2013 16:41<br>
<b>To:</b> Biddiscombe, John A.<br>
<b>Cc:</b> David Cole; Bill Lorensen; <a href="mailto:vtk-developers@vtk.org" target="_blank">vtk-developers@vtk.org</a></span></p><div><div class="h5"><br>
<b>Subject:</b> Re: [vtk-developers] [VTK 0014170]: Segfault in vtkSmartVolumeMapper<u></u><u></u></div></div><p></p>
</div>
</div><div><div class="h5">
<p class=""><u></u> <u></u></p>
<div>
<p class="">Here is how it should work:<u></u><u></u></p>
<div>
<p class=""><u></u> <u></u></p>
</div>
<div>
<p class="">Anyone in the core: <a href="http://review.source.kitware.com/#/admin/groups/11,members" target="_blank">http://review.source.kitware.com/#/admin/groups/11,members</a> has a build and ctest spawned on mac, linux and windows immediately once they git gerrit-push.<u></u><u></u></p>
</div>
<div>
<p class=""><u></u> <u></u></p>
</div>
<div>
<p class="">Anyone gets test spawned only when someone in the core requests the tests to run (for security)<u></u><u></u></p>
</div>
<div>
<p class=""><u></u> <u></u></p>
</div>
<div>
<p class="">In either case click on the topic in gerrit and click on the filtered CDash results to get to them.<u></u><u></u></p>
</div>
<div>
<p class=""><u></u> <u></u></p>
</div>
<div>
<p class="">Anyone in the core can then merge the change (assuming the reviewers were not grumpy) into master through gerrit. After this it is just like in the old days, the continuous testers immediately test it a bit more thoroughly, and then at
9pm the nightlies test it even more thoroughly.<u></u><u></u></p>
</div>
<div>
<p class=""><u></u> <u></u></p>
</div>
</div>
<div>
<p class=""><br clear="all">
<u></u><u></u></p>
<div>
<p class="">David E DeMarle<br>
Kitware, Inc.<br>
R&D Engineer<br>
21 Corporate Drive<br>
Clifton Park, NY 12065-8662<br>
Phone: <a href="tel:518-881-4909" value="+15188814909" target="_blank">518-881-4909</a><u></u><u></u></p>
</div>
<p class="" style="margin-bottom:12pt"><u></u> <u></u></p>
<div>
<p class="">On Wed, Jul 17, 2013 at 4:10 AM, Biddiscombe, John A. <<a href="mailto:biddisco@cscs.ch" target="_blank">biddisco@cscs.ch</a>> wrote:<u></u><u></u></p>
<div>
<div>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">Not very impressed with this gerrit stuff. In the old days I’d commit a change and the next morning
the dashboard would show the files updated and the tests run (this code wasn’t tested, so I’m not expecting problems).</span><u></u><u></u></p>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"> </span><u></u><u></u></p>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">How will I know when to monitor the dashboard when the commits sit inside gerrit until one day something
presumably happens?</span><u></u><u></u></p>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"> </span><u></u><u></u></p>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">JB</span><u></u><u></u></p>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"> </span><u></u><u></u></p>
<div style="border-style:none none none solid;border-left-width:1.5pt;border-left-color:blue;padding:0cm 0cm 0cm 4pt">
<div>
<div style="border-style:solid none none;border-top-width:1pt;border-top-color:rgb(181,196,223);padding:3pt 0cm 0cm">
<p class=""><b><span lang="EN-US" style="font-size:10pt;font-family:Tahoma,sans-serif">From:</span></b><span lang="EN-US" style="font-size:10pt;font-family:Tahoma,sans-serif"> Biddiscombe,
John A. <br>
<b>Sent:</b> 15 July 2013 17:17<br>
<b>To:</b> Biddiscombe, John A.; David Cole; Bill Lorensen<br>
<b>Cc:</b> <a href="mailto:vtk-developers@vtk.org" target="_blank">vtk-developers@vtk.org</a><br>
<b>Subject:</b> RE: [vtk-developers] [VTK 0014170]: Segfault in vtkSmartVolumeMapper</span><u></u><u></u></p>
</div>
</div>
<div>
<div>
<p class=""> <u></u><u></u></p>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">On another machine the change-ID is generated correctly. So I’ve pushed from there.</span><u></u><u></u></p>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"> </span><u></u><u></u></p>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"> </span><u></u><u></u></p>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"> </span><u></u><u></u></p>
<div style="border-style:none none none solid;border-left-width:1.5pt;border-left-color:blue;padding:0cm 0cm 0cm 4pt">
<div>
<div style="border-style:solid none none;border-top-width:1pt;border-top-color:rgb(181,196,223);padding:3pt 0cm 0cm">
<p class=""><b><span lang="EN-US" style="font-size:10pt;font-family:Tahoma,sans-serif">From:</span></b><span lang="EN-US" style="font-size:10pt;font-family:Tahoma,sans-serif">
<a href="mailto:vtk-developers-bounces@vtk.org" target="_blank">vtk-developers-bounces@vtk.org</a> [<a href="mailto:vtk-developers-bounces@vtk.org" target="_blank">mailto:vtk-developers-bounces@vtk.org</a>]
<b>On Behalf Of </b>Biddiscombe, John A.<br>
<b>Sent:</b> 15 July 2013 16:03<br>
<b>To:</b> David Cole; Bill Lorensen<br>
<b>Cc:</b> <a href="mailto:vtk-developers@vtk.org" target="_blank">vtk-developers@vtk.org</a><br>
<b>Subject:</b> Re: [vtk-developers] [VTK 0014170]: Segfault in vtkSmartVolumeMapper</span><u></u><u></u></p>
</div>
</div>
<p class=""> <u></u><u></u></p>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">I did the setup stuff first and tried many times to redo the commit, but it won’t generate one. Unfortunalty,
I’m trying to work on another branch and if I switch back to the topic branch the entire paraview will rebuild again
</span><span style="font-size:11pt;font-family:Wingdings;color:rgb(31,73,125)">L</span><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"> so I’m reluctant to experiment.</span><u></u><u></u></p>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"> </span><u></u><u></u></p>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">JB</span><u></u><u></u></p>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"> </span><u></u><u></u></p>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"> </span><u></u><u></u></p>
<div style="border-style:none none none solid;border-left-width:1.5pt;border-left-color:blue;padding:0cm 0cm 0cm 4pt">
<div>
<div style="border-style:solid none none;border-top-width:1pt;border-top-color:rgb(181,196,223);padding:3pt 0cm 0cm">
<p class=""><b><span lang="EN-US" style="font-size:10pt;font-family:Tahoma,sans-serif">From:</span></b><span lang="EN-US" style="font-size:10pt;font-family:Tahoma,sans-serif"> David
Cole [<a href="mailto:dlrdave@aol.com" target="_blank">mailto:dlrdave@aol.com</a>]
<br>
<b>Sent:</b> 15 July 2013 16:00<br>
<b>To:</b> Bill Lorensen; Biddiscombe, John A.<br>
<b>Cc:</b> <a href="mailto:vtk-developers@vtk.org" target="_blank">vtk-developers@vtk.org</a><br>
<b>Subject:</b> Re: [vtk-developers] [VTK 0014170]: Segfault in vtkSmartVolumeMapper</span><u></u><u></u></p>
</div>
</div>
<p class=""> <u></u><u></u></p>
<div>
<div>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">> I can’t do a gerrit push because it keeps asking for an Id and I don’t want to make one up!</span><u></u><u></u></p>
</div>
<div>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">> </span><u></u><u></u></p>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">> Where do I get it from?</span><u></u><u></u></p>
<p class=""> <u></u><u></u></p>
<p class=""> <u></u><u></u></p>
<p class=""><span style="font-family:Calibri,sans-serif;color:rgb(31,73,125)">It comes from the stuff set up by the setup for development script.</span><u></u><u></u></p>
<p class=""> <u></u><u></u></p>
<p class=""><span style="font-family:Calibri,sans-serif;color:rgb(31,73,125)">If you made the commit before running the script, it won’t have one.</span><u></u><u></u></p>
<p class=""> <u></u><u></u></p>
<p class=""><span style="font-family:Calibri,sans-serif;color:rgb(31,73,125)">If you just do “git commit --amend” now on that commit, one should be added for you.</span><u></u><u></u></p>
<p class=""> <u></u><u></u></p>
<p class=""><span style="font-family:Calibri,sans-serif;color:rgb(31,73,125)">Then you should be able to push.</span><u></u><u></u></p>
<p class=""> <u></u><u></u></p>
<p class=""> <u></u><u></u></p>
<p class=""><span style="font-family:Calibri,sans-serif;color:rgb(31,73,125)">HTH,</span><u></u><u></u></p>
<p class=""><span style="font-family:Calibri,sans-serif;color:rgb(31,73,125)">David C.</span><u></u><u></u></p>
<p class=""> <u></u><u></u></p>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
<p class="" style="margin-bottom:12pt"><br>
_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">
http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
<br>
<u></u><u></u></p>
</div>
<p class=""><u></u> <u></u></p>
</div>
</div></div></div>
</div>
</div>
</blockquote></div><br></div></div></div></div></div></div></div></div></div>