<div dir="ltr">Awesome!<div><br></div><div>If you rebase on master, your Gerrits should be green again. Sebastien changed text rendering so the new baselines don't match the old rendering code. Since Gerrit machines always use the latest VTKData, your tests are getting new baseline images.</div>
<div><br></div><div style>-berk</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Apr 12, 2013 at 3:45 AM, Andrew Maclean <span dir="ltr"><<a href="mailto:andrew.amaclean@gmail.com" target="_blank">andrew.amaclean@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Thanks for your comments Berk, these were tests that I modified. All are fixed now, there is nothing wrong with the test machine. I had left code in which worked when testing in windows but not in Linux.<div>
<br></div><div>
Just a big thanks to all you who spent a lot of effort at the end of February making the dashboards green. See: <a href="http://www.kitware.com/blog/home/post/459" target="_blank">http://www.kitware.com/blog/home/post/459</a>. It made my life so easy doing this rather large commit I am happy to buy all the participants a beer.</div>
<div><br></div><div>I just realised that I have changed roughly a third of the Python tests. This would have been very difficult to do if the dashboard wasn't green.</div>
<div><br></div><div>Regards</div><div> Andrew</div><div><br></div></div><div class="gmail_extra"><div><div class="h5"><br><br><div class="gmail_quote">On Fri, Apr 12, 2013 at 3:59 AM, Berk Geveci <span dir="ltr"><<a href="mailto:berk.geveci@kitware.com" target="_blank">berk.geveci@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Hi Andrew,</div><div><br></div>Are those all tests that you modified? It is not clear from the error whether it is the X error or the leak that cause the error. If the X error leads to a crash, it might print false leak information. Did you locally compile with VTK_DEBUG_LEAKS to verify?<div>
<br></div><div>If you can't trace it, one of us can try to track it on the machine.</div><div><br></div><div>-berk</div></div><div class="gmail_extra"><br><br><div class="gmail_quote"><div><div>On Thu, Apr 11, 2013 at 7:21 AM, Andrew Maclean <span dir="ltr"><<a href="mailto:andrew.amaclean@gmail.com" target="_blank">andrew.amaclean@gmail.com</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><p dir="ltr">Sorry about that, I have removed "Tcl-isms" such as lindex etc. in around 131 python tests. See: <a href="http://review.source.kitware.com/10819" target="_blank">http://review.source.kitware.com/10819</a>. Of these tests 12 are failing: <a href="http://open.cdash.org/buildSummary.php?buildid=2872246" target="_blank">http://open.cdash.org/buildSummary.php?buildid=2872246</a></p>
<p dir="ltr">I'll look into these in about 12 hours time. All these tests passed on my Windows 8 machine. If anyone has any advice regarding these failures, feel free to comment.</p>
<p dir="ltr">Regards<span><font color="#888888"><br>
Andrew<br>
</font></span></p>
<br></div></div>_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
<br>
<br></blockquote></div><br></div>
</blockquote></div><br><br clear="all"><div><br></div></div></div><span class="HOEnZb"><font color="#888888">-- <br>___________________________________________<br>Andrew J. P. Maclean<br><br>___________________________________________
</font></span></div>
</blockquote></div><br></div>