<div dir="ltr">I want to chime in that for Window developers ninja has been a real time saver compared to using Visual Studio. Dropping support for ninja will once again mean that developers working on windows will have to deal with an extremely slow compiler toolset.</div>
<div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Apr 1, 2013 at 2:24 PM, Marcus D. Hanwell <span dir="ltr"><<a href="mailto:marcus.hanwell@kitware.com" target="_blank">marcus.hanwell@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I think you are overreacting, the patch submitted seems to make a<br>
minimal change that fixes dependencies for ninja. The removal of a<br>
dependency is something David Gobbi asked about, it would be good to<br>
address his question.<br>
<br>
I was simply stating that moving to support a new generator, platform,<br>
compiler should perhaps be a little more of a conscious choice (just<br>
as moving to drop support is). Being in the nightly section doesn't<br>
mean errors will be ignored either, and is a perfectly valid way of<br>
adding support for new <insert thing here> before moving them to the<br>
expected section.<br>
<span class="HOEnZb"><font color="#888888"><br>
Marcus<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
On Mon, Apr 1, 2013 at 1:56 PM, David Cole <<a href="mailto:dlrdave@aol.com">dlrdave@aol.com</a>> wrote:<br>
><br>
> OK -- so ninja is not officially supported. And sounds like it will not be in the near future either. I can live with that, although it is disappointing.<br>
><br>
> Are jom or nmake officially supported? Or shall I switch to using the Visual Studio generator to submit dashboards from this machine?<br>
><br>
> We may as well abandon the gerrit topic then, and Marcus, thanks for the offer, but don't even bother trying... If it's not going to be supported, then none of us should waste any more of our time on it.<br>
><br>
><br>
> Thanks,<br>
> David C.<br>
><br>
><br>
><br>
> -----Original Message-----<br>
> From: Marcus D. Hanwell <<a href="mailto:marcus.hanwell@kitware.com">marcus.hanwell@kitware.com</a>><br>
> To: Bill Lorensen <<a href="mailto:bill.lorensen@gmail.com">bill.lorensen@gmail.com</a>><br>
> Cc: David Cole <<a href="mailto:dlrdave@aol.com">dlrdave@aol.com</a>>; VTK Developers <<a href="mailto:vtk-developers@vtk.org">vtk-developers@vtk.org</a>>; Berk Geveci <<a href="mailto:berk.geveci@kitware.com">berk.geveci@kitware.com</a>><br>
> Sent: Mon, Apr 1, 2013 1:38 pm<br>
> Subject: Re: [vtk-developers] Moved Mirkwood ninja dashboards to nightly<br>
><br>
><br>
><br>
> I think supporting a new generator or platform should involve a little more than implicitly agreeing by adding a submission to the expected section of our dashboards. Several of us knew there were issues with the Ninja generator which we hadn't had time/resource to investigate. Whenever I tried building VTK with wrapping using Ninja it failed in the same way as the mirkwood submissions.<br>
><br>
><br>
> Dave Cole should address the comment David Gobbi made on the proposed patch, I will give it a try here and see if it works. I don't see any sweeping under the rug, in my use of ninja it is clear that the CMake support is not as mature and there are still several holes - how many should the VTK community be expected to plug? I will take a quick look now, and see if things are improved here.<br>
><br>
><br>
><br>
> On Mon, Apr 1, 2013 at 1:08 PM, Bill Lorensen <<a href="mailto:bill.lorensen@gmail.com">bill.lorensen@gmail.com</a>> wrote:<br>
><br>
><br>
> I agree with Dave. The defects were introduced by a VTK commit. They should be fixed.<br>
><br>
><br>
> Bill<br>
><br>
><br>
><br>
><br>
><br>
><br>
> On Mon, Apr 1, 2013 at 1:07 PM, Bill Lorensen <<a href="mailto:bill.lorensen@gmail.com">bill.lorensen@gmail.com</a>> wrote:<br>
><br>
><br>
><br>
><br>
><br>
><br>
><br>
> On Mon, Apr 1, 2013 at 12:53 PM, David Cole <<a href="mailto:dlrdave@aol.com">dlrdave@aol.com</a>> wrote:<br>
><br>
> Fabulous. (Not really, that's email sarcasm.)<br>
><br>
> It was green until this commit was merged to master: <a href="http://vtk.org/gitweb?p=VTK.git;a=commitdiff;h=34903fe1ba157683efb0062abcc73cd163d5ff89" target="_blank">http://vtk.org/gitweb?p=VTK.git;a=commitdiff;h=34903fe1ba157683efb0062abcc73cd163d5ff89</a><br>
><br>
> Even with python wrapping on, this change would fix it, if we would take it: <a href="http://review.source.kitware.com/#/c/10481/" target="_blank">http://review.source.kitware.com/#/c/10481/</a><br>
><br>
> If I just turn python wrapping off, it will also be green again. I will do that if we refuse to accept the change I've proposed in gerrit.<br>
><br>
> I don't think moving it away is the right response when it was green before.....<br>
><br>
> It was working on March 25th. Changes merged to master that day broke it for March 26th's dashboard. I object to moving it away and sweeping this under the rug. It's a recent break in the VTK master code base, it is not an intractable problem with ninja.<br>
><br>
> If ninja is not officially supported for VTK, then I'll move it to an "NMake" or "jom" driven dashboard. I think it's ridiculous *not* to support ninja when it's clearly viable and provides the fastest possible build times on Windows.<br>
><br>
><br>
><br>
><br>
> -----Original Message-----<br>
> From: Berk Geveci <<a href="mailto:berk.geveci@kitware.com">berk.geveci@kitware.com</a>><br>
> To: VTK Developers <<a href="mailto:vtk-developers@vtk.org">vtk-developers@vtk.org</a>><br>
> Sent: Mon, Apr 1, 2013 11:53 am<br>
> Subject: [vtk-developers] Moved Mirkwood ninja dashboards to nightly<br>
><br>
><br>
> Hi folks,<br>
><br>
><br>
> I just moved the Mirkwood ninja dashboards from Nightly Expected to Nightly. If someone wants to fix the ninja build issues, great. But having them in Nightly Expected is not helping us clean the dashboard. As far as I am concerned, VTK ninja builds are not officially supported.<br>
><br>
><br>
> -berk<br>
><br>
><br>
><br>
> _______________________________________________<br>
> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
><br>
> Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
><br>
> Follow this link to subscribe/unsubscribe:<br>
> <a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
><br>
><br>
> _______________________________________________<br>
> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
><br>
> Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
><br>
> Follow this link to subscribe/unsubscribe:<br>
> <a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
><br>
><br>
><br>
><br>
><br>
><br>
> --<br>
> Unpaid intern in BillsBasement at noware dot com<br>
><br>
><br>
><br>
><br>
><br>
> --<br>
> Unpaid intern in BillsBasement at noware dot com<br>
><br>
><br>
><br>
> _______________________________________________<br>
> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
><br>
> Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
><br>
> Follow this link to subscribe/unsubscribe:<br>
> <a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
><br>
><br>
><br>
><br>
><br>
><br>
><br>
_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>Robert Maynard
</div>