<div dir="ltr"><div style>I think supporting a new generator or platform should involve a little more than implicitly agreeing by adding a submission to the expected section of our dashboards. Several of us knew there were issues with the Ninja generator which we hadn't had time/resource to investigate. Whenever I tried building VTK with wrapping using Ninja it failed in the same way as the mirkwood submissions.</div>
<div style><br></div><div style>Dave Cole should address the comment David Gobbi made on the proposed patch, I will give it a try here and see if it works. I don't see any sweeping under the rug, in my use of ninja it is clear that the CMake support is not as mature and there are still several holes - how many should the VTK community be expected to plug? I will take a quick look now, and see if things are improved here.</div>
<div style><br></div><div class="gmail_extra"><div class="gmail_quote">On Mon, Apr 1, 2013 at 1:08 PM, Bill Lorensen <span dir="ltr"><<a href="mailto:bill.lorensen@gmail.com" target="_blank">bill.lorensen@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>I agree with Dave. The defects were introduced by a VTK commit. They should be fixed.<span class="HOEnZb"><font color="#888888"><br>
<br></font></span></div><span class="HOEnZb"><font color="#888888">Bill<br><br></font></span></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Apr 1, 2013 at 1:07 PM, Bill Lorensen <span dir="ltr"><<a href="mailto:bill.lorensen@gmail.com" target="_blank">bill.lorensen@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br></div><div class="gmail_extra"><div><div><br><br><div class="gmail_quote">On Mon, Apr 1, 2013 at 12:53 PM, David Cole <span dir="ltr"><<a href="mailto:dlrdave@aol.com" target="_blank">dlrdave@aol.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Fabulous. (Not really, that's email sarcasm.)<br>
<br>
It was green until this commit was merged to master: <a href="http://vtk.org/gitweb?p=VTK.git;a=commitdiff;h=34903fe1ba157683efb0062abcc73cd163d5ff89" target="_blank">http://vtk.org/gitweb?p=VTK.<u></u>git;a=commitdiff;h=<u></u>34903fe1ba157683efb0062abcc73c<u></u>d163d5ff89</a><br>
<br>
Even with python wrapping on, this change would fix it, if we would take it: <a href="http://review.source.kitware.com/#/c/10481/" target="_blank">http://review.source.kitware.<u></u>com/#/c/10481/</a><br>
<br>
If I just turn python wrapping off, it will also be green again. I will do that if we refuse to accept the change I've proposed in gerrit.<br>
<br>
I don't think moving it away is the right response when it was green before.....<br>
<br>
It was working on March 25th. Changes merged to master that day broke it for March 26th's dashboard. I object to moving it away and sweeping this under the rug. It's a recent break in the VTK master code base, it is not an intractable problem with ninja.<br>
<br>
If ninja is not officially supported for VTK, then I'll move it to an "NMake" or "jom" driven dashboard. I think it's ridiculous *not* to support ninja when it's clearly viable and provides the fastest possible build times on Windows.<div>
<div><br>
<br>
<br>
<br>
-----Original Message-----<br>
From: Berk Geveci <<a href="mailto:berk.geveci@kitware.com" target="_blank">berk.geveci@kitware.com</a>><br>
To: VTK Developers <<a href="mailto:vtk-developers@vtk.org" target="_blank">vtk-developers@vtk.org</a>><br>
Sent: Mon, Apr 1, 2013 11:53 am<br>
Subject: [vtk-developers] Moved Mirkwood ninja dashboards to nightly<br>
<br>
<br>
Hi folks,<br>
<br>
<br>
I just moved the Mirkwood ninja dashboards from Nightly Expected to Nightly. If someone wants to fix the ninja build issues, great. But having them in Nightly Expected is not helping us clean the dashboard. As far as I am concerned, VTK ninja builds are not officially supported.<br>
<br>
<br>
-berk<br>
<br>
<br></div></div>
______________________________<u></u>_________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/<u></u>opensource/opensource.html</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/<u></u>listinfo/vtk-developers</a><br>
<br>
<br>
______________________________<u></u>_________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/<u></u>opensource/opensource.html</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/<u></u>listinfo/vtk-developers</a><br>
<br>
</blockquote></div><br><br clear="all"><br></div></div><span><font color="#888888">-- <br>Unpaid intern in BillsBasement at noware dot com<br>
</font></span></div>
</blockquote></div><br><br clear="all"><br>-- <br>Unpaid intern in BillsBasement at noware dot com<br>
</div>
</div></div><br>_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
<br>
<br></blockquote></div><br></div></div>