<div dir="ltr">Yeah and above all don't feel bad about it Sean. That's what the nightlies are for - as long as we collectively catch and fix problems before they get lodged and start to accumulate the process is working.<div>
<br><div>Having a 100% clean nightly is not going to happen, probably even with a next/master workflow like ParaView has (although that would bring us closer to that "guarantee").</div><div><div><br></div></div>
</div></div><div class="gmail_extra"><br clear="all"><div>David E DeMarle<br>Kitware, Inc.<br>R&D Engineer<br>21 Corporate Drive<br>Clifton Park, NY 12065-8662<br>Phone: 518-881-4909</div>
<br><br><div class="gmail_quote">On Thu, Mar 21, 2013 at 11:15 AM, David Cole <span dir="ltr"><<a href="mailto:dlrdave@aol.com" target="_blank">dlrdave@aol.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><div style="font-family:Calibri,'Segoe UI',Meiryo,'Microsoft YaHei UI','Microsoft JhengHei UI','Malgun Gothic','Khmer UI','Nirmala UI',Tunga,'Lao UI',Ebrima,sans-serif;font-size:16px">
<div>Also in Sean’s defense: all he did was make some static methods explicitly static... what could go wrong? <span style="font-family:"Segoe UI Symbol","Apple Color Emoji"">😉</span></div><div> </div>
<div>And: it’s all just the same warnings over and over, with the one silly compiler complaining that nobody would have caught before merging anyhow.</div><div> </div><div>And: they’re all fixed already. Tomorrow will be blissful again.</div>
<div> </div><div> </div><div>D</div><div> </div><div> </div> <div style="border-top-color:rgb(225,225,225);border-top-width:1px;border-top-style:solid"> <strong>From:</strong> Sean McBride<br> <strong>Sent:</strong> March 21, 2013 11:10 AM<br>
<strong>To:</strong> Berk Geveci; VTK Developers<br> <strong>Subject:</strong> Re: [vtk-developers] Dashboard<br> </div> <div> </div><div><div class="h5">On Thu, 21 Mar 2013 09:54:40 -0400, Berk Geveci said:<br><br>>I just took a look at the dashboard. Yikes! It looks like some of the<br>
>changes that were attempting to fix errors/warnings caused wide spread<br>>warnings/errors :-)<br><br>Yup. Sorry about that!! But in my defence:<br> - the gerrit builds were totally green<br> - the AIX compiler is wrong<br>
- it passed peer review<br> - many nightly buildbots seem to have stronger warning<br> settings vs the gerrit CDash@Home machines<br><br>I didn't personally catch it because I was working on fixing instances of one particular warning, so it was the only warning I had turned on. :(<br>
<br>To prevent this in the future:<br> - I'll be even more careful.<br> - I'll be making a CDash@Home machine with torturous settings<br> - we need a Windows gerrit buildbot!<br> - we should increase the warnings on the gerrit buildbots<br>
<br><br>On Thu, 21 Mar 2013 10:24:51 -0400, Kyle Lutz said:<br><br>>And Sean, in the future, could you mark me as a reviewer for these<br>>types of patches.<br><br>Will do. It's hard to know who to add as reviewers. I usually use git blame, or add a random Dave. :)<br>
<br>Cheers,<br><br>-- <br>____________________________________________________________<br>Sean McBride, B. Eng <a href="mailto:sean@rogue-research.com" target="_blank">sean@rogue-research.com</a><br>Rogue Research <a href="http://www.rogue-research.com" target="_blank">www.rogue-research.com</a> <br>
Mac Software Developer Montréal, Québec, Canada<br><br><br>_______________________________________________<br>Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br><br>Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>Follow this link to subscribe/unsubscribe:<br><a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br><br></div></div></div></div><br>_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
<br>
<br></blockquote></div><br></div>