<html><head><style data-externalstyle="true">
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph {
margin-top:0in;
margin-right:0in;
margin-bottom:0in;
margin-left:.5in;
margin-bottom:.0001pt;
}
p.MsoListParagraphCxSpFirst, li.MsoListParagraphCxSpFirst, div.MsoListParagraphCxSpFirst, p.MsoListParagraphCxSpMiddle, li.MsoListParagraphCxSpMiddle, div.MsoListParagraphCxSpMiddle, p.MsoListParagraphCxSpLast, li.MsoListParagraphCxSpLast, div.MsoListParagraphCxSpLast {
margin-top:0in;
margin-right:0in;
margin-bottom:0in;
margin-left:.5in;
margin-bottom:.0001pt;
line-height:115%;
}
</style></head><body><div data-externalstyle="false" style="font-family:Calibri,'Segoe UI',Meiryo,'Microsoft YaHei UI','Microsoft JhengHei UI','Malgun Gothic','Khmer UI','Nirmala UI',Tunga,'Lao UI',Ebrima,sans-serif;font-size:16px;"><div>Also in Sean’s defense: all he did was make some static methods explicitly static... what could go wrong? <span style='font-family: "Segoe UI Symbol","Apple Color Emoji";' data-externalstyle="false">😉</span></div><div> </div><div data-focusfrompointer="true">And: it’s all just the same warnings over and over, with the one silly compiler complaining that nobody would have caught before merging anyhow.</div><div> </div><div>And: they’re all fixed already. Tomorrow will be blissful again.</div><div> </div><div> </div><div>D</div><div> </div><div data-signatureblock="true"> </div> <div style="border-top-color: rgb(225, 225, 225); border-top-width: 1px; border-top-style: solid;"> <strong>From:</strong> Sean McBride<br> <strong>Sent:</strong> March 21, 2013 11:10 AM<br> <strong>To:</strong> Berk Geveci; VTK Developers<br> <strong>Subject:</strong> Re: [vtk-developers] Dashboard<br> </div> <div> </div>On Thu, 21 Mar 2013 09:54:40 -0400, Berk Geveci said:<br><br>>I just took a look at the dashboard. Yikes! It looks like some of the<br>>changes that were attempting to fix errors/warnings caused wide spread<br>>warnings/errors :-)<br><br>Yup. Sorry about that!! But in my defence:<br> - the gerrit builds were totally green<br> - the AIX compiler is wrong<br> - it passed peer review<br> - many nightly buildbots seem to have stronger warning<br> settings vs the gerrit CDash@Home machines<br><br>I didn't personally catch it because I was working on fixing instances of one particular warning, so it was the only warning I had turned on. :(<br><br>To prevent this in the future:<br> - I'll be even more careful.<br> - I'll be making a CDash@Home machine with torturous settings<br> - we need a Windows gerrit buildbot!<br> - we should increase the warnings on the gerrit buildbots<br><br><br>On Thu, 21 Mar 2013 10:24:51 -0400, Kyle Lutz said:<br><br>>And Sean, in the future, could you mark me as a reviewer for these<br>>types of patches.<br><br>Will do. It's hard to know who to add as reviewers. I usually use git blame, or add a random Dave. :)<br><br>Cheers,<br><br>-- <br>____________________________________________________________<br>Sean McBride, B. Eng sean@rogue-research.com<br>Rogue Research www.rogue-research.com <br>Mac Software Developer Montréal, Québec, Canada<br><br><br>_______________________________________________<br>Powered by www.kitware.com<br><br>Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html<br><br>Follow this link to subscribe/unsubscribe:<br>http://www.vtk.org/mailman/listinfo/vtk-developers<br><br></div></body></html>