I suggest, add the modified the TestOffAxis test with a larger separation to your topic and we can see what the results look like on all three gerrit builds.<br><br><br><div class="gmail_quote">On Fri, Feb 22, 2013 at 1:15 PM, Bill Lorensen <span dir="ltr"><<a href="mailto:bill.lorensen@gmail.com" target="_blank">bill.lorensen@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Aashish,<br><br>I think you are right. The eye separation should be larger. If you follow the 1/30th rule: "the interaxial separation should only be 1/30<sup>th</sup> of the distance from your camera to the closest subject"<br>
then a separation of .4 to .5 should give a reasonable image. And it does.<span class="HOEnZb"><font color="#888888"><br><br>Bill</font></span><div class="HOEnZb"><div class="h5"><br><br><div class="gmail_quote">On Fri, Feb 22, 2013 at 12:27 PM, Aashish Chaudhary <span dir="ltr"><<a href="mailto:aashish.chaudhary@kitware.com" target="_blank">aashish.chaudhary@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>On Fri, Feb 22, 2013 at 12:08 PM, Bill Lorensen <<a href="mailto:bill.lorensen@gmail.com" target="_blank">bill.lorensen@gmail.com</a>> wrote:<br>
> Your recent patch fixes the SplitView test, but breaks the OffAxis test. Any<br>
> ideas?<br>
<br>
</div>I looked into the parameters, I think the baseline image is incorrect.<br>
I have to verify this but I am 80% sure. The spheres in the test are<br>
behind the projected wall and should not have this much eye<br>
separation.<br>
<div><div><br>
><br>
><br>
> On Thu, Feb 21, 2013 at 10:46 AM, Aashish Chaudhary<br>
> <<a href="mailto:aashish.chaudhary@kitware.com" target="_blank">aashish.chaudhary@kitware.com</a>> wrote:<br>
>><br>
>> On Thu, Feb 21, 2013 at 10:41 AM, Bill Lorensen <<a href="mailto:bill.lorensen@gmail.com" target="_blank">bill.lorensen@gmail.com</a>><br>
>> wrote:<br>
>> > I did some experiments last night and I don't think these changes will<br>
>> > help.<br>
>> > Aashish any luck? I noticed you removed the old baselines. I think you<br>
>> > should have, just temporarily, added a new baseline for your changes<br>
>> > that<br>
>> > are not yet merged. Now we have even more failing tests.<br>
>><br>
>> Yes, after I fixed window to image filter, at least on my two systems<br>
>> the results were consistent. I will push a branch later in the day.<br>
>><br>
>><br>
>> ><br>
>> ><br>
>> > On Wed, Feb 20, 2013 at 5:34 PM, David Gobbi <<a href="mailto:david.gobbi@gmail.com" target="_blank">david.gobbi@gmail.com</a>><br>
>> > wrote:<br>
>> >><br>
>> >> I will be overjoyed if this also fixes volTM2DRotateClip as a<br>
>> >> side-effect.<br>
>> >><br>
>> >> - David<br>
>> >><br>
>> >> On Wed, Feb 20, 2013 at 3:26 PM, Bill Lorensen<br>
>> >> <<a href="mailto:bill.lorensen@gmail.com" target="_blank">bill.lorensen@gmail.com</a>><br>
>> >> wrote:<br>
>> >> > Nice catch!<br>
>> >> ><br>
>> >> > On Wed, Feb 20, 2013 at 5:25 PM, Aashish Chaudhary<br>
>> >> > <<a href="mailto:aashish.chaudhary@kitware.com" target="_blank">aashish.chaudhary@kitware.com</a>> wrote:<br>
>> >> >> To be specific the code is here:<br>
>> >> >><br>
>> >> >> void vtkWindowToImageFilter::RequestData<br>
>> >> >><br>
>> >> >> Which gets executed by vtkTesting<br>
>> >> >><br>
>> >> >> Thanks,<br>
>> >> >><br>
>> >> >><br>
>> >> >> On Wed, Feb 20, 2013 at 5:23 PM, Aashish Chaudhary<br>
>> >> >> <<a href="mailto:aashish.chaudhary@kitware.com" target="_blank">aashish.chaudhary@kitware.com</a>> wrote:<br>
>> >> >>> Ok, I found the issue..it was the vtkTesting, Basically there it<br>
>> >> >>> creates a new camera and line by line copies the member variables<br>
>> >> >>> (I<br>
>> >> >>> don't know why we just deep copy the cameras).<br>
>> >> >>><br>
>> >> >>> There it was missing copying off screen parameters. I will push a<br>
>> >> >>> fix<br>
>> >> >>> tomorrow (need to leave very soon). Along with that I will push<br>
>> >> >>> fixes<br>
>> >> >>> to shallow copy as well.<br>
>> >> >>><br>
>> >> >>> Thanks<br>
>> >> >>><br>
>> >> >>><br>
>> >> >>> On Wed, Feb 20, 2013 at 4:45 PM, Aashish Chaudhary<br>
>> >> >>> <<a href="mailto:aashish.chaudhary@kitware.com" target="_blank">aashish.chaudhary@kitware.com</a>> wrote:<br>
>> >> >>>> Thanks David. PartialCopy has issues but it seems like that's not<br>
>> >> >>>> the<br>
>> >> >>>> problem. Basically all of the camera parameters are same before<br>
>> >> >>>> and<br>
>> >> >>>> after.<br>
>> >> >>>><br>
>> >> >>>> Thanks,<br>
>> >> >>>><br>
>> >> >>>><br>
>> >> >>>> On Wed, Feb 20, 2013 at 4:12 PM, David Gobbi<br>
>> >> >>>> <<a href="mailto:david.gobbi@gmail.com" target="_blank">david.gobbi@gmail.com</a>><br>
>> >> >>>> wrote:<br>
>> >> >>>>> Look at PartialCopy(), make sure it isn't missing anything.<br>
>> >> >>>>><br>
>> >> >>>>> - David<br>
>> >> >>>>><br>
>> >> >>>>><br>
>> >> >>>>> On Wed, Feb 20, 2013 at 2:02 PM, Aashish Chaudhary<br>
>> >> >>>>> <<a href="mailto:aashish.chaudhary@kitware.com" target="_blank">aashish.chaudhary@kitware.com</a>> wrote:<br>
>> >> >>>>>> Ok, I found something interesting, these settings are gone<br>
>> >> >>>>>> inside<br>
>> >> >>>>>> the<br>
>> >> >>>>>> call to vtkRegressionTestImageThreshold<br>
>> >> >>>>>><br>
>> >> >>>>>> camera->SetScreenBottomLeft(bottomLeft);<br>
>> >> >>>>>> camera->SetScreenBottomRight(bottomRight);<br>
>> >> >>>>>> camera->SetScreenTopRight(topRight);<br>
>> >> >>>>>><br>
>> >> >>>>>> And that's causing it create different images. I don't know the<br>
>> >> >>>>>> exact<br>
>> >> >>>>>> reason yet but this is a progress.<br>
>> >> >>>>>><br>
>> >> >>>>>> Thanks,<br>
>> >> >>>>>><br>
>> >> >>>>>><br>
>> >> >>>>>> On Wed, Feb 20, 2013 at 3:49 PM, Aashish Chaudhary<br>
>> >> >>>>>> <<a href="mailto:aashish.chaudhary@kitware.com" target="_blank">aashish.chaudhary@kitware.com</a>> wrote:<br>
>> >> >>>>>>> On Wed, Feb 20, 2013 at 3:36 PM, Bill Lorensen<br>
>> >> >>>>>>> <<a href="mailto:bill.lorensen@gmail.com" target="_blank">bill.lorensen@gmail.com</a>> wrote:<br>
>> >> >>>>>>>> Thanks for looking at this, but unfortunately, the mac and pc<br>
>> >> >>>>>>>> images<br>
>> >> >>>>>>>> do not look the same.<br>
>> >> >>>>>>><br>
>> >> >>>>>>> Yeah.. I realized the same. It seems like windows is capturing<br>
>> >> >>>>>>> the<br>
>> >> >>>>>>> scene after first render and mac / linux captured that it<br>
>> >> >>>>>>> should<br>
>> >> >>>>>>> be<br>
>> >> >>>>>>> after second render. I guess<br>
>> >> >>>>>>> I can try to setup camera parameters before hand and see if<br>
>> >> >>>>>>> that<br>
>> >> >>>>>>> prevents this behavior.<br>
>> >> >>>>>>><br>
>> >> >>>>>>> Thanks<br>
>> >> >>>>>>><br>
>> >> >>>>>>>><br>
>> >> >>>>>>>> On Wed, Feb 20, 2013 at 2:27 PM, Aashish Chaudhary<br>
>> >> >>>>>>>> <<a href="mailto:aashish.chaudhary@kitware.com" target="_blank">aashish.chaudhary@kitware.com</a>> wrote:<br>
>> >> >>>>>>>>> Bill,<br>
>> >> >>>>>>>>><br>
>> >> >>>>>>>>> I pushed a branch and hoping that it will fix the issue<br>
>> >> >>>>>>>>> atleast<br>
>> >> >>>>>>>>> on mac<br>
>> >> >>>>>>>>> and linux. I may have to check for stereo support but I will<br>
>> >> >>>>>>>>> for<br>
>> >> >>>>>>>>> that.<br>
>> >> >>>>>>>>><br>
>> >> >>>>>>>>> I will keep an eye on the dashboards, in the mean time please<br>
>> >> >>>>>>>>> review my branch.<br>
>> >> >>>>>>>>><br>
>> >> >>>>>>>>> Thanks<br>
>> >> >>>>>>>>><br>
>> >> >>>>>>>>><br>
>> >> >>>>>>>>> On Tue, Feb 19, 2013 at 11:24 AM, Aashish Chaudhary<br>
>> >> >>>>>>>>> <<a href="mailto:aashish.chaudhary@kitware.com" target="_blank">aashish.chaudhary@kitware.com</a>> wrote:<br>
>> >> >>>>>>>>>> Bill,<br>
>> >> >>>>>>>>>><br>
>> >> >>>>>>>>>> I will have a look at it today.<br>
>> >> >>>>>>>>>><br>
>> >> >>>>>>>>>> Thanks,<br>
>> >> >>>>>>>>>><br>
>> >> >>>>>>>>>><br>
>> >> >>>>>>>>>> On Mon, Feb 18, 2013 at 11:55 AM, Bill Lorensen<br>
>> >> >>>>>>>>>> <<a href="mailto:bill.lorensen@gmail.com" target="_blank">bill.lorensen@gmail.com</a>> wrote:<br>
>> >> >>>>>>>>>>> Aashish,<br>
>> >> >>>>>>>>>>><br>
>> >> >>>>>>>>>>> TestSplitViewportStereoHorizontal is the only test failing<br>
>> >> >>>>>>>>>>> on<br>
>> >> >>>>>>>>>>> the Mac<br>
>> >> >>>>>>>>>>> Gerrit build (and all OSX systems). It would be great to<br>
>> >> >>>>>>>>>>> have<br>
>> >> >>>>>>>>>>> it<br>
>> >> >>>>>>>>>>> fixed. David Gobbi fixed some failures of this test in this<br>
>> >> >>>>>>>>>>> gerrit<br>
>> >> >>>>>>>>>>> patch: <a href="http://review.source.kitware.com/#/c/9747/" target="_blank">http://review.source.kitware.com/#/c/9747/</a><br>
>> >> >>>>>>>>>>><br>
>> >> >>>>>>>>>>> If you try to fix it, please make sure you update to master<br>
>> >> >>>>>>>>>>> before<br>
>> >> >>>>>>>>>>> doing any work.<br>
>> >> >>>>>>>>>>><br>
>> >> >>>>>>>>>>> Thanks,<br>
>> >> >>>>>>>>>>><br>
>> >> >>>>>>>>>>> Bill<br>
>> >> >>>>>>>>>><br>
>> >> >>>>>>>>>><br>
>> >> >>>>>>>>>><br>
>> >> >>>>>>>>>> --<br>
>> >> >>>>>>>>>> | Aashish Chaudhary<br>
>> >> >>>>>>>>>> | R&D Engineer<br>
>> >> >>>>>>>>>> | Kitware Inc.<br>
>> >> >>>>>>>>>> | <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
>> >> >>>>>>>>><br>
>> >> >>>>>>>>><br>
>> >> >>>>>>>>><br>
>> >> >>>>>>>>> --<br>
>> >> >>>>>>>>> | Aashish Chaudhary<br>
>> >> >>>>>>>>> | R&D Engineer<br>
>> >> >>>>>>>>> | Kitware Inc.<br>
>> >> >>>>>>>>> | <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
>> >> >>>>>>>><br>
>> >> >>>>>>>><br>
>> >> >>>>>>>><br>
>> >> >>>>>>>> --<br>
>> >> >>>>>>>> Unpaid intern in BillsBasement at noware dot com<br>
>> >> >>>>>>><br>
>> >> >>>>>>><br>
>> >> >>>>>>><br>
>> >> >>>>>>> --<br>
>> >> >>>>>>> | Aashish Chaudhary<br>
>> >> >>>>>>> | R&D Engineer<br>
>> >> >>>>>>> | Kitware Inc.<br>
>> >> >>>>>>> | <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
>> >> >>>>>><br>
>> >> >>>>>><br>
>> >> >>>>>><br>
>> >> >>>>>> --<br>
>> >> >>>>>> | Aashish Chaudhary<br>
>> >> >>>>>> | R&D Engineer<br>
>> >> >>>>>> | Kitware Inc.<br>
>> >> >>>>>> | <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
>> >> >>>>>> _______________________________________________<br>
>> >> >>>>>> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
>> >> >>>>>><br>
>> >> >>>>>> Visit other Kitware open-source projects at<br>
>> >> >>>>>> <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
>> >> >>>>>><br>
>> >> >>>>>> Follow this link to subscribe/unsubscribe:<br>
>> >> >>>>>> <a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
>> >> >>>>>><br>
>> >> >>>><br>
>> >> >>>><br>
>> >> >>>><br>
>> >> >>>> --<br>
>> >> >>>> | Aashish Chaudhary<br>
>> >> >>>> | R&D Engineer<br>
>> >> >>>> | Kitware Inc.<br>
>> >> >>>> | <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
>> >> >>><br>
>> >> >>><br>
>> >> >>><br>
>> >> >>> --<br>
>> >> >>> | Aashish Chaudhary<br>
>> >> >>> | R&D Engineer<br>
>> >> >>> | Kitware Inc.<br>
>> >> >>> | <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
>> >> >><br>
>> >> >><br>
>> >> >><br>
>> >> >> --<br>
>> >> >> | Aashish Chaudhary<br>
>> >> >> | R&D Engineer<br>
>> >> >> | Kitware Inc.<br>
>> >> >> | <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
>> >> ><br>
>> >> ><br>
>> >> ><br>
>> >> > --<br>
>> >> > Unpaid intern in BillsBasement at noware dot com<br>
>> ><br>
>> ><br>
>> ><br>
>> ><br>
>> > --<br>
>> > Unpaid intern in BillsBasement at noware dot com<br>
>><br>
>><br>
>><br>
>> --<br>
>> | Aashish Chaudhary<br>
>> | R&D Engineer<br>
>> | Kitware Inc.<br>
>> | <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
><br>
><br>
><br>
><br>
> --<br>
> Unpaid intern in BillsBasement at noware dot com<br>
<br>
<br>
<br>
--<br>
| Aashish Chaudhary<br>
| R&D Engineer<br>
| Kitware Inc.<br>
| <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>Unpaid intern in BillsBasement at noware dot com<br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>Unpaid intern in BillsBasement at noware dot com<br>