<p>+1 :-)</p>
<p>--<br>
Sent from my mobile device</p>
<div class="gmail_quote">On Feb 18, 2013 10:30 AM, "David Cole" <<a href="mailto:dlrdave@aol.com">dlrdave@aol.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<font color="black" face="arial">A<font><font>n</font>d yet it<font> w<font>ill be</font></font> closer to true than it has been, once we start insi<font>sting on <font>green CDash@home submissions *before* merging to master.<br>
<br>
<font>The fact is, as a community, we app<font>ear to have "<font>given up" on the VTK dashboard many months ago. We pick and choose which problems to address as indivi<font>duals rather than insisting on staying clean as a group.</font><br>
<br>
<font>I know there are <font>reasons why that happens that are beyond the control of individuals in the communi<font>ty, but we as a g<font>roup</font> shouldn't allow it to become the status quo.<br>
<br>
</font></font></font><font>I'm very happy to see a renewe<font>d in<font>tere<font>s</font>t in cleaning thi<font>n<font>g</font>s up lately.</font></font></font></font> And also to be <font>part of the change I wish to see in this world... ;-)</font><br>
</font></font></font></font></font></font><font color="black" face="arial">
<div> <br>
<br>
</div>
<div> Cheers,<br>
<font>D.<br>
<br>
</font>
</div>
<div> <br>
</div>
<div style="font-size:10pt;font-family:arial,helvetica">-----Original Message-----<br>
From: Utkarsh Ayachit <<a href="mailto:utkarsh.ayachit@kitware.com" target="_blank">utkarsh.ayachit@kitware.com</a>><br>
To: David Cole <<a href="mailto:dlrdave@aol.com" target="_blank">dlrdave@aol.com</a>><br>
Cc: Pat Marion <<a href="mailto:pat.marion@kitware.com" target="_blank">pat.marion@kitware.com</a>>; vtk-developers <<a href="mailto:vtk-developers@vtk.org" target="_blank">vtk-developers@vtk.org</a>><br>
Sent: Mon, Feb 18, 2013 10:18 am<br>
Subject: Re: [vtk-developers] Continuous Build Defect Process<br>
<br>
<div style="font-size:12px;font-family:Tahoma,Verdana,Arial,Sans-Serif;margin:0px">
<pre style="font-size:9pt"><tt>That's only really true if *all* dashboard run on CDash@Home. As long
as there is at least one Dashboard machine that doesn't run CDash@home
there's a possibility that the a commit that causes tests to fail in
some esoteric configuration/system will make it into master. Given
that there are 3 machines/configurations on CDash@home and a lot more
than that on VTK nightlies, we have a problem. Although I am not
advocating next/master for VTK, it's a lot of work, it's still a good
mental exercise :).
On Mon, Feb 18, 2013 at 10:04 AM, David Cole <<a href="mailto:dlrdave@aol.com" target="_blank">dlrdave@aol.com</a>> wrote:
> You could consider gerrit as a sort of next... even though it's not a single
> named/shared branch, it's a similar thing conceptually. Stuff doesn't get
> merged to master till it passes the 'next' gauntlet (gerrit code review and
> CDash@home dashboards for VTK). Passing that means convincing peers, and
> making dashboards green.
>
>
>
> -----Original Message-----
> From: Pat Marion <<a href="mailto:pat.marion@kitware.com" target="_blank">pat.marion@kitware.com</a>>
> To: David Cole <<a href="mailto:dlrdave@aol.com" target="_blank">dlrdave@aol.com</a>>
> Cc: bill.lorensen <<a href="mailto:bill.lorensen@gmail.com" target="_blank">bill.lorensen@gmail.com</a>>; vtk-developers
> <<a href="mailto:vtk-developers@vtk.org" target="_blank">vtk-developers@vtk.org</a>>
> Sent: Mon, Feb 18, 2013 2:52 am
> Subject: Re: [vtk-developers] Continuous Build Defect Process
>
> To clarify, I meant a next/master branch model *in addition* to code review,
> not as replacement.
>
> Pat
>
> On Mon, Feb 18, 2013 at 2:02 PM, David Cole <<a href="mailto:dlrdave@aol.com" target="_blank">dlrdave@aol.com</a>> wrote:
>>
>> Developer diligence is always required regardless of your workflow or
>> development model.
>>
>> I would tend to lean more toward Bill's statement than Pat's.
>>
>> With the CDash@home actually green (very soon, very soon) it should be an
>> automatic reason to reject a topic if it introduces warnings, errors or test
>> failures on the CDash@home dashboards.
>>
>> Even after merging to master, dashboard observation is required to verify
>> that it didn't break anything on an as-yet-untested combination of platforms
>> and options.
>>
>>
>> D
>>
>>
>> -----Original Message-----
>> From: Bill Lorensen <<a href="mailto:bill.lorensen@gmail.com" target="_blank">bill.lorensen@gmail.com</a>>
>> To: Pat Marion <<a href="mailto:pat.marion@kitware.com" target="_blank">pat.marion@kitware.com</a>>
>> Cc: VTK Developers <<a href="mailto:vtk-developers@vtk.org" target="_blank">vtk-developers@vtk.org</a>>
>> Sent: Sun, Feb 17, 2013 7:12 pm
>> Subject: Re: [vtk-developers] Continuous Build Defect Process
>>
>> I do not see how next/master is better than a good gerrit review.
>>
>> On Sunday, February 17, 2013, Pat Marion wrote:
>>>
>>> This is great, Bill. Thanks to everyone who helped out!
>>>
>>> The statement on the wiki "Once reduced to 0, developer diligence is
>>> needed to keep the defects to 0. The burden is on the Gerrit reviewers" I
>>> agree with the first statement, but not the second. I think that the best
>>> way to keep the number at 0 is to have a next & master branch model.
>>>
>>> Pat
>>>
>>> On Sat, Feb 16, 2013 at 6:15 AM, Bill Lorensen <<a href="mailto:bill.lorensen@gmail.com" target="_blank">bill.lorensen@gmail.com</a>>
>>> wrote:
>>>>
>>>> Folks,
>>>>
>>>> Some of you may be interested in the process we used to reduce the
>>>> Continuous build defects to 0:
>>>> <a href="http://itk.org/Wiki/VTK/SoftwareQuality/ContinuousBuildTestFailures" target="_blank">http://itk.org/Wiki/VTK/SoftwareQuality/ContinuousBuildTestFailures</a>
>>>>
>>>> Thanks to all who contributed gerrit topics.
>>>>
>>>> Bill
>>>> _______________________________________________
>>>> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a>
>>>>
>>>> Visit other Kitware open-source projects at
>>>> <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a>
>>>>
>>>> Follow this link to subscribe/unsubscribe:
>>>> <a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a>
>>>>
>>>
>>
>>
>> --
>> Unpaid intern in BillsBasement at noware dot com
>>
>> _______________________________________________
>> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a>
>>
>> Visit other Kitware open-source projects at
>> <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a>
>>
>> Follow this link to subscribe/unsubscribe:
>> <a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a>
>>
>
>
> _______________________________________________
> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a>
>
> Visit other Kitware open-source projects at
> <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a>
>
> Follow this link to subscribe/unsubscribe:
> <a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a>
>
>
</tt></pre>
</div>
</div>
</font></font><br>_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
<br>
<br></blockquote></div>