<font color='black' size='2' face='arial'>It <font size="2">would be good to <font size="2">be robust against this sort of problem for comparing text file test result<font size="2">s.<br>
<br>
<font size="2">Seems crazy in this day and age to have to write code<font size="2"> just to compare files</font></font>.</font></font></font><font size="2" color="black" face="arial"> All you want is "di<font size="2">ff -w" but built into Windows, too<font size="2">. Oh well.<br>
<br>
<font size="2">Good to see your<font size="2"> p<font size="2">rogress on the VTK dashboard these last couple weeks. I really appreciate it.<br>
<br>
<font size="2">Thank<font size="2"> you a thousand times!<br>
<br>
<br>
<font size="2">D<br>
<br>
</font></font></font></font></font></font></font></font>
<div> <br>
</div>
<div> <br>
</div>
<div style="font-family:arial,helvetica;font-size:10pt;color:black">-----Original Message-----<br>
From: Bill Lorensen <bill.lorensen@gmail.com><br>
To: David Cole <dlrdave@aol.com><br>
Cc: brad.king <brad.king@kitware.com>; vtk-developers <vtk-developers@vtk.org><br>
Sent: Fri, Feb 8, 2013 4:08 pm<br>
Subject: Re: [vtk-developers] Comparing ascii files with kwsys::FilesDiffer<br>
<br>
<div id="AOLMsgPart_0_d25c3350-6317-483f-8190-f30b48b5d8f6" style="margin: 0px;font-family: Tahoma, Verdana, Arial, Sans-Serif;font-size: 12px;color: #000;background-color: #fff;">
<pre style="font-size: 9pt;"><tt>Well, since I don't have control over that, I'll probably just write a
few lines of code to compare the ascii files.
Afterall, we are supposed to get snowed in this weekend.
Bill
On Fri, Feb 8, 2013 at 4:01 PM, David Cole <<a href="mailto:dlrdave@aol.com">dlrdave@aol.com</a>> wrote:
> We don't.
>
> Somebody with access to the machines in question should verify and fix, if
> possible, without any code changes.
>
>
>
> -----Original Message-----
> From: Bill Lorensen <<a href="mailto:bill.lorensen@gmail.com">bill.lorensen@gmail.com</a>>
> To: David Cole <<a href="mailto:dlrdave@aol.com">dlrdave@aol.com</a>>
> Cc: brad.king <<a href="mailto:brad.king@kitware.com">brad.king@kitware.com</a>>; vtk-developers
> <<a href="mailto:vtk-developers@vtk.org">vtk-developers@vtk.org</a>>
> Sent: Fri, Feb 8, 2013 3:57 pm
> Subject: Re: [vtk-developers] Comparing ascii files with kwsys::FilesDiffer
>
> Dave,
>
> How do we fix that? I don't have access to those machines.
>
> Bill
>
> On Fri, Feb 8, 2013 at 3:35 PM, David Cole <<a href="mailto:dlrdave@aol.com">dlrdave@aol.com</a>> wrote:
>> Before writing a bunch of code.... verify that the git auto-convert
>> setting
>> for pulling files into the working tree is the same for both VTK and
>> VTKData
>> on the machines in question.
>>
>> Looks like the VTKData file is the one missing the CRs (has fewer bytes)
>> --
>> makes me think the git setting is wrong for the VTKData checkout.
>>
>>
>>
>> -----Original Message-----
>> From: Brad King <<a href="mailto:brad.king@kitware.com">brad.king@kitware.com</a>>
>> To: Bill Lorensen <<a href="mailto:bill.lorensen@gmail.com">bill.lorensen@gmail.com</a>>
>> Cc: VTK Developers <<a href="mailto:vtk-developers@vtk.org">vtk-developers@vtk.org</a>>
>> Sent: Fri, Feb 8, 2013 3:31 pm
>> Subject: Re: [vtk-developers] Comparing ascii files with
>> kwsys::FilesDiffer
>>
>> On 02/08/2013 03:26 PM, Bill Lorensen wrote:
>>> The test compares two ASCII files. The difference is because (some,
>>> but not all) windows systems handle newline differently than linux and
>>> mac os.
>>
>> The SystemTools::FilesDiffer method was originally added for CMake's
>> configure_file command to decide whether to replace a file with a new
>> version or to not replace it because the configured result is the same.
>> In this use case both files are produced the same way so newlines match.
>> That's why we haven't covered this before.
>>
>>> In the link you can see that the contents of the two files "look" the
>>> same, but the lengths of the two files is different and
>>> vtksys::FilesDiffer reports they are different. That's because some
>>> windows systems use a CR/LF character for newline while the linux
>>> systems use LF.
>>>
>>> How to solve this? I could add a FileDiff program to the test that
>>> uses getline to compare the two files.
>>
>> We don't use FilesDiffer to compare test images to baselines because
>> there can be pixel-fuzz differences and such. Text file comparison
>> may have various tolerances other than just newlines and we will not
>> be able to cover them all in FilesDiffer. Therefore I think VTK
>> should have its own comparison tool for text files just like it does
>> for images.
>>
>> -Brad
>> _______________________________________________
>> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a>
>>
>> Visit other Kitware open-source projects at
>> <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a>
>>
>> Follow this link to subscribe/unsubscribe:
>> <a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a>
>>
>
>
>
> --
> Unpaid intern in BillsBasement at noware dot com
--
Unpaid intern in BillsBasement at noware dot com
</tt></pre>
</div>
<!-- end of AOLMsgPart_0_d25c3350-6317-483f-8190-f30b48b5d8f6 -->
</div>
</font><br>
</font>