Hello Trevor<br><br>Agreed. I am going to look at your patch in detail tomorrow ok?<br><br>Tonight I am merging a last batch of additions to the hyper tree grid, after which it should remain stable for a while. I agree that at this point it would be imprudent to rebase your work on the hyper tree grid stuff, until it stabilizes for good. <br>
<br>Philippe<br><br><div class="gmail_quote">On Fri, Jan 25, 2013 at 11:25 PM, Trevor Irons <span dir="ltr"><<a href="mailto:trevorirons@gmail.com" target="_blank">trevorirons@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Thanks. Two quick points<br><br>a) I will happily adopt a more flexible Octree class. That is great. <br><br>b) In the mean time, I would really like to get some kind of true deep copy pushed into VTK for the HyperOctree Class. I certainly consider this a bug. I realize parts of my patch are a little kludgy (mainly the static_cast) but the vtkHyperOctree class already had a fair bit of this, so I was pretty consistent with the existing codebase. I'm terrified of having to maintain my branch during such a dynamic development phase in VTK. My application relies on making deep copies of these objects.<br>
<br>Thanks so much.<span class="HOEnZb"><font color="#888888"><br><br clear="all"><div>-- Trevor<br></div></font></span><div class="HOEnZb"><div class="h5">
<br><br><div class="gmail_quote">On 25 January 2013 14:29, Philippe Pébay <span dir="ltr"><<a href="mailto:philippe.pebay@kitware.com" target="_blank">philippe.pebay@kitware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hello Trevor,<br><br>Yes indeed, because I have not yet written a replacement for this class. I need to look into it. In the meantime I am attaching a paper which we wrote for the 21st International Meshing Roundtable and that explains several aspects of the hyper tree grid.<br>
<br>Best,<br>Philippe<div><div><br><br><div class="gmail_quote">On Thu, Jan 24, 2013 at 5:22 PM, Trevor Irons <span dir="ltr"><<a href="mailto:trevorirons@gmail.com" target="_blank">trevorirons@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Thanks Philippe. I was unaware of the vtkHyperTreeGrid class. I am currently making use of the <a href="http://www.vtk.org/doc/nightly/html/classvtkHyperOctreeSampleFunction.html" target="_blank">vtkHyperOctreeSampleFunction</a> method right now, which would seem to preclude me from migrating to your newer class for the time being. Is this accurate?<span><font color="#888888"><br>
<br>
<br clear="all"><div>-- Trevor<br></div></font></span><div><div>
<br><br><div class="gmail_quote">On 24 January 2013 08:50, Philippe Pébay <span dir="ltr"><<a href="mailto:philippe.pebay@kitware.com" target="_blank">philippe.pebay@kitware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hello Trevor,<br><br>Thank you for your message. I am currently working on vtkHyperTreeGrid data set, which generalizes the concepts contained in vtkHyperOctree. At some point the latter will be deprecated, and its functionality be completely assumed by the former. I will look at your patch and see if I can push it into the vtkHyperOctree in the meantime.<br>
<br>Thank you<br>Philippe<br><br><div class="gmail_quote"><div><div>On Thu, Jan 24, 2013 at 4:19 PM, Trevor Irons <span dir="ltr"><<a href="mailto:trevorirons@gmail.com" target="_blank">trevorirons@gmail.com</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div>A little while ago I posted to the users list a problem with the vtkHyperOctree->DeepCopy method:<br>
<a href="http://www.vtk.org/pipermail/vtkusers/2013-January/127166.html" target="_blank">http://www.vtk.org/pipermail/vtkusers/2013-January/127166.html</a><br>
<br><br>The problem is that the DeepCopy actually provides a shallow copy of the underlying Octree. <br><br>I have prepared a proposed patch that fixes this issue:<br><a href="http://review.source.kitware.com/#/c/9452/" target="_blank">http://review.source.kitware.com/#/c/9452/</a><br>
<br>And also filed a bug report:<br><a href="http://vtk.org/Bug/view.php?id=13819" target="_blank">http://vtk.org/Bug/view.php?id=13819</a><br><br>This is my first time contributing to VTK. So I apologize if I have done something wrong. Please consider merging this changeset, or something similar. Is there another step I need to take to have the changeset reviewed?<br>
<br>Thanks,<br><br clear="all"><div>-- Trevor<br></div>
<br></div></div>_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
<br>
<br></blockquote></div><span><font color="#888888"><br><br clear="all"><br>-- <br><font color="#888888">Philippe Pébay, PhD<br></font><font color="#888888">Director of Visualization and High Performance Computing /<br>
</font><font color="#888888">Directeur de la Visualisation et du Calcul Haute Performance<br>
Kitware SAS<br>26 rue Louis Guérin, 69100 Villeurbanne, France</font><br>
<font color="#888888"><a value="+33426685003">+33 (0) 6.83.61.55.70 / 4.37.45.04.15</a></font><font color="#888888"><br><a href="http://www.kitware.fr/" target="_blank">http://www.kitware.fr</a></font><font color="#888888"><a href="http://www.kitware.fr/" target="_blank"></a></font>
</font></span></blockquote></div><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br><font color="#888888">Philippe Pébay, PhD<br></font><font color="#888888">Director of Visualization and High Performance Computing /<br>
</font><font color="#888888">Directeur de la Visualisation et du Calcul Haute Performance<br>
Kitware SAS<br>26 rue Louis Guérin, 69100 Villeurbanne, France</font><br>
<font color="#888888"><a value="+33426685003">+33 (0) 6.83.61.55.70 / 4.37.45.04.15</a></font><font color="#888888"><br><a href="http://www.kitware.fr/" target="_blank">http://www.kitware.fr</a></font><font color="#888888"><a href="http://www.kitware.fr/" target="_blank"></a></font>
</div></div></blockquote></div><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br><font color="#888888">Philippe Pébay, PhD<br></font><font color="#888888">Director of Visualization and High Performance Computing /<br>
</font><font color="#888888">Directeur de la Visualisation et du Calcul Haute Performance<br>
Kitware SAS<br>26 rue Louis Guérin, 69100 Villeurbanne, France</font><br>
<font color="#888888"><a value="+33426685003">+33 (0) 6.83.61.55.70 / 4.37.45.04.15</a></font><font color="#888888"><br><a href="http://www.kitware.fr/" target="_blank">http://www.kitware.fr</a></font><font color="#888888"><a href="http://www.kitware.fr/" target="_blank"></a></font>