Ooops. I wrote this e-mail before I saw that you had updated the gerrit topic: <a href="http://review.source.kitware.com/#/t/1451/">http://review.source.kitware.com/#/t/1451/</a><div><br></div><div>I just tried your patch and caffeine.tcl produces the correct image.</div>
<div><br></div><div>Thanks,</div><div><br></div><div>Bill<br><br><div class="gmail_quote">On Sun, Oct 14, 2012 at 8:40 AM, Bill Lorensen <span dir="ltr"><<a href="mailto:bill.lorensen@gmail.com" target="_blank">bill.lorensen@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Joachim,
<div><br></div><div>I noticed that you have a gerrit topic for the caffeine.tcl regression.</div><div><br></div><div>It seems that the file VTKData/Data/caffeine.pdb is not a valid pdb file. The file has been there since 2003, but I suspect it did not come from the official PDB. It may have come from here: <a href="http://elchem.kaist.ac.kr/jhkwak/okanaganpdb97/molecule/molecule.html" target="_blank">http://elchem.kaist.ac.kr/jhkwak/okanaganpdb97/molecule/molecule.html</a></div>
<div>The author says "I use a commercial programme to obtain x,y,z coordinates and use these in a format usable by RasMol."</div><div><br></div><div>1) I suggest we add the missing element symbols to caffeine.pdb.</div>
<div>2) Since the new PDB code ignores hydrogen (I assume they is some chemistry reason for this), I suggest we add a new baseline that shows caffeine without hydrogen.</div><div><br></div><div>With these 2 changes, there is no need to modify the current PDB reader.</div>
<span class="HOEnZb"><font color="#888888">
<div><br></div><div>Bill</div><div><br></div>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br>Unpaid intern in BillsBasement at noware dot com<br><br>
</div>