Most of the time, when the Tcl SetGet test fails on a new change, it is that somebody has added a pointer ivar, and initialized it to "NULL" or 0, and then it is accessed in a Get method without being checked.<div>
<br></div><div>This test helps to catch things like that, and usually, the correction is just to add an "if ()" test that verifies the pointer is non-null before dereferencing.<br><br>All VTK devs need to understand that methods are called (by various people in the real world) in an order different than the one they expect. Just because the new test that they wrote does it correctly doesn't mean anybody else will.</div>
<div><br></div><div>This test helps to make all the methods robust no matter what order they are called in.<br><br><br><div class="gmail_quote">On Fri, Sep 28, 2012 at 5:22 PM, David E DeMarle <span dir="ltr"><<a href="mailto:dave.demarle@kitware.com" target="_blank">dave.demarle@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p>Thanks. </p>
<p>I'm looking for more details.</p>
<p>Specifically why is it a bad thing when each of our specific smoke tests fail on some new code and when exceptions for that test are acceptable.<br>
</p><div class="HOEnZb"><div class="h5">
<div class="gmail_quote">On Sep 28, 2012 4:26 PM, "Bill Lorensen" <<a href="mailto:bill.lorensen@gmail.com" target="_blank">bill.lorensen@gmail.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Dave,<br><br>"Ancient ones"? We prefer "Wise ones"...<br><br>These are smoke tests: <a href="http://en.wikipedia.org/wiki/Smoke_testing" target="_blank">http://en.wikipedia.org/wiki/Smoke_testing</a><br>
to blinding test basic functionality. They certainly matter.<br>
<br>For example SetGet tests ensure that a variable can be set and retrieved. In the past we had tests that ensured that if a variable was changed, the class' modified time changed. Or, can a class print itself after instantiation.<br>
<br>Bill<br><br>Sep 28, 2012 at 4:10 PM, David E DeMarle <span dir="ltr"><<a href="mailto:dave.demarle@kitware.com" target="_blank">dave.demarle@kitware.com</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Could one of the ancient* ones on the list explain the rationale<br>
behind these and the other old tcl style tests?<br>
<br>
They are failing now in some of the new classes that were<br>
added/changed during the big test downtime that started when<br>
modularization went in. Before I get deep into the job of fixing them<br>
(or convincing the responsible parties that they should), I'ld like to<br>
know if and why they matter.<br>
<br>
thanks,<br>
<br>
*I'm not mentioning any names here Will.<br>
<br>
David E DeMarle<br>
Kitware, Inc.<br>
R&D Engineer<br>
21 Corporate Drive<br>
Clifton Park, NY 12065-8662<br>
Phone: 518-881-4909David E DeMarle<br>
_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
<br>
</blockquote></div><br><br clear="all"><br>-- <br>Unpaid intern in BillsBasement at noware dot com<br><br>
</blockquote></div>
</div></div><br>_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
<br>
<br></blockquote></div><br></div>