I agree.<br><br><div class="gmail_quote">On Thu, Sep 20, 2012 at 12:02 PM, David Gobbi <span dir="ltr"><<a href="mailto:david.gobbi@gmail.com" target="_blank">david.gobbi@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I have to say that I agree with Marcus. Tests must check for correct<br>
behavior. That is really the purpose of a unit test, isn't it?<br>
<br>
Having a test that will pass even when the results are incorrect is<br>
bad, bad, bad. It leads to false confidence in the code.<br>
<br>
If we allow tests that provide full coverage and zero valgrind<br>
defects, but which will pass when the code is giving incorrect<br>
results, then coverage becomes a meaningless metric.<br>
<br>
I consider an incorrect result to be a more serious defect than a segfault.<br>
<span class="HOEnZb"><font color="#888888"><br>
- David<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
<br>
On Thu, Sep 20, 2012 at 9:41 AM, Bill Lorensen <<a href="mailto:bill.lorensen@gmail.com">bill.lorensen@gmail.com</a>> wrote:<br>
> But, it could segfault for have valgrind defects... It is a form of testing<br>
> to check for memory access and leaks.<br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>Unpaid intern in BillsBasement at noware dot com<br><br>