Hi Marcus,<div><br></div><div>If I can add version numbers to the library name but keep the target</div><div>name as "vtkPythonCore", then that seems ideal.</div><div><br></div><div> - David</div><div><br><br><div class="gmail_quote">
On Tue, Jun 12, 2012 at 2:37 PM, Marcus D. Hanwell <span dir="ltr"><<a href="mailto:marcus.hanwell@kitware.com" target="_blank">marcus.hanwell@kitware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi David,<br>
<br>
The target name is not well defined now though, and so you make it<br>
difficult to link to. Why not set a consistent target name, and use<br>
the the target properties to change its name on disk - this would make<br>
code wishing to link to it far simpler than having to get the<br>
currently used Python version.<br>
<br>
I can propose a patch, but I think it is overly complicated to<br>
introduce a target name that changes. We could then use<br>
include_directories and target_link_libraries in these cases for<br>
ParaView.<br>
<span class="HOEnZb"><font color="#888888"><br>
Marcus<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
On Tue, Jun 12, 2012 at 4:01 PM, David Gobbi <<a href="mailto:david.gobbi@gmail.com">david.gobbi@gmail.com</a>> wrote:<br>
> Hi Kyle,<br>
><br>
> Include directories have to be set up with include_directories(), just like<br>
> in the pre-modular days. After the vtk-python-versioned-libs merge,<br>
> PythonCore is no longer a module, it's a plain old VTK library.<br>
><br>
> - David<br>
><br>
><br>
> On Tue, Jun 12, 2012 at 1:42 PM, Kyle Lutz <<a href="mailto:kyle.lutz@kitware.com">kyle.lutz@kitware.com</a>> wrote:<br>
>><br>
>> Hi David Gobbi,<br>
>><br>
>> We are also having issues with this change in ParaView. A ParaView<br>
>> topic brought in VTK-master which brought in your topic<br>
>> ('vtk-python-versioned-libs') leading to the following compilation<br>
>> errors:<br>
>><br>
>><br>
>> /home/kyle/ParaView/Utilities/VTKPythonWrapping/Executable/vtkPVPythonInterpretor.cxx:16:<br>
>> error: vtkPython.h: No such file or directory<br>
>><br>
>> What is the proper way to set up the include and link paths for the<br>
>> new python wrapping code?<br>
>><br>
>> -kyle<br>
>><br>
>> On Tue, Jun 12, 2012 at 3:34 PM, David Gobbi <<a href="mailto:david.gobbi@gmail.com">david.gobbi@gmail.com</a>><br>
>> wrote:<br>
>> > Hi David,<br>
>> ><br>
>> > This just depends on python, right? Not the python wrappers?<br>
>> > So it could do its own find_package(PythonLibs REQUIRED)<br>
>> > and set up the include_directories and link_libraries, completely<br>
>> > independent of the wrappers. I'm not saying it would be easy...<br>
>> > some important things like the generation of vtkPythonConfigure.h<br>
>> > and choosing between the release & debug versions of the python<br>
>> > library are tied up with wrapping and would need to be refactored.<br>
>> ><br>
>> > Are you sure the class should have an innocuous name like<br>
>> > "vtkMathTextUtilities" when it requires python, matplotlib, and<br>
>> > (I'm guessing) latex in order to work?<br>
>> ><br>
>> > - David<br>
>> ><br>
>> ><br>
>> ><br>
>> > On Tue, Jun 12, 2012 at 12:24 PM, David Lonie <<a href="mailto:david.lonie@kitware.com">david.lonie@kitware.com</a>><br>
>> > wrote:<br>
>> >><br>
>> >> Hi David,<br>
>> >><br>
>> >> I'm working on a new module that requires python, and we noticed that<br>
>> >> you<br>
>> >> removed the PythonCore module last week. Is there any way to restore<br>
>> >> the<br>
>> >> module and preserve the new functionality you needed for library<br>
>> >> versioning?<br>
>> >> I've pushed a changeset for my new module, but we cannot merge it as it<br>
>> >> needs to explicitly depend on PythonCore:<br>
>> >><br>
>> >> <a href="http://review.source.kitware.com/#/c/6177/" target="_blank">http://review.source.kitware.com/#/c/6177/</a><br>
>> >><br>
>> >> Or is there another way that this dependency can be added without an<br>
>> >> actual PythonCore module?<br>
>> >><br>
>> >> Thanks,<br>
>> >><br>
>> >> Dave<br>
><br>
><br>
</div></div><div class="HOEnZb"><div class="h5">> _______________________________________________<br>
> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
><br>
> Visit other Kitware open-source projects at<br>
> <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
><br>
> Follow this link to subscribe/unsubscribe:<br>
> <a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
><br>
><br>
</div></div></blockquote></div><br></div>