<div>Hi Marcus,</div><div><br></div>I will be glad to help and I will certainly ask if anything is unclear!<div><br></div><div>Andrew</div><div><br><br><div class="gmail_quote">On Wed, May 16, 2012 at 11:50 AM, Marcus D. Hanwell <span dir="ltr"><<a href="mailto:marcus.hanwell@kitware.com" target="_blank">marcus.hanwell@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Andrew,<br>
<br>
I would really appreciate it, and please ask if anything is unclear<br>
when adding back in the tests. We are not moving the baseline images,<br>
and so have hardwired their locations along the old kit locations. If<br>
you get the basics in I can certainly help you with any of the build<br>
system stuff too.<br>
<br>
Thanks,<br>
<br>
Marcus<br>
<br>
On Tue, May 15, 2012 at 8:45 PM, Andrew Maclean<br>
<div class="HOEnZb"><div class="h5"><<a href="mailto:andrew.amaclean@gmail.com">andrew.amaclean@gmail.com</a>> wrote:<br>
> Hi Marcus, I would be more than happy to update the parametric test code if<br>
> that is Ok with you.<br>
><br>
> Andrew<br>
><br>
><br>
> On Wed, May 16, 2012 at 9:55 AM, Marcus D. Hanwell<br>
> <<a href="mailto:marcus.hanwell@kitware.com">marcus.hanwell@kitware.com</a>> wrote:<br>
>><br>
>> Andrew, Bill,<br>
>><br>
>> We have been working on getting ParaView building against VTK modular,<br>
>> and fixing up issues as they cropped up. We have also spent some time<br>
>> fixing up the tests that are running and adding a few in. I also had<br>
>> other projects that had been neglected I have been getting back to.<br>
>><br>
>> I plan on spending some time on restoring functionality/adding more<br>
>> tests Wednesday/Thursday. I would certainly welcome input (and<br>
>> patches) from those that know the code in these modules best. Failing<br>
>> that Chris and I will be working on restoring more tests now that<br>
>> ParaView is mostly ported over (master as of Friday is building<br>
>> against modular VTK 6).<br>
>><br>
>> We would also like to work on getting the less reliable tests weeded<br>
>> out so that we can have a green dashboard. Ideally I would like to<br>
>> compile a list of people responsible/knowledgeable on the modules that<br>
>> have been established. We were thinking of adding this list to a wiki<br>
>> page, this would help both with code review and quality control.<br>
>><br>
>> Just a few thoughts/input on what we have been up to.<br>
>><br>
>> Thanks,<br>
>><br>
>> Marcus<br>
>><br>
>> On Tue, May 15, 2012 at 7:20 PM, Andrew Maclean<br>
>> <<a href="mailto:andrew.amaclean@gmail.com">andrew.amaclean@gmail.com</a>> wrote:<br>
>> > Hi Bill,<br>
>> > I had noticed this. I have been assuming that Marcus or someone has been<br>
>> > gradually reintroducing the tests.<br>
>> > If this is not the case is there something I should do?<br>
>> ><br>
>> > Andrew<br>
>> ><br>
>> ><br>
>> > On Wed, May 16, 2012 at 9:12 AM, Bill Lorensen <<a href="mailto:bill.lorensen@gmail.com">bill.lorensen@gmail.com</a>><br>
>> > wrote:<br>
>> >><br>
>> >> Andrew,<br>
>> >><br>
>> >> Looks to me like the Parametric classes are not being tested by VTK6<br>
>> >><br>
>> >> Bill<br>
>> >><br>
>> >> On Tue, May 15, 2012 at 6:47 PM, Andrew Maclean<br>
>> >> <<a href="mailto:andrew.amaclean@gmail.com">andrew.amaclean@gmail.com</a>> wrote:<br>
>> >> > Hi Bill, David,<br>
>> >> > As one of you pointed out earlier, the VTK Parametric classes will<br>
>> >> > be<br>
>> >> > affected by this change. In particular, the regression tests will<br>
>> >> > fail due to the higher precision of Pi. I would only expect that the<br>
>> >> > pictures for the regression tests would need to be updated.<br>
>> >> ><br>
>> >> > When I wrote these in conjunction with Will, I must admit I was<br>
>> >> > frustrated<br>
>> >> > that vtkMath::Pi only returned float. However I made a decision to<br>
>> >> > use<br>
>> >> > vtkMath::Pi rather than yet another constant for Pi in the hopes that<br>
>> >> > this<br>
>> >> > would change in the future. The greater precision should improve the<br>
>> >> > look of<br>
>> >> > some of the surfaces. E.g. the little imperfection at the pole of the<br>
>> >> > ellipsoid should get smaller.<br>
>> >> ><br>
>> >> > Let me know if I can help in any way.<br>
>> >> ><br>
>> >> > When things settle, I will also update the PDF titled "Parametric<br>
>> >> > Equations<br>
>> >> > for Surfaces" in the documentation to VTK 6.<br>
>> >> ><br>
>> >> > Regards<br>
>> >> > Andrew<br>
>> >> ><br>
>> >> ><br>
>> >> ><br>
>> >> >><br>
>> >> >><br>
>> >> >> ---------- Forwarded message ----------<br>
>> >> >> From: David Gobbi <<a href="mailto:david.gobbi@gmail.com">david.gobbi@gmail.com</a>><br>
>> >> >> To: Bill Lorensen <<a href="mailto:bill.lorensen@gmail.com">bill.lorensen@gmail.com</a>><br>
>> >> >> Cc: VTK Developers <<a href="mailto:vtk-developers@vtk.org">vtk-developers@vtk.org</a>><br>
>> >> >> Date: Mon, 14 May 2012 16:38:37 -0600<br>
>> >> >> Subject: Re: [vtk-developers] DoublePi proposal<br>
>> >> >> Bill, the main reason that I put my patch on hold was that I wanted<br>
>> >> >> to<br>
>> >> >> wait until VTK 6 had reached at least the same level of test<br>
>> >> >> coverage<br>
>> >> >> as VTK 5. I still think that this is a valid reason for keeping<br>
>> >> >> this<br>
>> >> >> patch on hold. The added pi precision will cause subtle changes in<br>
>> >> >> many regression images, and some of the changes will be significant<br>
>> >> >> enough to cause test failures. That's great if all the regression<br>
>> >> >> tests are running, because we can examine any test failures that<br>
>> >> >> occur<br>
>> >> >> and replace the regression images as necessary.<br>
>> >> >><br>
>> >> >> But right now in VTK 6, about half of our regression tests aren't<br>
>> >> >> running. So if this Pi patch is pushed now, we won't see all the<br>
>> >> >> regression test failures immediately. We'll see some regression<br>
>> >> >> test<br>
>> >> >> failures some weeks (or months?) later as the various tests are<br>
>> >> >> re-activated, and we won't be sure if the failures were caused by<br>
>> >> >> this<br>
>> >> >> patch, or if they were caused by some other patch.<br>
>> >> >><br>
>> >> >> - David<br>
>> >> >><br>
>> >> >><br>
>> >> >> On Mon, May 14, 2012 at 11:59 AM, David Gobbi<br>
>> >> >> <<a href="mailto:david.gobbi@gmail.com">david.gobbi@gmail.com</a>><br>
>> >> >> wrote:<br>
>> >> >> > <a href="http://review.source.kitware.com/#/t/427/" target="_blank">http://review.source.kitware.com/#/t/427/</a><br>
>> >> >> ><br>
>> >> >> ><br>
>> >> >> > On Mon, May 14, 2012 at 10:50 AM, Bill Lorensen<br>
>> >> >> > <<a href="mailto:bill.lorensen@gmail.com">bill.lorensen@gmail.com</a>> wrote:<br>
>> >> >> >> David,<br>
>> >> >> >><br>
>> >> >> >> Can you point me to the gerrit topic? If not, I can start from<br>
>> >> >> >> scratch.<br>
>> >> >> >><br>
>> >> >> >> Bill<br>
>> >> ><br>
>> >> > --<br>
>> >> > ___________________________________________<br>
>> >> > Andrew J. P. Maclean<br>
>> >> ><br>
>> >> > ___________________________________________<br>
>> >><br>
>> >><br>
>> >><br>
>> >> --<br>
>> >> Unpaid intern in BillsBasement at noware dot com<br>
>> ><br>
>> ><br>
>> ><br>
>> ><br>
>> > --<br>
>> > ___________________________________________<br>
>> > Andrew J. P. Maclean<br>
>> ><br>
>> > ___________________________________________<br>
><br>
><br>
><br>
><br>
> --<br>
> ___________________________________________<br>
> Andrew J. P. Maclean<br>
><br>
> ___________________________________________<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>___________________________________________<br>Andrew J. P. Maclean<br><br>___________________________________________<br>
</div>