<br><br><div class="gmail_quote">On Fri, Apr 13, 2012 at 4:45 PM, Goodwin Lawlor <span dir="ltr"><<a href="mailto:goodwin.lawlor.lists@gmail.com">goodwin.lawlor.lists@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br><br><div class="gmail_quote"><div><div class="h5">On Fri, Apr 13, 2012 at 4:13 PM, Marcus D. Hanwell <span dir="ltr"><<a href="mailto:marcus.hanwell@kitware.com" target="_blank">marcus.hanwell@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><div>On Fri, Apr 13, 2012 at 11:09 AM, Goodwin Lawlor<br>
<<a href="mailto:goodwin.lawlor.lists@gmail.com" target="_blank">goodwin.lawlor.lists@gmail.com</a>> wrote:<br>
><br>
><br>
> On Thu, Apr 12, 2012 at 6:35 PM, Marcus D. Hanwell<br>
> <<a href="mailto:marcus.hanwell@kitware.com" target="_blank">marcus.hanwell@kitware.com</a>> wrote:<br>
>><br>
>> On Wed, Apr 11, 2012 at 2:09 PM, Marcus D. Hanwell<br>
>> <<a href="mailto:marcus.hanwell@kitware.com" target="_blank">marcus.hanwell@kitware.com</a>> wrote:<br>
>> > Hi,<br>
>> ><br>
>> > I have a Gerrit topic up for review,<br>
>> ><br>
>> > <a href="http://review.source.kitware.com/#/t/374/" target="_blank">http://review.source.kitware.com/#/t/374/</a><br>
>> ><br>
>> > This gets some of the rendering tests up and running again, but they<br>
>> > hang until killed. Does anyone with deeper knowledge of Tcl and VTK<br>
>> > have any idea what I might have missed. You can check out and build<br>
>> > this topic, it depends on another topic that restores some Tcl code,<br>
>> > and adjusts it for the new layout.<br>
>> ><br>
>> I have updated this topic, and have passing Tcl tests. The main point<br>
>> I would love a little feedback on is why the additional require<br>
>> package call was not necessary before modularization. I can confirm<br>
>> that the image comparison is working, and I have to separate the tests<br>
>> into two parts (Graphics and Rendering).<br>
>><br>
>> Marcus<br>
><br>
><br>
> Hi Marcus,<br>
><br>
> Pre-modularization, the vtk-tcl interpreter built with the vtk libs,<br>
> initialized all the vtk commands on startup without a "package require vtk".<br>
> That's the interpreter ctest uses to run rtImageTest.tcl.<br>
><br>
> The question is, post-mod, what has changed that requires rtImageTest.tcl to<br>
> have a "package require vtk".<br>
><br>
> I'll have a look when I've got a new build.<br>
><br>
</div></div>Thanks for the explanation, I don't see where it was doing the package<br>
require vtk before, and all the tests seem to have that as their first<br>
line. For now we have merged the change, but I would welcome patches<br>
if the old behavior is still desirable. We would also appreciate help<br>
in restoring some of these tests if anyone still works with Tcl.<br>
<br>
Thanks,<br>
<br>
Marcus<br></blockquote><div><br></div></div></div><div>The "package require vtk" wasn't been done before for the interpreter built with the vtk libs - the vtk commands were been initialized by the interpreter itself (in c) - have a look at vtkTkAppInit.cxx (if you have time!)</div>
<div><br></div><div>If you were running vtk-tcl scripts with the interpreter above, "package require vtk" was (almost) redundant - but if you used your own/activestate's interpreter and built dynamic vtk libs with tcl wrappers, then you needed "package require vtk".</div>
<div><br></div><div>The merged change is fine - it's unlikely but someone may run the regression tests manually with a different interpreter and now they will work.</div><div><br></div><div>I'll build from master today and have a look through the tcl stuff over the weekend. We still use vtk-tcl in our lab...</div>
<span class="HOEnZb"><font color="#888888">
<div><br></div><div>Goodwin</div></font></span></div><br>
</blockquote></div><br><div>Just fyi, here's the diff that caused the above problems</div><div><br></div><a href="http://vtk.org/gitweb?p=VTK.git;a=blobdiff;f=Wrapping/Tcl/vtkTkAppInit.cxx;h=8a6001416a69cf1ede821bce50c53f627768cd80;hp=857af94651b9f5366ede9ca9f62dad14c58d3229;hb=0c1471f1da0ee8d76e9db0d95a0c434f0b38a7f5;hpb=cdd4d6fdec8b4b2c143224ca1d94699c96a8b58a">http://vtk.org/gitweb?p=VTK.git;a=blobdiff;f=Wrapping/Tcl/vtkTkAppInit.cxx;h=8a6001416a69cf1ede821bce50c53f627768cd80;hp=857af94651b9f5366ede9ca9f62dad14c58d3229;hb=0c1471f1da0ee8d76e9db0d95a0c434f0b38a7f5;hpb=cdd4d6fdec8b4b2c143224ca1d94699c96a8b58a</a><div>
<br></div><div>The init code was chopped out of vtkTkAppInit.cxx since it reflected the old structure, I guess.</div><div><br></div><div>I think it's better off this way, anyway.</div><div><br></div><div>Goodwin</div>