Hi,<br><br>Not sure why I keep losing track of this topic, let's merge <a href="http://review.source.kitware.com/#/t/151">http://review.source.kitware.com/#/t/151</a> for this release. I just rebased the topic and did a gerrit-push. I'll ping the original reviewers so we can get it verified again and committed this time.<br>
<br>Pat<br><br><div class="gmail_quote">On Sat, Feb 25, 2012 at 8:36 PM, David E DeMarle <span dir="ltr"><<a href="mailto:dave.demarle@kitware.com">dave.demarle@kitware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Sure, let's branch some time this coming week. More specifically I<br>
won't branch until Marcus and Julien tell me that their changes are in<br>
and I see that the dashboards are clean.<br>
<br>
Note - after the branch there will be some time during the release<br>
candidate cycle to get important fixes and updates into the release<br>
branch before the final version is tagged. To do that, you will have<br>
to be able to give me a list of exactly which commits you want brought<br>
into the release branch. Those changes have to have been started by<br>
you off the release branch (or cherry picked by you onto it) and<br>
merged onto and tested in the master branch before I will commit them<br>
onto the release line.<br>
<div class="im HOEnZb"><br>
David E DeMarle<br>
Kitware, Inc.<br>
R&D Engineer<br>
21 Corporate Drive<br>
Clifton Park, NY 12065-8662<br>
Phone: <a href="tel:518-881-4909" value="+15188814909">518-881-4909</a><br>
<br>
<br>
<br>
</div><div class="HOEnZb"><div class="h5">On Sat, Feb 25, 2012 at 6:01 PM, Julien Finet <<a href="mailto:julien.finet@kitware.com">julien.finet@kitware.com</a>> wrote:<br>
><br>
> Indeed, ideally we would need to wait until Monday. However, if you prefer,<br>
> I can submit the API change now, with a slight risk of a patch later (not<br>
> likely to be an API change)<br>
> That way, Slicer 4.1 (feature freeze on Monday) will be build with VTK 5.10<br>
> (and not a custom VTK version special for Slicer).<br>
><br>
> Let me know,<br>
> j.<br>
><br>
> ---------- Forwarded message ----------<br>
> From: Julien Finet <<a href="mailto:julien.finet@kitware.com">julien.finet@kitware.com</a>><br>
> Date: Wed, Feb 22, 2012 at 9:25 AM<br>
> Subject: Re: [slicer-devel] Slicer4 and VTK version<br>
> To: Will Schroeder <<a href="mailto:will.schroeder@kitware.com">will.schroeder@kitware.com</a>><br>
> Cc: Michael Jeulinl <<a href="mailto:michael.jeulinl@kitware.com">michael.jeulinl@kitware.com</a>><br>
><br>
><br>
> Hi Will,<br>
><br>
> I remember Michael had some commit reviews on hold in VTK<br>
> <a href="http://review.source.kitware.com/#/c/2992/" target="_blank">http://review.source.kitware.com/#/c/2992/</a> -> your initial commit<br>
> <a href="http://review.source.kitware.com/#/c/2993/" target="_blank">http://review.source.kitware.com/#/c/2993/</a> -> his re-work on it<br>
><br>
> However from the email discussion of 09/30/11, it seems that 2993 might not<br>
> be the most up-to-date code.<br>
> I guess the most up-to-date is what's in Slicer:<br>
> your initial<br>
> work: <a href="https://github.com/Slicer/VTK/commit/55e9b3d3e833a5890486495028f9fa725bb89296" target="_blank">https://github.com/Slicer/VTK/commit/55e9b3d3e833a5890486495028f9fa725bb89296</a><br>
> Michael's<br>
> rework: <a href="https://github.com/Slicer/VTK/commit/6d2e956ade664c951ebc49496b01c230221a87fd" target="_blank">https://github.com/Slicer/VTK/commit/6d2e956ade664c951ebc49496b01c230221a87fd</a><br>
> merge<br>
> commit: <a href="https://github.com/Slicer/VTK/commit/b8c6adc067b8ecfea65d9797338868b3a0b874ea" target="_blank">https://github.com/Slicer/VTK/commit/b8c6adc067b8ecfea65d9797338868b3a0b874ea</a><br>
><br>
> Michael being on vacation this week, it might be risky to push in VTK (just<br>
> as I'm not sure 100% sure of what is "current").<br>
> However, I believe what's in Slicer is pretty close to the last commit. So<br>
> you can definitely review it.<br>
><br>
> Thanks,<br>
> Julien.<br>
><br>
><br>
> On Sat, Feb 25, 2012 at 5:50 PM, Marcus D. Hanwell<br>
> <<a href="mailto:marcus.hanwell@kitware.com">marcus.hanwell@kitware.com</a>> wrote:<br>
>><br>
>> On Thu, Feb 23, 2012 at 3:45 PM, David E DeMarle<br>
>> <<a href="mailto:dave.demarle@kitware.com">dave.demarle@kitware.com</a>> wrote:<br>
>> > Hey everybody.<br>
>> ><br>
>> > We are about to start the vtk5.10 release cycle. We would like to<br>
>> > branch as soon as this coming weekend - but if there are features out<br>
>> > there that are currently in progress and which are nearly finished, we<br>
>> > could delay a week or two for you to get them cleanly into master<br>
>> > before the branch happens.<br>
>> ><br>
>> > So, if you are currently working on features that you want to get into<br>
>> > this release, please reply all to this email and let us know what the<br>
>> > feature is and where you are at with it so we can plan accordingly.<br>
>> ><br>
>> The dashboards had a compile failure on them today (already reviewed<br>
>> and merged the fix), and I have several API changes and compile fixes<br>
>> I would like to get in. Julien Finet also let me know that there is a<br>
>> fix they are hoping to get in for Slicer, but the earliest it would be<br>
>> ready is Monday. My fixes are ready to go in once they have been<br>
>> reviewed. I am adding a Clang 3.0 Linux nightly submission to catch<br>
>> future issues with Clang on Linux.<br>
>><br>
>> Thanks,<br>
>><br>
>> Marcus<br>
><br>
><br>
</div></div><div class="HOEnZb"><div class="h5">_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
<br>
</div></div></blockquote></div><br>