<div><br></div><div>Indeed, ideally we would need to wait until Monday. However, if you prefer, I can submit the API change now, with a slight risk of a patch later (not likely to be an API change)</div>That way, Slicer 4.1 (feature freeze on Monday) will be build with VTK 5.10 (and not a custom VTK version special for Slicer).<div>
<br></div><div>Let me know,</div><div>j.<br><div> <br>---------- Forwarded message ----------<br>From: <b class="gmail_sendername">Julien Finet</b> <span dir="ltr"><<a href="mailto:julien.finet@kitware.com" target="_blank">julien.finet@kitware.com</a>></span><br>
Date: Wed, Feb 22, 2012 at 9:25 AM<br>Subject: Re: [slicer-devel] Slicer4 and VTK version<br>To: Will Schroeder <<a href="mailto:will.schroeder@kitware.com" target="_blank">will.schroeder@kitware.com</a>><br>Cc: Michael Jeulinl <<a href="mailto:michael.jeulinl@kitware.com" target="_blank">michael.jeulinl@kitware.com</a>><br>
<br><br>Hi Will,<div><br></div><div>I remember Michael had some commit reviews on hold in VTK</div><div><a href="http://review.source.kitware.com/#/c/2992/" target="_blank">http://review.source.kitware.com/#/c/2992/</a> -> your initial commit</div>
<div><a href="http://review.source.kitware.com/#/c/2993/" target="_blank">http://review.source.kitware.com/#/c/2993/</a> -> his re-work on it</div><div><br></div><div>However from the email discussion of 09/30/11, it seems that 2993 might not be the most up-to-date code.</div>
<div>I guess the most up-to-date is what's in Slicer:</div><div>your initial work: <a href="https://github.com/Slicer/VTK/commit/55e9b3d3e833a5890486495028f9fa725bb89296" target="_blank">https://github.com/Slicer/VTK/commit/55e9b3d3e833a5890486495028f9fa725bb89296</a></div>
<div>Michael's rework: <a href="https://github.com/Slicer/VTK/commit/6d2e956ade664c951ebc49496b01c230221a87fd" target="_blank">https://github.com/Slicer/VTK/commit/6d2e956ade664c951ebc49496b01c230221a87fd</a></div>merge commit: <a href="https://github.com/Slicer/VTK/commit/b8c6adc067b8ecfea65d9797338868b3a0b874ea" target="_blank">https://github.com/Slicer/VTK/commit/b8c6adc067b8ecfea65d9797338868b3a0b874ea</a><div>
</div><div>Michael being on vacation this week, it might be risky to push in VTK (just as I'm not sure 100% sure of what is "current").</div><div>However, I believe what's in Slicer is pretty close to the last commit. So you can definitely review it.</div>
<div><br></div><div>Thanks,</div><div>Julien. </div><div><br></div><br><div class="gmail_quote">On Sat, Feb 25, 2012 at 5:50 PM, Marcus D. Hanwell <span dir="ltr"><<a href="mailto:marcus.hanwell@kitware.com" target="_blank">marcus.hanwell@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>On Thu, Feb 23, 2012 at 3:45 PM, David E DeMarle<br>
<<a href="mailto:dave.demarle@kitware.com" target="_blank">dave.demarle@kitware.com</a>> wrote:<br>
</div><div>> Hey everybody.<br>
><br>
> We are about to start the vtk5.10 release cycle. We would like to<br>
> branch as soon as this coming weekend - but if there are features out<br>
> there that are currently in progress and which are nearly finished, we<br>
> could delay a week or two for you to get them cleanly into master<br>
> before the branch happens.<br>
><br>
> So, if you are currently working on features that you want to get into<br>
> this release, please reply all to this email and let us know what the<br>
> feature is and where you are at with it so we can plan accordingly.<br>
><br>
</div>The dashboards had a compile failure on them today (already reviewed<br>
and merged the fix), and I have several API changes and compile fixes<br>
I would like to get in. Julien Finet also let me know that there is a<br>
fix they are hoping to get in for Slicer, but the earliest it would be<br>
ready is Monday. My fixes are ready to go in once they have been<br>
reviewed. I am adding a Clang 3.0 Linux nightly submission to catch<br>
future issues with Clang on Linux.<br>
<br>
Thanks,<br>
<br>
Marcus<br>
</blockquote></div><br></div></div>