<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 12 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-GB" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Andy<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">I expect I’m able to push to Gerrit, but I was more concerned that I am on the pv branch of vtk and Tharindu’s on the vtk flavour – I am a bit new to this Gerrit
and am not quite sure why it exists at all. (I am beginning to ‘get it’ because I noticed that there’s a cherry-pick link which will allow me to get individual commits which I can then apply to my branch, but I’m not sure how to push just one commit since
I’m on another branch...)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">anyway – last time I ran the setup_development script I almost gave myself a coronary when it switched my push urls...you won’t catch me playing with that stuff
again!<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">JB<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Andy Bauer [mailto:andy.bauer@kitware.com]
<br>
<b>Sent:</b> 29 July 2011 15:21<br>
<b>To:</b> Biddiscombe, John A.<br>
<b>Cc:</b> David Gobbi; David Doria; VTK Developers<br>
<b>Subject:</b> Re: [vtk-developers] Cell Tree Locator Update<o:p></o:p></span></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal" style="margin-bottom:12.0pt">Hi John,<br>
<br>
I'm able to push to gerrit from paraview's vtk. Do you have the aliases set up there? Doing a "git config -l" I get the gerrit-push alias. Unfortunately, I can't remember exactly how I got that set up. Maybe trying "sh Utilities/SetupForDevelopment.sh"
from the main VTK directory will do it though.<br>
<br>
Andy<o:p></o:p></p>
<div>
<p class="MsoNormal">On Fri, Jul 29, 2011 at 8:22 AM, Biddiscombe, John A. <<a href="mailto:biddisco@cscs.ch">biddisco@cscs.ch</a>> wrote:<o:p></o:p></p>
<p class="MsoNormal" style="margin-bottom:12.0pt">It's very sad that we can't use the "using" syntax thanks to the borland and other old compilers, but that's life. (I've patched my version (patch attached), but can't push to Gerrit as I'm using the vtk branch
from paraview, not the vtk one from vtk <sigh>)<br>
<br>
The crash is reproducible on my system too. I must confess I didn't try the test before as I was more interested in findcell stuff and querying cells inside regions etc at the mo.<br>
<br>
Stepping through the code I can see that a condition is being missed in the split part of the algorithm, but I'm not quite sure yet how to fix it or why it is occurring.<br>
<br>
It is worth noting that the CellTreeLocator should come with a very large health warning : This class will not work on all datasets. It will only work when a true disjoint partitioning is available. They don't mention that much in the paper (or I didn't pick
up on it). One reason for the extra node in the ModifiedBSPTree is to handle cells which can't be partitioned into either side.<br>
<br>
Consider a chess board - imagine 64 quad cells in the dataset. No problem. Now add one more cell which is the whole board (ie the hull of the 64 mini quads). This will break the CellTreeLocator - cells which overlap other cells can't (always) be partitioned
nicely. For most datasets this isn't going to be a problem as most datasets are well behaved, but when I worked on lidar data and triangulating buildings from it many years ago, I often found long skinny triangles which could not be binned in either half and
the extra node solved it nicely.<br>
<br>
Anyway, it occurs to me that the test uses 2D polygons (tessellated sphere) in 3D space and it may be the bounds check is flawed for this case in the split algorithm and needs to be improved. One 2D cell might be axis aligned and cause a file somewhere ...<br>
<br>
When I get time I'll look into it, but if anyone else fixes it first please tell me so that I can not waste any time on it.<br>
<br>
JB<br>
<br>
<br>
-----Original Message-----<br>
From: <a href="mailto:vtk-developers-bounces@vtk.org">vtk-developers-bounces@vtk.org</a> [mailto:<a href="mailto:vtk-developers-bounces@vtk.org">vtk-developers-bounces@vtk.org</a>] On Behalf Of David Gobbi<br>
Sent: 29 July 2011 02:36<br>
To: David Doria<br>
Cc: VTK Developers; Andy Bauer<br>
Subject: Re: [vtk-developers] Cell Tree Locator Update<br>
<br>
On Thu, Jul 28, 2011 at 6:11 PM, David Doria <<a href="mailto:daviddoria@gmail.com">daviddoria@gmail.com</a>> wrote:<br>
><br>
>> /home/acbauer/CODE/VTK/VTK/Filtering/vtkAbstractCellLocator.h:107: warning:<br>
>> `virtual int vtkAbstractCellLocator::IntersectWithLine(double*, do<br>
>> uble*, double, double&, double*, double*, int&, vtkIdType&)' was hidden<br>
><br>
> I think these "function was hidden" are fixed by saying "using<br>
> functionName;" in the subclass, as I've done here:<br>
> <a href="http://review.source.kitware.com/#patch,sidebyside,1862,1,Filtering/vtkKdTreePointLocator.h" target="_blank">
http://review.source.kitware.com/#patch,sidebyside,1862,1,Filtering/vtkKdTreePointLocator.h</a><br>
><br>
> If there is a better way to fix them, I'd like to know about it.<br>
<br>
That trick will not work on Visual Studio 7.1, which is still a<br>
supported compiler for VTK. It also breaks the wrappers.<br>
<br>
If a VTK class overrides one version of IntersectWithLine, then it<br>
should override all of them. If need be, you can just define all the<br>
unneeded ones as inline methods that calls the superclass methods.<br>
<br>
- David<br>
_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">
http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><o:p></o:p></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>