<div class="gmail_quote"><div>Hi Marcus,</div><div> Firstly congratulations to you all on a brilliant first effort.</div><div><br></div><div>One minor change, could I suggest moving:</div><div>[Filters/Sources]</div><div>
<span style="font-family:helvetica, arial, freesans, clean, sans-serif;font-size:11px;line-height:14px"><pre style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;padding-top:0px;padding-right:0px;padding-bottom:0px;padding-left:0px;line-height:1.4em;font-family:'Bitstream Vera Sans Mono', Courier, monospace;font-size:12px">
<div style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;padding-top:0px;padding-right:0px;padding-bottom:0px;padding-left:1em;line-height:1.4em;background-color:transparent">
Graphics/vtkParametricFunctionSource.cxx:</div><div style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;padding-top:0px;padding-right:0px;padding-bottom:0px;padding-left:1em;line-height:1.4em;background-color:transparent">
Graphics/vtkParametricFunctionSource.h:</div></pre></span></div><div> </div><div>To:</div><div><span style="font-family:'Bitstream Vera Sans Mono', Courier, monospace;font-size:12px;line-height:17px;white-space:pre-wrap">[Core/ComputationalGeometry]</span></div>
<div><span style="font-family:'Bitstream Vera Sans Mono', Courier, monospace;font-size:12px;line-height:17px;white-space:pre-wrap"><br></span></div><div><span style="font-family:'Bitstream Vera Sans Mono', Courier, monospace;font-size:12px;line-height:17px;white-space:pre-wrap">Logically vtkParametricFunctionSource belongs with the rest of the vtkParametric classes.</span></div>
<div><br></div><div>They are used in the following manner:</div><div><div><br></div><div>// Select the function and source and then conect them to the</div><div>// mapper and actor.</div><div>------------------------------------------------------------ //</div>
<div>vtkSmartPointer<vtkParametricMobius> mobius</div><div>= vtkParametricMobius::New();</div><div>vtkSmartPointer<vtkParametricFunctionSource> mobiusSource</div><div>= vtkSmartPointer<vtkParametricFunctionSource>::New();</div>
</div><div><br></div><div><br></div><div>I am not aware of any other uses so logically the class vtkParametricFunctionSource should reside in <span style="font-family:'Bitstream Vera Sans Mono', Courier, monospace;font-size:12px;line-height:17px;white-space:pre-wrap">[Core/ComputationalGeometry].</span></div>
<div><br></div><div>Regards</div><div> Andrew</div><div><br></div><div><br></div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
---------- Forwarded message ----------<br>From: "Marcus D. Hanwell" <<a href="mailto:marcus.hanwell@kitware.com" target="_blank">marcus.hanwell@kitware.com</a>><br>To: VTK Developers <<a href="mailto:vtk-developers@vtk.org" target="_blank">vtk-developers@vtk.org</a>><br>
Date: Tue, 8 Mar 2011 17:07:10 -0500<br>Subject: [vtk-developers] VTK modularization: initial pass at new modules<br>Hi,<br>
<br>
I have linked to a manifest file, this contains an early pass at<br>
creating new VTK modules, as part of the VTK modularization project.<br>
It maps source files, the old CMakeLists.txt, Testing and several<br>
other parts have been intentionally left out for now. Once we have a<br>
rough consensus on the classes that will go into the new kits we can<br>
then map the tests to the appropriate places.<br>
<br>
<a href="https://github.com/cryos/vtk-modularization/blob/master/manifest.txt" target="_blank">https://github.com/cryos/vtk-modularization/blob/master/manifest.txt</a><br>
<br>
The [<ignore>] section marks files and directories that are not<br>
mapped. All other sections denote new modules, for example,<br>
<br>
[Core/Core]<br>
Common/vtkABI.h:<br>
<br>
Would map the vtkABI.h file currently in common to Core/Core/vtkABI.h<br>
in the new modules. This would be a kit called vtkCoreCore. We are<br>
planning on using two levels, with no modules in the first level and<br>
only one word being allowed for top levels so that it is easy to<br>
distinguish what the top level part of a library name is. This means<br>
that the Core directory would contain several other modules that are<br>
core libraries, with each module in the second level being a module.<br>
<br>
I am pushing this list while it is still at an early stage (largely<br>
with input from Berk, Will and Jeff so far) so that the wider<br>
community can comment on the proposed moves. None of the names or<br>
mappings are set in stone, and we welcome your input (especially from<br>
those of you who have spent a lot of time working on some of these<br>
classes). I will be updating it as I get things building, and once a<br>
reasonable subset of VTK is building I will put up an experimental<br>
modularized VTK repository for people to test. The history of that<br>
repository will not be retained, and all source changes should still<br>
go to VTK master.<br>
<br>
As you can see some old modules have not been mapped yet (Imaging,<br>
Parallel, Examples, Wrapping). I will let people know in advance of<br>
the final move, the mappings will be applied to the latest source<br>
files in master at that point using git file moves, and the new build<br>
system committed. Until then I can update the experimental modularized<br>
VTK by syncing to the latest source files in VTK master periodically.<br>
<br>
We would appreciate input from the wider VTK developer community as we<br>
modularize VTK. This will also impact other communities, such as<br>
ParaView and Slicer, and we are looking into ways to ease porting to<br>
the new layout. I have talked at length with the ITK modularization<br>
team to see what we can share, and will be putting that together in<br>
the experimental repository soon.<br>
<br>
Thanks,<br>
<br>
Marcus<br>
--<br>
Marcus D. Hanwell, Ph.D.<br>
R&D Engineer, Kitware Inc.<br>
(518) 881-4937<br>
<br><br></blockquote></div><br>-- <br>___________________________________________<br>Andrew J. P. Maclean<br>Australian Centre for Field Robotics (ACFR)<br>The Rose Street Building J04<br>The University of Sydney 2006 NSW<br>
AUSTRALIA<br>Ph: +61 2 9351 3283<br>Fax: +61 2 9351 7474<br>URL: <a href="http://www.acfr.usyd.edu.au/" target="_blank">http://www.acfr.usyd.edu.au/</a><br>___________________________________________<br>