Though the comment is exactly rigth, those should be compiler checks and not just near blindly appended to CMAKE_C_FLAGS.<br><br><div class="gmail_quote">On Wed, Feb 2, 2011 at 6:33 PM, David Partyka <span dir="ltr"><<a href="mailto:david.partyka@kitware.com">david.partyka@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">I will fix the install rule. Is there a good CMake way to detect clang? Id prefer to make any fix as invasive as possible to minimize deviating from upstream.<div>
<div></div><div class="h5"><br><br><div class="gmail_quote">On Wed, Feb 2, 2011 at 6:27 PM, Sean McBride <span dir="ltr"><<a href="mailto:sean@rogue-research.com" target="_blank">sean@rogue-research.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div></div><div>On Mon, 20 Dec 2010 15:54:50 -0500, Dave Partyka said:<br>
<br>
>I have just merged commits to VTK and ParaView that move ParaView's HDF5<br>
>into VTK. This migration makes it possible for VTK developers to begin using<br>
>HDF5 storage in their own VTK classes and will also allow us to enable HDF5<br>
>functionality in other Utilities (such as HDF5 enabled NetCDF). HDF5 is<br>
>located under Utilities/vtkhdf5. This version of HDF5 is the same that was<br>
>in ParaView (1.8.5) but now is also mangled with vtk as a prefix.<br>
><br>
>I strongly recommend that ParaView developers do a clean build after pulling<br>
>these changes to reduce the likelihood of build failures. We will be<br>
>watching the dashboard carefully for the next few days. If anyone<br>
>experiences any issues please feel free to let us know and/or report a bug.<br>
<br>
</div></div>Dave,<br>
<br>
1) when installing vtk (master) most all .h files go into /include/<br>
vtk-5.9, except a bunch of H5*.h files go directly into /include. Is<br>
that a bug?<br>
<br>
2) Building vtk with clang reports:<br>
<br>
clang: warning: argument unused during compilation: '-std=c99'<br>
<br>
This appears to come from Utilities/vtkhdf5/CMakeLists.txt<br>
<br>
#-----------------------------------------------------------------------------<br>
# Compiler specific flags : Shouldn't there be compiler tests for these<br>
#-----------------------------------------------------------------------------<br>
IF (NOT WIN32)<br>
SET (CMAKE_C_FLAGS "${CMAKE_ANSI_CFLAGS} ${CMAKE_C_FLAGS} -std=c99 -<br>
fomit-frame-pointer -finline-functions -fno-common")<br>
ENDIF (NOT WIN32)<br>
<br>
I believe the comment is correct. :)<br>
<font color="#888888"><br>
--<br>
____________________________________________________________<br>
Sean McBride, B. Eng <a href="mailto:sean@rogue-research.com" target="_blank">sean@rogue-research.com</a><br>
Rogue Research <a href="http://www.rogue-research.com" target="_blank">www.rogue-research.com</a><br>
Mac Software Developer Montréal, Québec, Canada<br>
<br>
<br>
</font></blockquote></div><br>
</div></div></blockquote></div><br>