I am going to change it to 1024 unless someone objects for the immediate term. And then from there switch it to be dynamic and deprecate VTK_MAX_THREAD entirely.<br><br><div class="gmail_quote">On Tue, Jan 25, 2011 at 8:27 AM, David Partyka <span dir="ltr"><<a href="mailto:david.partyka@kitware.com">david.partyka@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">I definitely agree but this looks like it should be given a deprecation cycle as it involves removing API, there are set/get macros and VTK_MAX_THREAD is a const in a global header. Though, nearly all of the usage of VTK_MAX_THREAD is in vtkMultiThreader and it definitely would not be hard to switch it to dynamically store threads.<div>
<br></div><div>That said, I can check in a much larger value for VTK_MAX_THREAD right now. How about 128? 256? 1024? INT_MAX? </div><div><br></div><div>After that, myself or someone else can switch it to use a vector instead of a fixed size array and then add the deprecation macros so people know it's going away. Does this sound reasonable? Or too cautious? :-p<div>
<div></div><div class="h5"><br>
<br><div class="gmail_quote">On Tue, Jan 25, 2011 at 8:04 AM, Will Schroeder <span dir="ltr"><<a href="mailto:will.schroeder@kitware.com" target="_blank">will.schroeder@kitware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I agree with Ken, IMO we should remove hardcoded limits on threads. In fact I can see creating some specialized code to determine the "optimal" number of threads (with provisions for manual override). After all in the Nat'l Lab world that Ken/Sandia resides in, I've heard the dudes talk about hundreds or thousands of processes, etc....it's evolving fast and we don't want to have to keep changing this.<div>
<br>W<br><div><br></div><div><br><br><div class="gmail_quote"><div>On Mon, Jan 24, 2011 at 11:14 AM, Moreland, Kenneth <span dir="ltr"><<a href="mailto:kmorel@sandia.gov" target="_blank">kmorel@sandia.gov</a>></span> wrote:<br>
</div><div><div></div><div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<font face="Calibri, Verdana, Helvetica, Arial"><span style="font-size:11pt">Why is there a hardcoded maximum in the first place? It seems to me that whatever number you choose now will be excessively high and/or obsolete in the coming years as the number of cores per processor grows.<br>
<br>
-Ken<div><div></div><div><br>
<br>
<br>
On 1/24/11 8:04 AM, "Bill Lorensen" <<a href="http://bill.lorensen@gmail.com" target="_blank">bill.lorensen@gmail.com</a>> wrote:<br>
<br>
</div></div></span></font><div><div></div><div><blockquote><font face="Calibri, Verdana, Helvetica, Arial"><span style="font-size:11pt">ITK has had the max set to 128 for quite a while.<br>
<br>
On Mon, Jan 24, 2011 at 9:53 AM, David Partyka<br>
<<a href="http://david.partyka@kitware.com" target="_blank">david.partyka@kitware.com</a>> wrote:<br>
> Sure thing, especially considering one can get a machine with dual<br>
> Hexa-cores + Hyper Threading resulting in 24 available cores.<br>
><br>
> On Mon, Jan 24, 2011 at 9:39 AM, David Cole <<a href="http://david.cole@kitware.com" target="_blank">david.cole@kitware.com</a>> wrote:<br>
>><br>
>> I think it's just old and leftover, and nobody has yet found a compelling<br>
>> need for more than 8 threads on Windows. It should be fine to increase this<br>
>> number, especially if you actually have a Windows box with more than 8<br>
>> processors on it.<br>
>><br>
>> Feel free to change your build locally to increase that value. Perhaps<br>
>> somebody here on the VTK developers list is also contemplating more powerful<br>
>> Window machines these days... Anybody here want to bump this up and commit<br>
>> the change?<br>
>><br>
>><br>
>> On Mon, Jan 24, 2011 at 5:11 AM, Pavel Pokutnev<br>
>> <<a href="http://pavel.pokutnev@googlemail.com" target="_blank">pavel.pokutnev@googlemail.com</a>> wrote:<br>
>>><br>
>>> Hello vtk-devs,<br>
>>><br>
>>> sorry, but I would like to repeat my question.<br>
>>> There is a define VTK_MAX_THREADS in "Common/vtkSystemIncludes.h". It<br>
>>> is defined to 8 for Win32 threads, but for all other platforms to 32.<br>
>>> What is the cause for this non-conformity?<br>
>>><br>
>>> Best regards,<br>
>>> Pavel<br>
>>> _______________________________________________<br>
>>> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
>>><br>
>>> Visit other Kitware open-source projects at<br>
>>> <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
>>><br>
>>> Follow this link to subscribe/unsubscribe:<br>
>>> <a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
>>><br>
>><br>
>><br>
>> _______________________________________________<br>
>> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
>><br>
>> Visit other Kitware open-source projects at<br>
>> <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
>><br>
>> Follow this link to subscribe/unsubscribe:<br>
>> <a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
>><br>
>><br>
><br>
><br>
> _______________________________________________<br>
> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
><br>
> Visit other Kitware open-source projects at<br>
> <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
><br>
> Follow this link to subscribe/unsubscribe:<br>
> <a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
><br>
><br>
><br>
_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
<br>
<br>
<br>
</span></font></blockquote><font face="Calibri, Verdana, Helvetica, Arial"><span style="font-size:11pt"><br>
</span></font></div></div><font size="2"><font face="Consolas, Courier New, Courier"><span style="font-size:10pt"><br>
**** Kenneth Moreland<br>
*** Sandia National Laboratories<br>
*********** <br>
*** *** *** email: <a href="http://kmorel@sandia.gov" target="_blank">kmorel@sandia.gov</a><br>
** *** ** phone: (505) 844-8919<br>
*** web: <a href="http://www.cs.unm.edu/~kmorel" target="_blank">http://www.cs.unm.edu/~kmorel</a><br>
</span></font></font><font face="Calibri, Verdana, Helvetica, Arial"><span style="font-size:11pt"><br>
</span></font>
</div>
<br>_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
<br>
<br></blockquote></div></div></div><br><br clear="all"><br>-- <br>William J. Schroeder, PhD<br>Kitware, Inc.<br>28 Corporate Drive<br>Clifton Park, NY 12065<br><a href="mailto:will.schroeder@kitware.com" target="_blank">will.schroeder@kitware.com</a><br>
<a href="http://www.kitware.com" target="_blank">http://www.kitware.com</a><br>(518) 881-4902<br>
</div></div>
</blockquote></div><br></div></div></div>
</blockquote></div><br>