<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META content="text/html; charset=iso-8859-1" http-equiv=Content-Type>
<META name=GENERATOR content="MSHTML 8.00.6001.18939">
<STYLE></STYLE>
</HEAD>
<BODY bgColor=#ffffff>
<DIV><FONT size=2 face=Arial>Hi David,</FONT></DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<DIV>
<DIV><FONT size=2 face=Arial>There could be a quick exit when b[3] is a zero
vector to avoid any trouble computing scale.</FONT></DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV></DIV>
<DIV><FONT size=2 face=Arial>There is the potential for round off damage and a
small inefficiency by squaring the square root computed by Norm().</FONT></DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<DIV><FONT size=2 face=Arial>I can't get {25./26., 5./26., 0} to make
(1.2, -1.6, 0) in your test program.</FONT></DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<DIV><FONT size=2 face=Arial>HTH</FONT></DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<DIV><FONT size=2 face=Arial>John.</FONT></DIV>
<BLOCKQUOTE
style="BORDER-LEFT: #000000 2px solid; PADDING-LEFT: 5px; PADDING-RIGHT: 0px; MARGIN-LEFT: 5px; MARGIN-RIGHT: 0px">
<DIV style="FONT: 10pt arial">----- Original Message ----- </DIV>
<DIV
style="FONT: 10pt arial; BACKGROUND: #e4e4e4; font-color: black"><B>From:</B>
<A title=david.cole@kitware.com href="mailto:david.cole@kitware.com">David
Cole</A> </DIV>
<DIV style="FONT: 10pt arial"><B>To:</B> <A title=daviddoria+vtk@gmail.com
href="mailto:daviddoria+vtk@gmail.com">David Doria</A> </DIV>
<DIV style="FONT: 10pt arial"><B>Cc:</B> <A title=vtk-developers@vtk.org
href="mailto:vtk-developers@vtk.org">VTK Developers</A> </DIV>
<DIV style="FONT: 10pt arial"><B>Sent:</B> Sunday, September 12, 2010 4:28
PM</DIV>
<DIV style="FONT: 10pt arial"><B>Subject:</B> Re: [vtk-developers] New
function: vtkMath::ProjectVector</DIV>
<DIV><BR></DIV>On Sun, Sep 12, 2010 at 11:15 AM, David Doria <SPAN
dir=ltr><<A
href="mailto:daviddoria+vtk@gmail.com">daviddoria+vtk@gmail.com</A>></SPAN>
wrote:<BR>
<DIV class=gmail_quote>
<BLOCKQUOTE
style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>
<DIV class=im>On Sun, Sep 12, 2010 at 10:40 AM, David Cole <<A
href="mailto:david.cole@kitware.com">david.cole@kitware.com</A>>
wrote:<BR>> If it's only one commit, send a link exactly to that commit,
so people can<BR>> click on it and see the diffs right in their web
browser:<BR>> <A
href="http://github.com/daviddoria/daviddoria-vtk/commit/43efaf1bc09bd8c21e9d15c9366b86b83288f99a"
target=_blank>http://github.com/daviddoria/daviddoria-vtk/commit/43efaf1bc09bd8c21e9d15c9366b86b83288f99a</A><BR>>
If it's a series of commits, be sure you ask for people to look at "the
last<BR>> N commits" or whatever is appropriate.<BR>> I'll let the
math experts chime in and review the actual content of the<BR>>
diffs.<BR>> A review like this would be easier if you would separate out
the "white<BR>> space only" changes into a separate commit, so the people
interested in<BR>> reviewing the actual diff content don't have to wade
through the 80% to find<BR>> the 20%.... :-)<BR>><BR>> David
C.<BR><BR></DIV>Two good points David C. I will definitely link directly to
a commit<BR>in the future.<BR><BR>I didn't intentionally change any
whitespace, I guess there are files<BR>that have not been committed since
the hooks were in place? It looks<BR>my editor removed the trailing
whitespace which shouldn't have been<BR>there in the first place :) Should
we make a pass through and 'touch'<BR>all of the files and commit them so
they are all checked against the<BR>hooks?<BR><BR>David
D.<BR></BLOCKQUOTE></DIV><BR>
<DIV>The white space thing shouldn't be that much of a problem, even with
files that have present "mistakes" in them... The hooks only check *changed*
lines, so maybe change your editor so it doesn't always automatically do
that.....?</DIV>
<DIV><BR></DIV>
<DIV>Any math guys out there to comment on the rest of David D's
changes?</DIV>
<DIV><BR></DIV>
<DIV>Thx,</DIV>
<DIV>David C.</DIV>
<DIV><BR></DIV>
<P>
<HR>
<P></P>_______________________________________________<BR>Powered by
www.kitware.com<BR><BR>Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html<BR><BR>Follow this link to
subscribe/unsubscribe:<BR>http://www.vtk.org/mailman/listinfo/vtk-developers<BR><BR></BLOCKQUOTE></BODY></HTML>