On Sun, Sep 12, 2010 at 11:15 AM, David Doria <span dir="ltr"><<a href="mailto:daviddoria%2Bvtk@gmail.com">daviddoria+vtk@gmail.com</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im">On Sun, Sep 12, 2010 at 10:40 AM, David Cole <<a href="mailto:david.cole@kitware.com">david.cole@kitware.com</a>> wrote:<br>
> If it's only one commit, send a link exactly to that commit, so people can<br>
> click on it and see the diffs right in their web browser:<br>
> <a href="http://github.com/daviddoria/daviddoria-vtk/commit/43efaf1bc09bd8c21e9d15c9366b86b83288f99a" target="_blank">http://github.com/daviddoria/daviddoria-vtk/commit/43efaf1bc09bd8c21e9d15c9366b86b83288f99a</a><br>
> If it's a series of commits, be sure you ask for people to look at "the last<br>
> N commits" or whatever is appropriate.<br>
> I'll let the math experts chime in and review the actual content of the<br>
> diffs.<br>
> A review like this would be easier if you would separate out the "white<br>
> space only" changes into a separate commit, so the people interested in<br>
> reviewing the actual diff content don't have to wade through the 80% to find<br>
> the 20%.... :-)<br>
><br>
> David C.<br>
<br>
</div>Two good points David C. I will definitely link directly to a commit<br>
in the future.<br>
<br>
I didn't intentionally change any whitespace, I guess there are files<br>
that have not been committed since the hooks were in place? It looks<br>
my editor removed the trailing whitespace which shouldn't have been<br>
there in the first place :) Should we make a pass through and 'touch'<br>
all of the files and commit them so they are all checked against the<br>
hooks?<br>
<br>
David D.<br>
</blockquote></div><br><div>The white space thing shouldn't be that much of a problem, even with files that have present "mistakes" in them... The hooks only check *changed* lines, so maybe change your editor so it doesn't always automatically do that.....?</div>
<div><br></div><div>Any math guys out there to comment on the rest of David D's changes?</div><div><br></div><div>Thx,</div><div>David C.</div><div><br></div>