Cool! These look pretty good. I'll try and put them in when I get a chance. Thanks Nicolas!<br><br><div class="gmail_quote">On Tue, Aug 17, 2010 at 2:30 PM, Nicolas Rannou <span dir="ltr"><<a href="mailto:nicolas_rannou@hms.harvard.edu">nicolas_rannou@hms.harvard.edu</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">Hi all,<br>
<br>
Please let me recontact you to know if it is ok to update the vtk master<br>
with the changes I requested?<br>
<br>
Github:<br>
<a href="http://github.com/NicolasRannou/VTK/tree/ffmpeg" target="_blank">http://github.com/NicolasRannou/VTK/tree/ffmpeg</a><br>
<br>
Dashboard:<br>
<a href="http://www.cdash.org/CDash/viewTest.php?onlypassed&buildid=683835" target="_blank">http://www.cdash.org/CDash/viewTest.php?onlypassed&buildid=683835</a><br>
<br>
The writer would still work with the old ffmpeg version but also with<br>
the new one (it is currently not working with the recent versions of<br>
ffmpeg)!<br>
<br>
I submitted a push request on Github a few days ago but it seems that it<br>
has not been updated.<br>
<br>
Thanks!<br>
<font color="#888888"><br>
Nicolas<br>
</font><div><div></div><div class="h5"><br>
On Thu, 2010-07-29 at 19:49 -0400, Nicolas Rannou wrote:<br>
> something like that might be enough:<br>
> GIT repository: git@github.com:NicolasRannou/VTK.git<br>
><br>
><br>
> I just added 2 variables BitRate and BitRateTolerance in the<br>
> vtkFFMPEGWriter.cxx.<br>
> They are initialized to 0.<br>
><br>
><br>
> If they they are not modified( i.e. equal 0), the vtkFFMPEGWriter<br>
> would work exactly in the same way as before.<br>
> If we modifify one of the value, we would use the modified values:<br>
><br>
><br>
> c->bit_rate = BitRate rather than<br>
> c->bit_rate = preset value<br>
><br>
><br>
> and<br>
><br>
><br>
> c->bit_rate_tolerance = BitRateTolerance rather than<br>
> c->bit_rate_tolerance = c->bit_rate/this->FrameRate;<br>
><br>
><br>
> Let me know if it is enough.<br>
> It worked fine for me but more modification might have to be done (not<br>
> sure since I am not a FFMPEG expert).<br>
><br>
><br>
> Nicolas<br>
><br>
><br>
> On Jul 29, 2010, at 4:41 PM, Dave Partyka wrote:<br>
><br>
> > In the past there were no versions of FFMPEG (until just recently)<br>
> > other than svn revisions. So we just picked an arbitrary revision<br>
> > that worked on all of our platforms and stuck with it. Also, we use<br>
> > one of the most basic and mature codecs (mjpeg) which I don't think<br>
> > has changed much? Anyway, keep us posted.<br>
> ><br>
> > On Thu, Jul 29, 2010 at 4:37 PM, Nicolas Rannou<br>
> > <<a href="mailto:Nicolas_Rannou@hms.harvard.edu">Nicolas_Rannou@hms.harvard.edu</a>> wrote:<br>
> > I think that if the ancient FFMPEG is working with the<br>
> > current VTK git master it should still work after.<br>
> > I'm currently using the FFMPEG deb package provided with<br>
> > ubuntu 10.04.<br>
> ><br>
> > I'll fork the VTK git master, commit the changes and let you<br>
> > know as soon as it is done then we can give it a try with<br>
> > Paraview.<br>
> ><br>
> ><br>
> > Is there any reason about using the ancient FFMPEG in<br>
> > Paraview?<br>
> ><br>
> ><br>
> > Nicolas<br>
> ><br>
> ><br>
> > On Jul 29, 2010, at 3:38 PM, Dave Partyka wrote:<br>
> ><br>
> > > I don't have any objections but would like to know if that<br>
> > > change is compatible with the ancient FFMPEG we typically<br>
> > > release ParaView with.<br>
> > ><br>
> > ><br>
> > > <a href="http://www.vtk.org/files/support/ffmpeg_source.tar.gz" target="_blank">http://www.vtk.org/files/support/ffmpeg_source.tar.gz</a><br>
> > ><br>
> > ><br>
> > > On Thu, Jul 29, 2010 at 3:21 PM, Nicolas Rannou<br>
> > > <<a href="mailto:nicolas_rannou@hms.harvard.edu">nicolas_rannou@hms.harvard.edu</a>> wrote:<br>
> > > Hi all,<br>
> > ><br>
> > > We are experimenting issues regarding the usage of<br>
> > > vtkFFMPEGWriter.cxx.<br>
> > > It occurs at least on Mac and Ubuntu 10.04.<br>
> > > You can reproduce the error turning VTK_USE_FFMPEG<br>
> > > ON and running the<br>
> > > associated test. (ctest -R FFMPEG)<br>
> > ><br>
> > > ERROR:<br>
> > > [mjpeg @ 0x2db2f30]bitrate tolerance too small for<br>
> > > bitrate<br>
> > > Generic Warning:<br>
> > > In /home/nr52/GITROOT/VTK/IO/vtkFFMPEGWriter.cxx,<br>
> > > line 197<br>
> > > Could not open codec.<br>
> > ><br>
> > > The problem is located<br>
> > > at /VTK/IO/vtkFFMPEGWriter.cxx:179, where the<br>
> > > bit_rate_tolerance is defined as:<br>
> > > c->bit_rate_tolerance =<br>
> > > c->bit_rate/this->FrameRate;<br>
> > ><br>
> > > Then, this error ("bitrate tolerance too small for<br>
> > > bit-rate") can easily be solved decreasing the<br>
> > > FrameRate.<br>
> > ><br>
> > > Moreover, there is no convenient method to set the<br>
> > > bit-rate.<br>
> > > So far, can only choose between 3 predefined<br>
> > > bit-rates, which is quite restrictive.<br>
> > ><br>
> > > So here is my question: Is there any reason for<br>
> > > not creating variables BitRate and<br>
> > > BitRateTolerance?<br>
> > > If there is no objection, I can take care of it.<br>
> > ><br>
> > > Thanks<br>
> > ><br>
> > ><br>
> > > Nicolas<br>
> > ><br>
> > ><br>
> > > _______________________________________________<br>
> > > Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
> > ><br>
> > > Visit other Kitware open-source projects at<br>
> > > <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
> > ><br>
> > > Follow this link to subscribe/unsubscribe:<br>
> > > <a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
> > ><br>
> > ><br>
> > ><br>
> ><br>
> ><br>
> ><br>
><br>
><br>
<br>
<br>
</div></div></blockquote></div><br>