<div class="gmail_quote">You have mine and David Partyka's support to flip the switch, David Cole already expressed his support. I can push the ParaView and Titan VTK submodules forward too. I am not sure where Berk or Will are, but I think it would be good to see a run of the nightly dashboards for these projects too.</div>
<div class="gmail_quote"><br></div><div class="gmail_quote">Thanks,</div><div class="gmail_quote"><br></div><div class="gmail_quote">Marcus</div><div class="gmail_quote"><br></div><div class="gmail_quote">On Wed, Jul 14, 2010 at 11:55 AM, David Gobbi <span dir="ltr"><<a href="mailto:david.gobbi@gmail.com">david.gobbi@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">Getting back to the BTX/ETX issue, it would like to request permission<br>
to turn off BTX/ETX detection in the wrapper code for at least one<br>
night so that I can see how all the dashboard machines react.<br>
<br>
Last week me and Marcus ran experimental dashboards on Linux, Win32,<br>
and OS X and only two tests failed as a result of the change:<br>
TestTkRenderWidgetPython (which I've fixed) and TestSetGet (which<br>
fails because removing BTX/ETX causes many addition Set/Get methods to<br>
be wrapped). ParaView also continued to compile and test with no<br>
errors, which was expected because the "IGNORE_BTX" option is<br>
currently limited to VTK's own classes and does not apply to external<br>
VTK classes.<br>
<br>
So what do people think? Should I wait, or can I pull the switch this<br>
afternoon?<br>
<font color="#888888"><br>
David<br>
</font><div><div></div><div class="h5"><br>
<br>
On Fri, Jul 9, 2010 at 3:27 PM, David Gobbi <<a href="mailto:david.gobbi@gmail.com">david.gobbi@gmail.com</a>> wrote:<br>
> Okay, my VTK_IGNORE_BTX Win32 test finished (just nmake, not devenv).<br>
> Exactly the same expected failures: TestSetGet and<br>
> TestTkRenderWidgetPython<br>
><br>
> <a href="http://www.cdash.org/CDash/viewTest.php?onlyfailed&buildid=660432" target="_blank">http://www.cdash.org/CDash/viewTest.php?onlyfailed&buildid=660432</a><br>
><br>
> The TestTkRenderWidgetPython test failure really does seem to be due<br>
> to the fact that this is an old crufty test, since the<br>
> vtkTkRenderWidget actually does work in Python.<br>
><br>
> David<br>
><br>
><br>
> On Fri, Jul 9, 2010 at 12:01 PM, David Gobbi <<a href="mailto:david.gobbi@gmail.com">david.gobbi@gmail.com</a>> wrote:<br>
>> I just built ParaView on linux64 with VTK_IGNORE_BTX and it looks good:<br>
>><br>
>> The following tests FAILED:<br>
>> 27 - PrintSelf-PVServer-Common (Failed)<br>
>> 28 - PrintSelf-PVServer-Filters (Failed)<br>
>> 29 - PrintSelf-PVServer-ServerManager (Failed)<br>
>> 97 - pvcs.PropertyLink (Failed)<br>
>> 137 - pvcrs.PropertyLink (Failed)<br>
>><br>
>> The PrintSelf tests always fail on my machine, and the PropertyLink<br>
>> tests are also failing on the continuous dashboard, so no worries<br>
>> about them either.<br>
>><br>
>> Here are the results for an OSX 10.6 build of just VTK by itself:<br>
>><br>
>> The following tests FAILED:<br>
>> 65 - TestSetGet (SEGFAULT)<br>
>> 751 - TestGaussianBlurPass (Failed)<br>
>> 768 - TestOpacity (Failed)<br>
>> 783 - TestTranslucentLUTDepthPeeling (Failed)<br>
>> 784 - TestTranslucentLUTDepthPeelingPass (Failed)<br>
>> 786 - TestTranslucentLUTTextureDepthPeeling (Failed)<br>
>> 843 - TestTkRenderWidgetPython-image (Failed)<br>
>><br>
>> All those GPU tests always fail on my system, so only the TestSetGet<br>
>> and TkRenderWidgetPython tests concern me, and both are expected.<br>
>><br>
>> So I'd have to do nmake and devenv builds to be sure, but it looks<br>
>> like VTK_IGNORE_BTX is a pretty safe option now.<br>
>><br>
>> David<br>
>><br>
>><br>
>><br>
>> On Fri, Jul 9, 2010 at 10:10 AM, David Gobbi <<a href="mailto:david.gobbi@gmail.com">david.gobbi@gmail.com</a>> wrote:<br>
>>> Thanks. I've seen TestTkRenderWidget failures, too, and I suspect<br>
>>> that the test itself is broken.<br>
>>><br>
>>> I've just pushed my safer BTX/ETX ignore code. This should allow<br>
>>> VTK_IGNORE_BTX to be used even with ParaView and Titan.<br>
>>><br>
>>> David<br>
>>><br>
>>><br>
>>> On Fri, Jul 9, 2010 at 9:45 AM, Marcus D. Hanwell<br>
>>> <<a href="mailto:marcus.hanwell@kitware.com">marcus.hanwell@kitware.com</a>> wrote:<br>
>>>> On Fri, Jul 9, 2010 at 11:38 AM, David Cole <<a href="mailto:david.cole@kitware.com">david.cole@kitware.com</a>> wrote:<br>
>>>>><br>
>>>>> On Fri, Jul 9, 2010 at 11:16 AM, David Gobbi <<a href="mailto:david.gobbi@gmail.com">david.gobbi@gmail.com</a>><br>
>>>>> wrote:<br>
>>>>>><br>
>>>>>> The one dashboard test that is guaranteed to break is TestSetGet.<br>
>>>>>> Some of the BTX'd methods are Get methods that segfault when they are<br>
>>>>>> called, and if BTX is ignored, then TestSetGet will call them. These<br>
>>>>>> methods will either have to be fixed or excluded from TestSetGet.<br>
>>>>><br>
>>>>> The main point of that test is to ensure that any Get method may be called<br>
>>>>> directly after instantiating any VTK object. I would argue for fixing, not<br>
>>>>> excluding. VTK should not crash if somebody "accidentally" calls a Get<br>
>>>>> method before the object is ready for it. It should just return 0, or false,<br>
>>>>> or uninitialized...<br>
>>>>> It might be ok to add error or warning macro output, but crashing is not<br>
>>>>> cool.<br>
>>>><br>
>>>> So, here is my experimental dashboard. I can add this to my crontab until it<br>
>>>> is more globally enabled. You can see three tests failing there.<br>
>>>><br>
>>>> <a href="http://www.cdash.org/CDash/viewTest.php?onlyfailed&buildid=660272" target="_blank">http://www.cdash.org/CDash/viewTest.php?onlyfailed&buildid=660272</a><br>
>>>> Marcus<br>
>>>> --<br>
>>>> Marcus D. Hanwell, Ph.D.<br>
>>>> R&D Engineer, Kitware Inc.<br>
>>>> (518) 881-4937<br>
>>>><br>
>>><br>
>><br>
><br>
</div></div></blockquote></div><br>