Maybe it's just me.... but I don't think we should be using freetype type definitions as argument types in public VTK methods.<div><br></div><div>Does that concern anyone else that we let implementation details bleed into the API? Or is it just me?</div>
<div><br></div><div><br></div><div>Thx,</div><div>David C.</div><div><br><br><div class="gmail_quote">On Tue, Jul 6, 2010 at 1:25 PM, Marcus D. Hanwell <span dir="ltr"><<a href="mailto:marcus.hanwell@kitware.com">marcus.hanwell@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div class="gmail_quote"><div class="im">On Tue, Jul 6, 2010 at 1:13 PM, Marco Nolden <span dir="ltr"><<a href="mailto:m.nolden@dkfz-heidelberg.de" target="_blank">m.nolden@dkfz-heidelberg.de</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>On 07/06/2010 06:11 PM, Marcus D. Hanwell wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I would prefer publishing on a public repository, but am not informed<br>
about pull requests on Github/Gitorious. I would certainly preserve<br>
authorship information, and recently integrated a patch from David Feng<br>
with preserved authorship. We also worked with David Gobbi on the<br>
wrapping branch.<br>
</blockquote>
<br></div>
I think pull requests in GitHub are just an easy way to send a link to people with write access, without much functionality. Gitorious' merge requests are public, they have a status and the possibility to comment, e.g. <a href="http://qt.gitorious.org/qt/qt/merge_requests" target="_blank">http://qt.gitorious.org/qt/qt/merge_requests</a></blockquote>
<div><br></div></div><div>Yes - I have been using merge request on gitorious, and would favor this as a public list we could view, and comment on.</div><div class="im"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Sorry if I missed this one, the change looks reasonable and I can take a<br>
look at it. It would be good to see improved unicode support too. It is<br>
something that the ARB should probably be discussing, but it would be<br>
great to involve the community as far as is possible.<br>
<br>
Marcus<br>
<br>
</blockquote></div>
Actually I revised it a bit, so the link is here:<br>
<br>
<a href="http://github.com/nolden/VTK/commit/9b76af72e6016fcd4a7b2e1a58edb77eb5549eef" target="_blank">http://github.com/nolden/VTK/commit/9b76af72e6016fcd4a7b2e1a58edb77eb5549eef</a><br>
<br>
and the patch is attached.<br></blockquote><div><br></div></div><div>There were some trailing whitespaces added, I have removed those and rebased the commit on master HEAD. I will rebuild and test this out, but at first glance it looks good. I just added your remote in the end, and fetched from that. I will see about adding some regression tests for unicode text rendering.</div>
<div><br></div><div>One of the benefits of Git is the ease with which patches can flow, I definitely want us to take maximum advantage of that. We are still looking at what the best ways to achieve this are.</div><div><br>
</div><div>Thanks,</div><div><br></div><font color="#888888"><div>Marcus</div></font><div><div></div><div class="h5"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>
On Tue, Jul 6, 2010 at 12:06 PM, Moreland, Kenneth <<a href="mailto:kmorel@sandia.gov" target="_blank">kmorel@sandia.gov</a><br></div><div>
<mailto:<a href="mailto:kmorel@sandia.gov" target="_blank">kmorel@sandia.gov</a>>> wrote:<br>
<br>
Is submitting patches to the mailing list now the officially<br>
sanctioned method of providing contributions (as opposed to<br>
publishing on a public repository such as Marco has done)? Will<br>
this change in the near future when we plan to move to a branchy<br>
workflow (which as I understand it now has plans for a more open<br>
“staging” repository)?<br>
<br>
Perhaps this would be a good topic for the next ARB.<br>
<br>
-Ken<br>
<br>
<br>
<br>
On 7/6/10 7:38 AM, "Dave Partyka" <<a href="mailto:dave.partyka@kitware.com" target="_blank">dave.partyka@kitware.com</a><br></div><div>
<<a href="http://dave.partyka" target="_blank">http://dave.partyka</a>@<a href="http://kitware.com" target="_blank">kitware.com</a>>> wrote:<br>
<br>
The most visible way is to send a patch to the vtk list. If you<br>
use the git patch commands you can create patches that will<br>
preserve the author (Marco in this case) as git has separate<br>
Author and Committer fields. See this wiki at the bottom on how<br>
to create a patch.<br>
<br>
<a href="http://vtk.org/Wiki/VTK/Git#Submitting_a_patch" target="_blank">http://vtk.org/Wiki/VTK/Git#Submitting_a_patch</a><br>
<br>
On Tue, Jul 6, 2010 at 9:24 AM, Jean-Christophe Fillion-Robin<br>
<<a href="mailto:jchris.fillionr@kitware.com" target="_blank">jchris.fillionr@kitware.com</a><br></div><div>
<<a href="http://jchris.fillionr" target="_blank">http://jchris.fillionr</a>@<a href="http://kitware.com" target="_blank">kitware.com</a>>> wrote:<br>
<br>
Hi Folks,<br>
<br>
Since VTK souce code is available using Git, the repository<br>
can be forked very easily and people can contribute quite<br>
easily.<br>
<br>
Being also available on github, Marco from DKFZ (German<br>
research cancer institute) forked it and added a patch. As<br>
he mentioned, "Pull request" doesn't seem to "work". What<br>
could be the best way for him to share his patch.<br>
<br>
Beside of the following page<br>
<a href="http://www.vtk.org/VTK/project/getinvolved.html" target="_blank">http://www.vtk.org/VTK/project/getinvolved.html</a> ,<br>
Is there any documentation available regarding the<br>
"contribution" workflow ?<br>
Is the mailing list the preferred way to share contribution ?<br>
Will the ownership of the original "patcher" be maintained ?<br>
<br>
I added Marco in CC, feel free to answer that email and let<br>
him know the best way to share his work.<br>
<br>
Thks<br>
Jc<br>
<br>
<br>
---------- Forwarded message ----------<br></div><div>
From: *GitHub* <<a href="mailto:noreply@github.com" target="_blank">noreply@github.com</a> <<a href="http://noreply" target="_blank">http://noreply</a>@<a href="http://github.com" target="_blank">github.com</a>>><br>
Date: Wed, Jun 30, 2010 at 9:17 AM<br>
Subject: [GitHub] nolden sent you a pull request from nolden/VTK<br>
To: <a href="mailto:jchris.fillionr@kitware.com" target="_blank">jchris.fillionr@kitware.com</a><br></div><div>
<<a href="http://jchris.fillionr" target="_blank">http://jchris.fillionr</a>@<a href="http://kitware.com" target="_blank">kitware.com</a>><br>
<br>
<br>
<br>
<br>
nolden wants you to pull from nolden/VTK at 9ba9588<br>
<br>
Body: Hi,<br>
<br>
this is a bugfix for the rendering of utf8 characters. The<br>
handling of signed / unsigned was incorrect. As a result<br>
only 7bit characters were rendered, though in general the<br>
code was ok for 8bit characters.<br>
<br>
cc Steven and JC, since I don't know if the "KItware" user<br>
reads pull requests.<br>
<br>
View repository:<br>
<a href="http://github.com/nolden/VTK/tree/9ba958806256e38ae4ae4fc424c37f8a7eea2ae9" target="_blank">http://github.com/nolden/VTK/tree/9ba958806256e38ae4ae4fc424c37f8a7eea2ae9</a><br>
<br>
<br>
<br>
<br>
**** Kenneth Moreland<br>
*** Sandia National Laboratories<br>
***********<br></div>
*** *** *** email: <a href="mailto:kmorel@sandia.gov" target="_blank">kmorel@sandia.gov</a> <<a href="http://kmorel" target="_blank">http://kmorel</a>@<a href="http://sandia.gov" target="_blank">sandia.gov</a>><div>
<br>
** *** ** phone: (505) 844-8919<br>
*** web: <a href="http://www.cs.unm.edu/~kmorel" target="_blank">http://www.cs.unm.edu/~kmorel</a><br>
<br>
<br>
_______________________________________________<br></div>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a> <<a href="http://www.kitware.com" target="_blank">http://www.kitware.com</a>><div><br>
<br>
Visit other Kitware open-source projects at<br>
<a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
<br>
<br>
<br>
</div></blockquote>
<br>
</blockquote></div></div></div><br>
<br>_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
<br>
<br></blockquote></div><br></div>