<div class="gmail_quote">On Thu, Jun 17, 2010 at 4:40 PM, Clinton Stimpson <span dir="ltr"><<a href="mailto:clinton@elemtech.com">clinton@elemtech.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<br>
Can you key off the existence of a pushurl?<br>
But I also wonder how this would keep the hooks updated?<br></blockquote><div><br></div><div>We could possibly be clever and do a little regex to check for the git@ form of the url/pushurl. I hadn't considered being that sneaky, but it sound like a viable approach and would ease the dashboard pain.</div>
<div><br></div><div>Marcus</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div><div></div><div class="h5"><br>
On Thursday, June 17, 2010 02:13:37 pm Marcus D. Hanwell wrote:<br>
> On Thu, Jun 17, 2010 at 4:06 PM, Moreland, Kenneth <<a href="mailto:kmorel@sandia.gov">kmorel@sandia.gov</a>>wrote:<br>
> > That’s a good point about CMake modifying the source tree, but I think<br>
> ><br>
> > this is one of those cases we should let the rule slide. In this case we<br>
> > are installing what, IMHO, git should be pulling for us. Although the<br>
> > Wiki says its optional, it really should be enforced for anyone who<br>
> > makes any commit to any repository.<br>
><br>
> We came to a similar conclusion in Titan, but I am not sure about letting<br>
> the rule slide. This is new territory though, and it is just my take<br>
><br>
> > I’m less thrilled about the “error if not installed” option because it<br>
> > still pushes the responsibility back on every developer. It could also<br>
> > wreck havoc on the dashboards as there will be a delay in getting someone<br>
> > to fix the warning. But if that is the general consensus, it’s way<br>
> > better than what we have now, which is nothing. If that is the path we<br>
> > choose to<br>
> ><br>
> > follow, then I would hope that the following could be be features:<br>
> > - CMake be very insistent about installing the hooks. It should not<br>
> > be easy to miss or ignore the error.<br>
> > - The error should give clear instructions on how to install the<br>
> > hooks.<br>
> ><br>
> > It’s annoying to have to find it in the Wiki every time.<br>
> ><br>
> > - The check should also look for any updates to the hooks in addition<br>
> > to just seeing if they are installed. One of the problems I run into<br>
> > is that even though I try to be diligent about installing hooks, I<br>
> > miss changes pushed to the repository.<br>
> > - The check should turn itself off if not run in a git repository. A<br>
> > user who downloaded the source from the web would never be able to<br>
> > satisfy the requirement.<br>
><br>
> The checks in Titan have all but the third feature. That would be a<br>
> valuable general addition though, and I think there is some code floating<br>
> around that could help us to accomplish this. It would be good to hear how<br>
> others feel about this, but we should certainly be making these things as<br>
> easy as possible for our developers. I will see what our software process<br>
> type people think - Brad, Dave, Bill?<br>
><br>
> Marcus<br>
> --<br>
> Marcus D. Hanwell, Ph.D.<br>
> R&D Engineer, Kitware Inc.<br>
> (518) 881-4937<br>
</div></div></blockquote></div><br>