<span class="Apple-style-span" style="border-collapse: collapse; "><div>(Sorry if this is a duplicate, apparently I was not a member of vtk-developers)</div><div><br></div>We added the files (and several others) that you mention to the exception list though it is not automatic but can be made to do so easily by just skipping vtk*Private.h header files.</span><br>
<br><div class="gmail_quote">On Sun, Jun 7, 2009 at 12:57 PM, Thompson, David C <span dir="ltr"><<a href="mailto:dcthomp@sandia.gov">dcthomp@sandia.gov</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
The other occasion I can think of that will require an exception<br>
is when a private implementation must be shared between<br>
classes such as Hybrid/vtkExodusIIReaderPrivate.h or<br>
IO/vtkMySQLDatabasePrivate.h. These header files are usually<br>
not subclasses of vtkObject and listed in the HeaderTesting<br>
exceptions -- both of which could help automate adding an<br>
exception to the CVS commit check for them.<br>
<br>
David<br>
________________________________________<br>
From: <a href="mailto:vtk-developers-bounces@vtk.org">vtk-developers-bounces@vtk.org</a> [<a href="mailto:vtk-developers-bounces@vtk.org">vtk-developers-bounces@vtk.org</a>] On Behalf Of Berk Geveci [<a href="mailto:berk.geveci@kitware.com">berk.geveci@kitware.com</a>]<br>
Sent: Friday, June 05, 2009 18:47<br>
To: Dave Partyka<br>
Cc: VTK Developers<br>
Subject: Re: [vtk-developers] STL in VTK Header Files<br>
<div><div></div><div class="h5"><br>
Is there a way of by-passing this commit check? There are a rare<br>
occasions where it may be necessary to commit code which include STL<br>
headers in .h files.<br>
<br>
To remind everyone why the decision to keep STL headers from include<br>
files was made: performance. STL headers are bulky and may slow down<br>
compilation significantly if they are included in header files that<br>
are included by a lot of other files. Including STL headers in the<br>
include files of leaf classes (such as concrete algorithm classes)<br>
does not have any effect on compilation time. There are no other good<br>
reasons why STL headers cannot be included in header files.<br>
<br>
Here is the catch: we occasionally receive contributions that include<br>
STL header in .h. These tend to be super big reader classes. Fixing<br>
the whole darn thing to use PIMPL is a waste of time which we don't<br>
have. So, if we do not provide a way of having exception to this rule,<br>
those contributions would never make it into VTK.<br>
<br>
So we should either provide a way of by-passing this commit check in<br>
these rare occasions or we should enforce this through a header test<br>
which can support such exceptions.<br>
<br>
-berk<br>
<br>
On Fri, Jun 5, 2009 at 5:13 PM, Francois<br>
Bertel<<a href="mailto:francois.bertel@kitware.com">francois.bertel@kitware.com</a>> wrote:<br>
> Isn't already enforced by HeaderTesting-* tests ?<br>
><br>
> PS: I continue the discussion on vtk-developers only as this is the<br>
> canonic place to discuss about this topic.<br>
><br>
> On Fri, Jun 5, 2009 at 4:42 PM, Dave Partyka<<a href="mailto:dave.partyka@kitware.com">dave.partyka@kitware.com</a>> wrote:<br>
>> Hi everyone,<br>
>> A new CVS commit check has been added to prevent commits of VTK header files<br>
>> that contain STL includes. Exceptions can be added by contacting myself or<br>
>> Brad King.<br>
>> I also want to give a friendly reminder that the VTK coding standards (VTK<br>
>> has coding standards???) provide guidelines for using STL in VTK and require<br>
>> that STL not be used in header files. See the following for more information<br>
>> or feel free to ask me if you have any questions.<br>
>> VTK Coding Standards:<br>
>> <a href="http://www.vtk.org/Wiki/VTK_Coding_Standards" target="_blank">http://www.vtk.org/Wiki/VTK_Coding_Standards</a><br>
>> VTK FAQ regarding STL<br>
>> <a href="http://www.vtk.org/Wiki/VTK_FAQ#Can_I_use_STL_with_VTK.3F" target="_blank">http://www.vtk.org/Wiki/VTK_FAQ#Can_I_use_STL_with_VTK.3F</a><br>
>> Also please report any problems/bugs with the new commit check to myself or<br>
>> Brad King.<br>
>> Thanks very much!<br>
><br>
><br>
><br>
> --<br>
> François Bertel, PhD | Kitware Inc. Suite 204<br>
> 1 (518) 371 3971 x113 | 28 Corporate Drive<br>
> | Clifton Park NY 12065, USA<br>
> _______________________________________________<br>
> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
><br>
> Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
><br>
> Follow this link to subscribe/unsubscribe:<br>
> <a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
><br>
><br>
_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
<br>
<br>
<br>
</div></div></blockquote></div><br>